- 30 Nov, 2019 1 commit
-
-
Ben Clayton authored
The full list of optimization passes was taken from RegisterPerformancePasses(). Let's just call that instead of copying the list. This way, we'll keep track of new optimization passes, or re-orderings that are deemed 'better' when updating SPIRV-Tools. Bug: b/144832356 Change-Id: I90c69131b5e55c185892cefc2e5de8180b44ce9d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38454 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
- 29 Nov, 2019 2 commits
-
-
Paul Thomson authored
Refactor the dEQP runner functions into a package so that others can re-use them. Change-Id: Ia9c92ca708c3f17a87687c2627843922a8c27514 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38812 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Paul Thomson <paulthomson@google.com>
-
SwiftShader Regression Bot authored
Change-Id: If68454e87d38be521e56a220efd3dad5d2740997 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38848 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
- 28 Nov, 2019 14 commits
-
-
Ben Clayton authored
Instead of rolling yet another version. Bug: b/145351270 Change-Id: Id272ed53278571741e5cdf80dbc7559781163a3d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38820Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
The `dbg` / `Debug` suffix is going to be used to implement parts of the new Vulkan shader debugger. Bug: b/145351270 Change-Id: Ifdd45692aa285ba7875b052857c2ea601f995da2 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38819Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
Bug: b/145336353 Change-Id: Ia6ec5eebd290538c9c183cedac0226f688342dc2 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38818Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Bug: b/145336353 Change-Id: Idaa0f1b260361b9bce4f3b9890c083a07f605e6a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38817Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Bug: b/145336353 Change-Id: Ie988c583d2429dac65aaacadf7c89598cd5996c5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38816 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Bug: b/145336353 Change-Id: I202a8c4a126b2de25703bdde6409e878d4f33d31 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38815 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Bug: b/145336353 Change-Id: I69d91df9045e003474abf3b258ce168bb08be7dc Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38814 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Bug: b/145336353 Change-Id: I19b9ee325d349e5a0c6ca79cdac2ee1ac8d227a2 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38813 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Bug: b/145336353 Change-Id: I1b78cd03247e64f06de77da07b7f08bbc25e326f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38811 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Bug: b/145336353 Change-Id: I39a5bffc1784c7b35ab9c4016658f4532d6ce5fb Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38810 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
SpirvShader had a lot of utility functions in an anonymous namespace at the top of the file. Given that we're going to try splitting up this huge file, we need somewhere common for this code to live. ShaderCore looks like the most appropriate place for this right now. Bug: b/145336353 Change-Id: If4137875098fbeb761fdf63caf8d45011236cff1 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38809 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Jamie Madill authored
The correct usage is to use root_out_dir in the output file name and to use root_build_dir in the rebased arguments. Fixes the 32-bit NACL build on Windows. (Tested locally) Bug: dawn:283 Change-Id: I1d6ca062306a4662eef5c922296e9c95fb047acd Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38828Reviewed-by:
Corentin Wallez <cwallez@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Jamie Madill <jmadill@chromium.org> Presubmit-Ready: Jamie Madill <jmadill@chromium.org> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
Instead of the Khronos gitlab repo. The gitlab repo requires authentication, and seems to interact badly with Google's extra SSH layers. Change-Id: I982bf103d83ed33c7438562992c21f93abb05725 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38808Tested-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
-
Alexis Hetu authored
Multisampled Bresenham lines must be rendered the same way as non multisampled Bresenham lines, so use the same coverage mask for all samples in that case. Bug: b/142965928 Change-Id: Ifc0e141e4f1d9ae48c064896405164db3addd521 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38788 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
- 27 Nov, 2019 3 commits
-
-
Alexis Hetu authored
- Added support for the sample operand in SamplerCore, which simply involves offsetting the buffer by the the sampleId * samplePitch. - Also added a check so that sampleId is within the expected range and doesn't cause reading memory out of bounds. Bug: b/135265531 Change-Id: Ie828d07db41d36befb34037156736a6576af0676 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38728Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Jamie Madill authored
We should be using root_out_dir, not root_build_dir. This was causing issues with NaCL. GN descriptions: root_out_dir: [string] Root directory for toolchain output files. root_build_dir: [string] Directory where build commands are run. Bug: dawn:283 Change-Id: I0730b96d303151b715672d6937031e557e1994f0 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38748Reviewed-by:
Corentin Wallez <cwallez@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Jamie Madill <jmadill@chromium.org>
-
Chris Forbes authored
UBOs can be significantly larger than our constant register file. Don't clamp indexes into them. We *should* catch accesses outside the bound region of the UBO as well, but that's a preexisting bug (consider a UBO region smaller than the constant register file), and we don't have the limit available here. Bug: b/145227408 Change-Id: I67aae6ba9a10290c1b69587808e274c481925078 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38708 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Chris Forbes <chrisforbes@google.com>
-
- 26 Nov, 2019 3 commits
-
-
Ben Clayton authored
Complex SFINAE expressions appear to be broken on the latest release of MSVC 2017. MSVC++ 14.15 (Visual Studio 2017 version 15.8): The parent change compiles fine. MSVC++ 14.16 (Visual Studio 2017 version 15.9): `error C2039: 'type': is not a member of 'std'` for some CToReactorPtr specializations that use `std::enable_if`. Replacing these `typename std::enable_if<T>::type` with `enable_if_t<T>` works around the issue (while also making the template expressions easier to read). I was unable to find an existing MSVC bug report for this problem, and so I will create one. Bug: swiftshader:141 Change-Id: I7e953dbc719d7cb656aa7f16656c3f86ffad5522 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38688 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
SwiftShader Regression Bot authored
Change-Id: I85bfa4a040ec6b45ca0637ab4eb5b7b6c8c26275 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38668 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Ben Clayton authored
* changes: Update SPIRV-Tools to d552f632 Squashed 'third_party/SPIRV-Tools/' changes from 65e362b7a..c3f22f7cb Update SPIRV-Headers to 0f9a2dc9 Squashed 'third_party/SPIRV-Headers/' changes from e4322e3be..af64a9e82
-
- 25 Nov, 2019 10 commits
-
-
Jonah Ryan-Davis authored
This is the correct behavior according to the spec. This CL modifies MetalSurface, XcbSurfaceKHR and XlibSurfaceKHR. Bug: swiftshader: 140 Change-Id: I3f1829506a9d95c11c07f6a3a9ea1e7557e78725 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38648 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Jonah Ryan-Davis <jonahr@google.com>
-
Corentin Wallez authored
ANGLE already has this logic, but with Dawn looking to use Swiftshader as well, there would have been a conflict when both ANGLE and Dawn tried to generate the same ICD JSON file. Having this logic in Swiftshader's GN files means that any number of component of projects using GN (aka Chromium) can use swiftshader without issues. Bug: dawn:283 Change-Id: I8531c98c370db01563dc102f259164e0393242ca Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38491 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Corentin Wallez <cwallez@google.com>
-
Chris Forbes authored
This is part of VK_EXT_line_rasterization, which we claim to support. The stippled line feature itself is not supported, so apps must not call this function. Bug: b/144183516 Test: dEQP-VK.api.version_check.entry_points Change-Id: I935be72717184b2e8b1a51cb8e411d66a9fcfa52 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38628Tested-by:
Chris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Alexis Hetu authored
- Added a loop for handling pNext pointers everywhere in libVulkan.cpp where the wasn't already one, in order to always output the unsupported structure type(s) received by the library - Changed UNIMPLEMENTED to WARN for unhandled pNext pointers Fixes the test: dEQP-VK.api.smoke.triangle_ext_structs Bug: b/144999059 b/119321052 Change-Id: Id83b5e74c8925dbd38651747b0cea46fac4a69a4 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38548 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Sean Risser <srisser@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
AWoloszyn authored
pResults was not getting filled in correctly. As per the spec: pResults is an array of VkResult typed elements with swapchainCount entries. Applications that do not need per-swapchain results can use NULL for pResults. If non-NULL, each entry in pResults will be set to the VkResult for presenting the swapchain corresponding to the same index in pSwapchains. Bug: b/144766511 Change-Id: I42fcb6d96218d4dbfa60e857226c0aed72e7d8ca Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38369Reviewed-by:
Chris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Tested-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Andrew Woloszyn <awoloszyn@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
SwiftShader Regression Bot authored
Change-Id: I1522a335fc3fe7f46c1533baf244ee3ad6ae2b9a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38492Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Chris Forbes <chrisforbes@google.com>
-
Adam Kallai authored
It was originally committed into LLVM: https://reviews.llvm.org/D69434 This CL aims to continue the work on Swiftshader for Windows on ARM64. Bug: chromium:893460 Change-Id: Ib0de220c1d332f2a16d2275a5f3aef4d1a53ee33 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38453Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
Bug: b/139528538 Change-Id: I11d25399f582393ede13cbd8349c79cb3fdf4053 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38608Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Build error: `You got a tab character in here. Tabs are evil. Convert to spaces.` Bug: b/139528538 Change-Id: Ic06cc9e0aafa0a4d3517fc13428724d6fe40e0b5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38589Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Build error: `You got a tab character in here. Tabs are evil. Convert to spaces.` Bug: b/139528538 Change-Id: I937f96d3aeae48103510c0faab6bec9499a290dc Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38588 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
- 22 Nov, 2019 5 commits
-
-
Chris Forbes authored
The purpose of this function is to express *additional* restrictions beyond those imposed by the device limits. We have no such restrictions to impose, so should *always* claim support, not *never*. Test: dEQP-VK.api.maintenance3_check.descriptor_set Bug: b/145007346 Change-Id: Ibacc9336c0900fe0d7af239c58b930bcd13bcd3b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38549Tested-by:
Chris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Sean Risser authored
The Vulkan spec states that if an implementation does not support an extension, then it must ignore all fields other than pNext and pType and continue on without processing any further information contained in the extension's structure. We've been using asserts to log these situations so we can tell which extension structs people are trying to use. This CL changes our behavior so we silently log these unsupported extensions, and warn a user once if they're debugging. Retrying this after updating build files to include added VkStringify.*pp files. Bug: b/139528538 Change-Id: Icd4ea3f53bf2eec5c2c81079b2ebbaa1b9a855db Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38568 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Sean Risser <srisser@google.com> Presubmit-Ready: Sean Risser <srisser@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Alexis Hetu authored
Added new functions to explicitly mark some new extension features as not supported. Fixes the following test: dEQP-VK.api.info.get_physical_device_properties2.features Bug: b/144945388 Change-Id: Id4c5da51d42537f5e1d92352eece67d4e7f5b930 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38531 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
SwiftShader Regression Bot authored
Change-Id: I6f56a6e953415cc40eb692a0a019ab2330d63078 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38409 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Alexis Hetu authored
In libVulkan.cpp, many structures are received as pointers, which are dereferenced, only to be references on the next line. We can just take the pointers as is. Bug: b/144943261 Change-Id: I60585ab5e953dc9baf1f6951a3762c890ab95641 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38530 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
-
- 21 Nov, 2019 2 commits
-
-
Sean Risser authored
Reason for revert: Didn't update a build file, which broke the build and commit queue. Bug: b/139528538 Change-Id: I45cd93a01d984175c2dba5351a4cdd1154e50f31 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38528 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Alexis Hetu authored
Update from: https://github.com/KhronosGroup/Vulkan-Headers To revision: 24347673152e093a48efbf65dfd3b06026b6ed33 Did not modify vulkan.h, so vulkan_fuchsia_extras.h was not removed from it. Bug: b/143197472 Change-Id: Ia96ca3b15fb5d04b4bb5155ae33f39d75043e0fe Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38529 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-