We only need to know the array size during materialization of Array<> types, so store it only for that class and make the allocation a virtual method. This change removes the REACTOR_MATERIALIZE_LVALUES_ON_DEFINITION option, since it requires knowing the full size of Variable at construction, which would require Array<> to still pass that into the Variable constructor. If we need an debugging feature like this again, we could also materialize variables on first use instead of at construction. Bug: b/155302798 Change-Id: I65b02c1258643dcbd3ae18f3f097cb815efa0830 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/45148 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:Nicolas Capens <nicolascapens@google.com> Kokoro-Result: Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| BUILD.gn | Loading commit data... | |
| CMakeLists.txt | Loading commit data... | |
| CPUID.cpp | Loading commit data... | |
| CPUID.hpp | Loading commit data... | |
| Coroutine.hpp | Loading commit data... | |
| Debug.cpp | Loading commit data... | |
| Debug.hpp | Loading commit data... | |
| EmulatedReactor.cpp | Loading commit data... | |
| EmulatedReactor.hpp | Loading commit data... | |
| ExecutableMemory.cpp | Loading commit data... | |
| ExecutableMemory.hpp | Loading commit data... | |
| LLVMJIT.cpp | Loading commit data... | |
| LLVMReactor.cpp | Loading commit data... | |
| LLVMReactor.hpp | Loading commit data... | |
| LLVMReactorDebugInfo.cpp | Loading commit data... | |
| LLVMReactorDebugInfo.hpp | Loading commit data... | |
| Nucleus.hpp | Loading commit data... | |
| Optimizer.cpp | Loading commit data... | |
| Optimizer.hpp | Loading commit data... | |
| Print.hpp | Loading commit data... | |
| Reactor.cpp | Loading commit data... | |
| Reactor.hpp | Loading commit data... | |
| ReactorBenchmarks.cpp | Loading commit data... | |
| ReactorDebugInfo.cpp | Loading commit data... | |
| ReactorDebugInfo.hpp | Loading commit data... | |
| ReactorUnitTests.cpp | Loading commit data... | |
| Routine.hpp | Loading commit data... | |
| SubzeroReactor.cpp | Loading commit data... | |
| Traits.hpp | Loading commit data... | |
| Traits.inl | Loading commit data... | |
| x86.hpp | Loading commit data... |