They're  enabled via the chromium_code config already these days.
No intended behavior change.

Bug: chromium:926235,chromium:428099

Change-Id: I6927d6e3ec85f40454da61969d7a22dfabef1bde
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1564781Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/82ebbbba15c2..98b3f26c2f1f


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@98b3f26c2f1f

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=ynovikov@google.com

Change-Id: I6b754fbe2656eca4ceb730919a47206fb7eb5b60
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1565771Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Texture "types" are the same as texture "targets" except for cube maps.
Cube map targets specify a single face. Cube map types specify a whole
cube map. The subImage functions should take a target instead of a
type. We were using both in different places. This CL corrects all uses
in subImage calls to "target". It also adds a helper for getting a
target texture from a target. And clarifies the naming of the texture
query methods.

Bug: angleproject:3356
Change-Id: I06eb5c5666eec9b8934becf2ba57a066d5cdabde
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558672
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Flaky on Win NVIDIA D3D11

Bug: angleproject:3359
Change-Id: I56a0e4266f1cd0913852a43852666dee055a8e00
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1564562Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

This partially reverts the following change:

60ec8f576 Vulkan: break dependency to the depthClamp feature

The feature is no longer necessary, and simplifies the usage of
utility shaders.

Bug: angleproject:2361
Change-Id: I1e87ac8d2517c5a3b50e3d0cddd55c852e0e3e7d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1555313
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>

At this point, every clear is done through render pass loadOp, except
masked color or stencil clears.  The only fallback is clearWithDraw,
that can clear both color and stencil at the same time.

Bug: angleproject:2361
Change-Id: I805fc12475e832ad2f573f665cdfeb766e61a6d0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553740
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>

Follow up to c02ef98f.

Bug: angleproject:2546
Change-Id: Ibad7befc5bed95544c0cf15a79d25b47ec8a00bd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1564710Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:3371
Change-Id: I7601e6b658835b9c948acab98491f5bd01ea9497
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1562517Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

3. Remove gpu_info.h and gpu_info.cc and use ANGLE's own gpu_info_util to to
gather device info instead.
- Support collecting info for and parsing expectations of specific Android
devices such as Nexus 5X and Pixel 2.
- Change parser behavior to more closely follow:
bit.ly/chromium-test-list-format

Bug: angleproject:2677
Change-Id: I4c0b9342142b718e884484a6bcaac2dff3ac575a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553822
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:3364
Change-Id: I51dd45cfcd1c548266712b71eac0dca60574e69e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558960
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:1944
Change-Id: I06e613f002d390e85faadc9bec903e83fdd9fdec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1560596Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Few GLES3 expectations were updated in preparation for running those
tests on the bots (one change on Linux, a handful on Android).

A number of EGL tests were discovered to crash on Android.  They are
suppressed as well.  Note that most of these tests were previously
marked as failing or flaky on the GLES backend as well, and they are
marked as SKIP everywhere instead.

Bug: angleproject:2341
Bug: angleproject:2546
Bug: angleproject:2950
Bug: angleproject:3186
Change-Id: If52d5faeea994c8b6200b713b3c2f1b1a1aeff92
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1560251
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

If the vulkan driver has support for VK_KHR_external_memory_fd or
VK_KHR_external_semaphore_fd, add the GL versions of these to the vulkan
renderer's extensions.

Bug: angleproject:3289

Change-Id: I7f04b5cf883f93f6ccd579c2b75d6831b854bfd0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1552027
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d90aae9a5a6c..82ebbbba15c2


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@82ebbbba15c2

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=ynovikov@google.com

Change-Id: I834daaff382898fee3733d3f05054421b4af6deb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1560892Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

This is to remove the workaround introduced by anglebug.com/2599 since
Nexus 5x devices aren't in the farm anymore and the tests pass on Pixel
devices.

Bug: angleproject:2599
Test: angle_deqp_gles2_tests
Test: angle_end2end_tests
Change-Id: I14f724494909486a2164ddd734a95b6980429f29
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1559202
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: chromium:951049

Change-Id: I4e9e2cfe3c287fcb6e536ec20c20acbfda1d8405
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1559203Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>

Two bugs were present in our implementation. We were using the y offset
for z in ensureSubImageInitialized. And for our D3D back-end we were
potentially reading from the wrong image index.

Bug: chromium:947342
Change-Id: If39671a911e08fcc641b9ba6f5910e3a2c16eb5d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558671
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

There is always only one display that can be associated with a context,
so get*Current*Display is confusing.

Bug: None
Change-Id: Iff3a9fc5ad1154b046bb30d7f46a468802ba7fcc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558958Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Previously, the CPU was throttled to be at most N frames ahead, N being
the number of swapchain images.  N is now fixed to 2, regardless of the
number of swapchain images.  If N < 2, we would be stalling the CPU
unnecessarily, and if N > 2, the CPU could get too far ahead.

Effectively, here is how the throttling plays out with this commit:

Submit (Fence 1) + Present
Submit (Fence 2) + Present
Wait Fence 1
Submit (Fence 3) + Present
Wait Fence 2
Submit (Fence 4) + Present
Wait Fence 3
Submit (Fence 5) + Present
Wait Fence 4
...

Bug: angleproject:2942
Change-Id: I3b8c3bb88e52d62231306ec84aad50d2bf472d8c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558681Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

If TextureImpl sets a local dirty bit and signals gl::Texture of it, the
dirtyness is not propogated to context.  This can result in draw calls
with textures that are not synchronized

BUG=949985

Change-Id: I9baf82c96598265a6a4850f1fd48e213b5e98ab5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1556699
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

The test MipmapTest.TextureCubeGeneralLevelZero/ES2_VULKAN was disabled
for Vulkan Android due to Nexus 5x and Pixel 2 issues.   The Nexus 5x
has been removed from the test infrastructure and the Pixel 2 issue
seems to have sorted itself out.

Bug: angleproject:2817
Test: angle_end2end_tests MipmapTest.TextureCubeGeneralLevelZero/ES2_VULKAN
Change-Id: I85bb56707def2906194c34942fcd74a811255abc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558293Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

As glslang is rolling frequently now, internal shaders frequently
require recompilation.  This change parallelizes shader compilation to
speed up this process.

Bug: angleproject:3333
Change-Id: Icace083559bff73dfb9b5fe7cc2c59ce8137a2dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558680
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This documents the discussion and conclusion on preferring to bake
generated code into the repository.

Bug: angleproject:3333
Change-Id: I1afc338c59d5bcb2a64f843081aba5120820e9ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558676Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:3361
Change-Id: I39c595e1b8ab73520422e2dd3433cd007a1415a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1559789Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e8c2d95ed45f..d90aae9a5a6c


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@d90aae9a5a6c

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=ynovikov@google.com

Change-Id: Ie83b6a4df33b1733153216721b5a9e1f4f883047
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558757Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e06c7e9a515b..0527c9db8148


Created with:
  gclient setdep -r ./third_party/glslang/src@0527c9db8148

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=ynovikov@google.com

Change-Id: I76730e84198452d79381d030a757080c03de092a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558755Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Updates the glslang_validator binary for Linux in the same commit.

Bug: angleproject:3333
Change-Id: Ide42781ec4951e7c09307a0a3b96c36c6ea29d23
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553828
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:1944
Change-Id: I9d93ec16044e2a40eeee5073e77696c86338f651
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1558670
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

If a texture or renderbuffer needs to be cleared for robust access or
due to having emulated channels, it is immediately cleared.  The former
relies on a front-end feature that optimizes robust access clears only
to levels and layers that are not fully initialized through data upload.

Bug: angleproject:2722
Change-Id: Icdab856eb4ffe963f78569b6d80d9ff5cb27ff9b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1535056
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

To make it pass the following webgl conformance test
https://github.com/KhronosGroup/WebGL/blob/master/sdk/tests/conformance/rendering/rendering-sampling-feedback-loop.html

It used to fail due to
1. Didn't check if texture unit is sampler complete
2. Only checked active drawbuffers. But drawbuffer settings shouldn't be
taken into account when checking drawing feedback loop.

On top of applying these 2 functional fixes, I also tried to do some
optimization by unwrapping the nested for loop for program sampler
bindings and texture unit in `Program::samplesFromTexture` and putting
them outside of the draw buffer loop according to the old comment by
Antonie @piman.
https://codereview.chromium.org/2461973002/

> ... turning it around (for each texture check if it's
also an attachment, instead of for each attachment check if it's a bound
texture). In particular, we have an upper bound on the number of
attachments, so we can look them up outside the loop into a fixed size
buffer on the stack - and the very common case will be to only have 1 of
them making the inner loop cheap.

But this unwraps sort of breaks the code structure. An alternative way
would be passed in a framebuffer pointer into `Program::samplesFromTexture`
but that would ends up in tight class coupling. I am a bit unsure here.
Would like to hear if think this change is okay in terms of code style.

In addition to further speed up this check (as it runs for every draw
validation) I added a cache mLastColorAttachmentId indicating the last i
of GL_COLORATTACHMENTi that is not GL_NONE to shorten this inner loop.
In most scenario we won't have up to max number of color attachments.

A side note: this is still failing
https://github.com/KhronosGroup/WebGL/blob/master/sdk/tests/conformance2/rendering/depth-stencil-feedback-loop.html
But it's because the test case doesn't fit the spec at this moment.
I will update this test later.

Bug: chromium:660844
Change-Id: I6d718dada71a5d989caac04de03f2454f2377612
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553963Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>

No longer needed with the ANGLE loader.

Bug: None
Change-Id: If206c529efaee5b81b68059341dcc6e841126842
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1556698
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

If clearing only depth or stencil, the other channels contained garbage.

Additionally, this removes the clearing of emulated channels.  Emulated
textures are cleared once, and they don't need to be recleared.

Bug: angleproject:2361
Change-Id: I01aa6be116d44f6c0115a1c25322db2e579a7b23
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553739
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This change allows us to download a copy of the standalone glslang
validator during gclient runhooks. This decouples run_code_generation
from the version of glslang stored in source tree. This prevents the
error where a developer would run into a code generation conflict due
to a change in version of glslang.

Currently only the Windows version is stored in the tree. A follow-up
CL will add Linux. The validator will only initially support Windows
or Linux.

Documentation for the script is located in tools/glslang/README.md.
This CL also updates the Vulkan shader generation script to use the
new binary for Windows.

Bug: angleproject:3333
Change-Id: Ia6146a283a2bcfdf84c42411d6b5d8bae136bf1b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553823
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

This tool can allow you to browser markdown files in the repository
locally. Run tools/md_browser/md_browser.py and navigate to
localhost:8080. It will point you to the root README.md. From there
you can put in relative links to navigate to your new or changed
markdown files.

Bug: angleproject:3333
Change-Id: I5b4d608e2ad7408280868eb6561f95f3e55d8e8f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1556696Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:2361
Change-Id: Icca49086d95ddb0d2d50e5ba71ae9b748eeabf3f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1545203Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Manual roll to unblock the autoroller stuck on presubmit failure.

Bug: None
Change-Id: I97094add66a42154309addea43fe6aa5e1411c43
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1556694Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

The test was previously either masking every three aspect (color, depth
and stencil) or none.  This was not exercising every clear path in the
Vulkan backend.

Bug: angleproject:3241
Change-Id: Ief4085ea302ec17bffe30b1f8510ae357fd01290
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1551523
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Image clear's masked clear path using a draw call was using this feature
to clear the depth buffer, but this feature is not available on ARM and
some Qualcomm devices.

This change adds a push constant to the vertex shader used in this call
to export the depth clear value, removing the need to rely on depth
clamping.

Bug: angleproject:3241
Change-Id: I565cd5f731c441820e0702e51dfdf02d0bc7de06
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1551522
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>

Previously, masked stencil clear was done by clearing every stencil bit
to the ClearValue & Mask.  The correct behavior as implemented in this
change is to clear only the bits that are set in Mask.  This can only be
done through a draw call, with ClearValue as the stencil reference, and
Mask as the stencil write mask.

Note: this change relies on the depthClamp Vulkan feature which is not
available on ARM.

Bug: angleproject:3241
Change-Id: I0a181c32f881ee813f144e7bdd6f42c8ea6f1966
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1548442
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>

Plumb the physical HW's subPixelPrecisionBits limit to be returned in
the query for GL_SUBPIXEL_BITS. Default value remains 4 for all other
backends.

Bug: angleproject:3351
Change-Id: I5564e5090e7211b8daeaa91ea30eceb23c5ea227
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1553967Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>