Commits · 21045f5a7084edf751ee47e6312deff1c83ea8a9 · Chen Yisong / angle

20 Mar, 2015 8 commits

Revert "Fix ResourceManager create-on-bind reallocations." · 21045f5a

authored Mar 20, 2015

Build break on GPU FYI Bots on Linux/Mac:

http://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Mac%20Builder/builds/28092

This reverts commit 61ce1a41.

Change-Id: If2e7fb35c769708a783a32932b777dc97eaba8a4
Reviewed-on: https://chromium-review.googlesource.com/261590Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

21045f5a

Move some validation from IntermBinary::promote to ParseContext · 47fd36a7

authored Mar 19, 2015

This makes the role of promote() in the system clearer and helps to make
the code more understandable, since more of the checks are in the same
logical place.

BUG=angleproject:952
TEST=angle_unittests, WebGL conformance tests

Change-Id: Idb2de927d872e46210d71cf6de06a6f8c1fc5da1
Reviewed-on: https://chromium-review.googlesource.com/260803Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

47fd36a7

Use the GL_COPY_READ_BUFFER binding for copy sources. · 4904a79b

authored Mar 20, 2015

Using the ELEMENT_ARRAY binding can cause issues such as rebinding the
current VAO's index buffer unexpectedly.

BUG=angleproject:881

Change-Id: Ieeed52ac81c23a46bfe9fc4365239c2b177ff6ac
Reviewed-on: https://chromium-review.googlesource.com/261563Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

4904a79b

Fix ResourceManager create-on-bind reallocations. · 61ce1a41

authored Mar 20, 2015

We had a funny bug where the Handle Allocator would re-allocate
reserved handles after the app layer creates one with Bind rather
than using Gen. This affects Textures, Buffers and Renderbuffers.

Fix this by using a different allocation scheme. It should still
be fast on the "good" case (using Gen) and use tree lookups on the
bind case. Also add some unit tests.

BUG=angleproject:942

Change-Id: I2e3f4c31b28cb86bd3699035f5d55568a2a1d7d5
Reviewed-on: https://chromium-review.googlesource.com/258904Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

61ce1a41

Uninitialize the debug annotations when unloading a renderer · 4bcf5b56

authored Mar 19, 2015

Change-Id: I125de997853c9deda365e4827322c29d1f20edf2
Reviewed-on: https://chromium-review.googlesource.com/261253Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

4bcf5b56

Use google test to wrap our perf tests. · be13ffca

authored Mar 19, 2015

This provides easy implementation with the Chromium perf bots.

BUG=angleproject:744

Change-Id: I71c04e3d67cae9344ddca9fd95fd3c9849494922
Reviewed-on: https://chromium-review.googlesource.com/260644Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

be13ffca

Only sync the VAO state just before the draw call. · 6ae6efca

authored Mar 09, 2015

BUG=angleproject:880

Change-Id: Ifd59c0f67aeab0e4700b3dca57c1b75e3fae48b8
Reviewed-on: https://chromium-review.googlesource.com/257671Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

6ae6efca

Fix incorrect assertion. · fb2a5597

authored Mar 20, 2015

BUG=angleproject:884

Change-Id: I3406eec99609b85c407797c50b71611b445a6ca5
Reviewed-on: https://chromium-review.googlesource.com/261462Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

fb2a5597

19 Mar, 2015 11 commits

Update Canary WebGL CTS expectations. · 30ceb3a1

authored Mar 19, 2015

Change-Id: Ia8375595b34e00a48143a568a4a9ab7157a12cd2
Reviewed-on: https://chromium-review.googlesource.com/261171Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

30ceb3a1

Make Optional a proper helper class. · 64af27bd

authored Mar 19, 2015

Move this to a common area, out of perf tests.

Change-Id: I53d36accfe0c53789c007edfb20ba7e964947def
Reviewed-on: https://chromium-review.googlesource.com/260643Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

64af27bd

Remove hardcoded additional include/lib paths from WinRT projects · f55d4d17

authored Mar 19, 2015

Change-Id: Ic78a7dc3a1b3027f4fffc352fa2fb097b6024970
Reviewed-on: https://chromium-review.googlesource.com/261185Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

f55d4d17

Reduce unnecessary built-in varying usage in D3D renderer · 8b695ee3

authored Mar 12, 2015

Change-Id: I0c404e77aa3f56ddc5b97a206b06c7907edfb1eb
Reviewed-on: https://chromium-review.googlesource.com/259812Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

8b695ee3

Fix C4702 issues (unreachable code) in ANGLE, excluding <xtree> · c8ef69d2

authored Mar 18, 2015

Change-Id: Ia7603139af266fd7b14efc8c3465225738456e67
Reviewed-on: https://chromium-review.googlesource.com/261038Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

c8ef69d2

Fix framebuffer zero used after being destroyed in Context destructor. · ed54e5db

authored Mar 17, 2015

BUG=angleproject:950

Change-Id: I06e9e6ccf92ee8ca0b1de98cc48ef68a85107214
Reviewed-on: https://chromium-review.googlesource.com/260573Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Gregoire Payen de La Garanderie <Gregory.Payen@imgtec.com>

ed54e5db

Accept equality and assignment for arrays in parsing · e79904c3

authored Mar 18, 2015

This is enough to support the operations in GLSL output. HLSL output will
likely require additional work to support this.

BUG=angleproject:941

Change-Id: I728d511ab07af94bc3382dc2796c1e9ac79d1442
Reviewed-on: https://chromium-review.googlesource.com/260801Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

e79904c3

Add #version 300 es to ESSL output when needed · 1ade24db

authored Mar 19, 2015

BUG=angleproject:953

Change-Id: Ib9e45fab1d35f8c78abd0ac2209ac4f63afe4465
Reviewed-on: https://chromium-review.googlesource.com/261170Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

1ade24db

Move binary op array check to ParseContext · d6b14287

authored Mar 17, 2015

Also piece together an addAssign function in ParseContext that uses the
binary op array check. This will make it easier to change the
array-related checks in the future to use shaderVersion. Moving
validation out from IntermBinary::promote also makes the architecture
clearer, promote()'s role should be mainly to determine the type of the
return value of the binary operation, not to do validation.

BUG=angleproject:941
TEST=angle_unittests, WebGL conformance tests

Change-Id: If1de33ea250893527be7f0d7930d4678a0864684
Reviewed-on: https://chromium-review.googlesource.com/260571Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

d6b14287

Correctly insert unmangled function names to symbol table · b2983c95

authored Mar 18, 2015

This fixes detecting some cases of function parameter mismatch
(previously a mangled function name corresponding to no function
parameters was added to the symbol table for each user-defined function,
and this was returned when doing function lookups with no parameters).

Also fixes detection of reusing a function name as a variable/struct
name.

New unit tests are added to ensure that these fixes don't regress.

BUG=angleproject:936
TEST=angle_unittests, WebGL conformance tests

Change-Id: I2dadde9dcc01c7a4a653c1982c36377b89e6d437
Reviewed-on: https://chromium-review.googlesource.com/260800Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

b2983c95

Fix uninitialized ConfigSorter read. · 5659619a

authored Mar 19, 2015

We were not initializaing the mWant* members to false.

BUG=468638

Change-Id: I90ef131c930c6f9c31e9bc9cec951c1f91816eb0
Reviewed-on: https://chromium-review.googlesource.com/261047Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

5659619a

18 Mar, 2015 6 commits

Replace stray reference to cpu_arch in BUILD.gn. · a17e77fe

authored Mar 18, 2015

cpu_arch has been replaced by target_cpu and current_cpu in GN.

R=geofflang@chromium.org
BUG=344767

Change-Id: Id1c0e37238db5fac41572244aeac0908ac5a412a
Reviewed-on: https://chromium-review.googlesource.com/260971Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

a17e77fe

Always use static_assert for compile-time assertions and remove META_ASSERT. · d4475816

authored Mar 18, 2015

BUG=468139

Change-Id: I696ef307f2faa54bb72df66784bc79a055499987
Reviewed-on: https://chromium-review.googlesource.com/260776Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

d4475816

Move most of addBinaryMath from Intermediate to ParseContext · fc1806e1

authored Mar 17, 2015

Some type checks for binary math will be different based on the shading
language version, which is easily accessible in ParseContext. Because of
this and also for architectural simplicity it makes more sense to have
the checks in ParseContext.

BUG=angle:941
TEST=angle_unittests, WebGL conformance tests

Change-Id: I92a499f47e1cbc6a7b6391ce0fa04284803e7140
Reviewed-on: https://chromium-review.googlesource.com/260570Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

fc1806e1

Refactor D3D Debug Annotations code. · 2c7c625a

authored Mar 12, 2015

This encapsultates the different implementations and allows us to
compile debug.cpp in the common libraries without link errors.

BUG=angleproject:513

Change-Id: I16dc4c666fb4266ee5146d64d77eb9925c7584a8
Reviewed-on: https://chromium-review.googlesource.com/256450Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

2c7c625a

Fix and enable warning C4245 (signed/unsigned mismatch) · b8af723d

authored Mar 16, 2015

Change-Id: If48043835fcc98341a0626e3ece7d0e3f7958059
Reviewed-on: https://chromium-review.googlesource.com/260630Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cooper Partin <coopp@microsoft.com>
Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

b8af723d

Fix Winrt Project generation · 5899aadb

authored Mar 17, 2015

Change-Id: I5688f17d8fc18f36363afbfd2728b0b3475fb2bd
Reviewed-on: https://chromium-review.googlesource.com/260606Tested-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

5899aadb

17 Mar, 2015 6 commits

Fix unreferenced function warning. · 968992e3

authored Mar 17, 2015

Change-Id: I66b1821e5effcb761a5a0268f7f375289aa3a621
Reviewed-on: https://chromium-review.googlesource.com/260632Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

968992e3

Make Platform methods global. · 6bd58312

authored Mar 13, 2015

This will allow them to be imported dynamically without name
mangling. This is necessary because sometimes SwiftShader
overrides libGLESv2 and libEGL, so we need to determine at
run-time if we are running with "actual" ANGLE.

BUG=466735

Change-Id: I396d717b79066feb8ed0d577ee7386b33eb1d160
Reviewed-on: https://chromium-review.googlesource.com/259954Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

6bd58312

Remove the non-templated RefCountObjectBindingPointer class. · 1f40291c

authored Mar 09, 2015

This allows the regular BindingPointer class to template on const types.

Also added assignment and copy operators that don't leak the resources.

BUG=angleproject:880

Change-Id: If3efa26a7fa89306d783c3e8a5fb92b16861d77a
Reviewed-on: https://chromium-review.googlesource.com/257670Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

1f40291c

Fix code duplication in OutputHLSL · 6341939f

authored Mar 13, 2015

While debugging, I came across the piece of code in
OutputHLSL::OutputHLSL which is unnecessarily duplicated,
this change just fixes it.

Change-Id: I0549d58696417ccf651bacfa19f489b290d4ba6e
Reviewed-on: https://chromium-review.googlesource.com/259960Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

6341939f

Update ANGLE_platform_angle_d3d to be able to disable automatic trim. · 0110e172

authored Mar 11, 2015

BUG=angleproject:946

Change-Id: I5652495842b057998318b1583f8e1a586eba39aa
Reviewed-on: https://chromium-review.googlesource.com/258940Tested-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

0110e172

TextureGL implementation. · c05f7065

authored Mar 10, 2015

BUG=angleproject:884

Change-Id: I877c0a9f753dacff96bbb82486bee71d1996ecb7
Reviewed-on: https://chromium-review.googlesource.com/252982Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

c05f7065

16 Mar, 2015 9 commits

Move the ANGLE tests project to src/ · 559a2e8c

authored Mar 16, 2015

*re-re-land with fix for Chrome's angle tests*

BUG=angleproject:945

Change-Id: I3c64e2edc776c299791440f65f22450855eb6dfa
Reviewed-on: https://chromium-review.googlesource.com/260448Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

559a2e8c

Revert "Move the ANGLE tests project to src/" · 96e3f556

authored Mar 16, 2015

Still causing build issues on Chrome.

This reverts commit 64a3b2a9.

Change-Id: I8d40fe3dfd0a877343357153a02b8ef66d571c64
Reviewed-on: https://chromium-review.googlesource.com/260425Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

96e3f556

Move the ANGLE tests project to src/ · 64a3b2a9

authored Mar 16, 2015

*re-land with fix for Chromium build*

BUG=angleproject:945

Change-Id: I82bff1760e681987fb26e479734aa62fb845898a
Reviewed-on: https://chromium-review.googlesource.com/260362Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

64a3b2a9

Revert "Move the ANGLE tests project to src/" · 5491fe66

authored Mar 16, 2015

Causing build break in Chromium.

This reverts commit 71c2d85c.

Change-Id: Iedf001c1f4c60a759f69009610fbce978d193d17
Reviewed-on: https://chromium-review.googlesource.com/260370Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

5491fe66

Move the ANGLE tests project to src/ · 71c2d85c

authored Mar 16, 2015

BUG=angleproject:945

Change-Id: I2eb44ac43f65b916ddd838d39e6aae62580d7fa0
Reviewed-on: https://chromium-review.googlesource.com/258903Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

71c2d85c

Use rx::ImplFactory in Framebuffer init. · 48115b6f

authored Mar 16, 2015

BUG=angleproject:942

Change-Id: Idf14a4e42148b379b64b129ab649a9222cf1fb52
Reviewed-on: https://chromium-review.googlesource.com/258902Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

48115b6f

Use rx::ImplFactory in ResourceManager. · ae6495e5

authored Mar 16, 2015

This will make mocking easier for unit testing ResourceManager.

BUG=angleproject:942

Change-Id: I24b9d0be550991845225141d6e7d5630383a8718
Reviewed-on: https://chromium-review.googlesource.com/258901Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

ae6495e5

Implement pass-through pack state params. · 87de3627

authored Mar 16, 2015

Same as for unpack, this allows us to pass through the state reset
code of dEQP without UNIMPLEMENTED errors, while still throwing
asserts if they are set to non-default values.

BUG=angleproject:901,angleproject:512

Change-Id: I0ce0258b0e91eb83c066c241693aaa5c164b2989
Reviewed-on: https://chromium-review.googlesource.com/257131Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

87de3627

Add pass-through for new unpack store params. · 67102f01

authored Mar 16, 2015

Move the UNIMPLEMENTED checks to where they are used with non-default
values. This allows dEQP to pass the prerequisite tests like state
reset without throwing assertion failures in debug.

BUG=angleproject:901,angleproject:512

Change-Id: I3bd35f6dea61e7d80d1379ba4e8e13437e68431a
Reviewed-on: https://chromium-review.googlesource.com/257130Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

67102f01