This optimizes memory and CPU use of symbol table initialization.
This was measured to make a debug build of angle_unittests run around
10% faster on Windows.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: Icd5272c6cfc0d5122550c403621bfa5944c92a83
Reviewed-on: https://chromium-review.googlesource.com/859958Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

The array stride is implementation-dependent if the storage layout is
not standard layout. So this change will use std140 as the layout to
fix the bug.

BUG=767240,angleproject:2255

Change-Id: I21de52ebad6d27783eeade63d6fac81c0842085d
Reviewed-on: https://chromium-review.googlesource.com/861313
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This enables using constexpr types for built-in variables and some of
the variables created in AST transformations.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: Ie85b3c9872a071a7c023ced013b14ad91cff7cee
Reviewed-on: https://chromium-review.googlesource.com/868134
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Array constructors that are used as a statement by themselves need to
be pruned from the AST before writing HLSL output.

This fixes an assert in OutputHLSL.

BUG=angleproject:2307
TEST=angle_unittests

Change-Id: Ib49461a4be173f3856f5a264ac0af8d818a61798
Reviewed-on: https://chromium-review.googlesource.com/874691
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

Function prototype nodes and symbol nodes already refer to symbols
that have type information, so the type doesn't need to be copied to
the TInterm* AST node classes. Now type is only stored in those AST
node classes that represent other types of expressions. They use
a new TIntermExpression base class for this.

Since now we may use the TType from builtin symbols directly instead
of copying it, building the mangled names of types in the correct
memory pool is also required. The code now realizes the types of
built-in variables when they get added to the symbol table.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: Ic8d7fc912937cb8abb1e306e58c63bb9c146aae9
Reviewed-on: https://chromium-review.googlesource.com/857005Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

The previous patch edited the generated file manually. Fix the script
to generate the file so that angle_white_box_tests pass.

BUG=angleproject:2300
TEST=angle_white_box_tests

Change-Id: Ie8f182b515721a56d6a2da2dac316aa4e296f005
Reviewed-on: https://chromium-review.googlesource.com/870113Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

Add cases that bindImageTexture binds a single layer of a
two-dimensional array, three-dimensional, or cube map texture.

BUG=angleproject:1987
TEST=angle_end2end_tests.ComputeShaderTest.*

Change-Id: I75883ef05c509100e5164a5add69167a41203101
Reviewed-on: https://chromium-review.googlesource.com/856320
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

 * Create a new libGLESv1_CM target.
 * Merge all autogenerated extension entry points into one file.
 * Allow creation of ES1 contexts.

BUG=angleproject:2306

Change-Id: I446258363a96a3c37d657089dd7c1cff0fa3cf78
Reviewed-on: https://chromium-review.googlesource.com/865718
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Gcc complains about an unused variable.
Adjust a #include to work with the gyp build.

BUG=none

Change-Id: Ia94abf70f3a9bb7952eb53d1f0a3cfcca5df0836
Reviewed-on: https://chromium-review.googlesource.com/867655Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

BUG=angleproject:2188

Change-Id: I2b2aced542032c7c263f911ef1516af1d42190cc
Reviewed-on: https://chromium-review.googlesource.com/846346
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

When a EGL pbuffer is created based on a D3D SRGB texture using
EGL_ANGLE_d3d_texture_client_buffer, SRGB conversions are performed as
if it was an SRGB surface. The value of EGL_GL_COLORSPACE now
reflects that correctly. If the pbuffer is bound to a texture and used
as a framebuffer attachment, querying GL_FRAMEBUFFER_COLOR_ATTACHMENT
also reflects that correctly.

The behavior is the same on both the D3D backend, where there is no
native interop involved, and on the GL backend using
WGL_NV_DX_interop(2).

There are a few limitations on the GL backend that relies on native
interop:

1. SRGB conversion for textures created this way can't be disabled
using the GL_FRAMEBUFFER_SRGB_EXT toggle that's exposed in ANGLE
through EXT_sRGB_write_control. This is now documented in the
EGL_ANGLE_d3d_texture_client_buffer spec. On the D3D backend this is
not a problem since EXT_sRGB_write_control is not supported either
way.

2. Creating a pbuffer out of a D3D11 texture with the format
DXGI_FORMAT_B8G8R8A8_UNORM_SRGB does not work, even though it was
listed as one of the supported formats in the
EGL_ANGLE_d3d_texture_client_buffer spec. It's now mentioned that
support for this format is optional.

BUG=angleproject:2300
TEST=angle_white_box_tests

Change-Id: I70ee0646680805e4469291a5b2ce59e92fda009e
Reviewed-on: https://chromium-review.googlesource.com/866743Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: I25bd8baded9c13e75555578e4b61b99a56e0c702
Reviewed-on: https://chromium-review.googlesource.com/850974Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

Add #!/usr/bin/python2 and the executable permission bit to all scripts
where missing.

BUG=angleproject:2209

Change-Id: Ib33017c17e579c371b89bbfbdb7136b870027dc5
Reviewed-on: https://chromium-review.googlesource.com/862987Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

Note: by the time the old code used to call `getBaseLevelInternalFormat`, the base level image has already been updated with `redefine()` call above, thus the check `internalformat != storageFormat` wasn't correct.

Change-Id: I3da6df54490d6e72e5094388ed7e39a4c7d920d2
Reviewed-on: https://chromium-review.googlesource.com/862256Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Indicate scripts/bootstrap.py should be run by python2.

TBR=jmadill@chromium.org
BUG=angleproject:2209

Change-Id: I2ccfee1407cd4ce457aa28a374ac202b8281d40b
Reviewed-on: https://chromium-review.googlesource.com/862618Reviewed-by: Frank Henigman <fjhenigman@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

This makes sure that the Device to DeviceImpl ratio is always 1:1 and
avoids any potential double-deletion or unexpected deletion of
DeviceImpl objects.

BUG=742034

Change-Id: I778068ccd09b7478d3683123456062b94be242a1
Reviewed-on: https://chromium-review.googlesource.com/854627
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

A virtual function to get the constant value of an AST node is added
to TIntermTyped. This way a constant value can be retrieved
conveniently from multiple different types of nodes. TIntermSymbol
nodes pointing to a const variable can return the value associated
with the variable, constructor nodes can build a constant value from
their arguments, and indexing nodes can index into a constant array.

This enables constant folding operations on constant arrays, while
making sure that large amounts of data are not duplicated in the
output shader. When folding an operation makes sense, the values of
the arguments can be retrieved by using the new
TIntermTyped::getConstantValue(). When folding an operation would
result in duplicating data, the AST can just be left to be written out
as is.

For example, if the code contains a constant array of arrays, indexing
into individual elements of the inner arrays can be folded, but
indexing the top level array is left in place and not replaced with
duplicated array literals.

Constant folding is supported for indexing and comparisons of arrays.

In case constant arrays are only referenced through foldable
operations, the variable declarations will be pruned from the AST by
the RemoveUnreferencedVariables step.

BUG=angleproject:2298
TEST=angle_unittests

Change-Id: I5b3be237b7e9fdba56aa9bf0a41b691f4d8f01eb
Reviewed-on: https://chromium-review.googlesource.com/850973Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

Only exact version of Windows SDK works.
Clarify how to do a release build.

BUG=angleproject:2297

Change-Id: I2566b7e807a84c4edc3b457299036e67a64b5a36
Reviewed-on: https://chromium-review.googlesource.com/852553
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Add an initialize function to match other impl objects and simplify the
creation of DeviceImpls.

BUG=742034

Change-Id: I569c8252d5d23c8af98835f6c08e7a3b640fc3f3
Reviewed-on: https://chromium-review.googlesource.com/854626Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

It can be inferred from the presence of an owning display.

BUG=742034

Change-Id: I6a33378f4256733da6d9658d47763153e431ad70
Reviewed-on: https://chromium-review.googlesource.com/854625Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:1920
TEST=angle_end2end_tests

Change-Id: I90bcd3bf5a078623b3a739615fbc7b157b6fb94c
Reviewed-on: https://chromium-review.googlesource.com/808144Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

The PipelineDesc class is a 512-byte packed description of the entire
Vulkan pipeline state. It uses the alignas keyword and some static
asserts to verify that the structures are packed. This ensures that
when ANGLE uses MurmurHash to hash the entire struct, and memcmp to
check for identity, that there are no garbage padding bits.

This CL does not implement the Pipeline cache, but it will help, since
now we have a packed type that can be used as the key to a hash map.

Bug: angleproject:2163
Change-Id: I16efa927f08d30d89a9c4c8943edd211c6878ac8
Reviewed-on: https://chromium-review.googlesource.com/829893
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Frank Henigman <fjhenigman@chromium.org>

Adreno's driver in Android Oreo follows the spec to the letter,
and applies "#pragma STDGL invariant(all)" only to the outputs of
a fragment shader, causing InvariantAllBoth test to fail.

Since the wording of the spec doesn't match the intended usage of this
pragma, ANGLE should flatten it to workaround spec conformant drivers.

BUG=angleproject:1293

Change-Id: I9f8ad44adc3b958204b88805dba8c5b7964b3d9f
Reviewed-on: https://chromium-review.googlesource.com/860920Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

This will be useful for the Vulkan pipeline state cache. This cache
wants to pack the pipeline description very carefully into a specific
number of bits, using the "alignas" keyword. Using this keyword
requires an aligned allocator, which we can lift from Chromium's
base/memory submodule.

Also includes a unittest copied from Chrome.

Bug: angleproject:2163
Change-Id: I25976be4610636db3f43552bba23d823f5a49a24
Reviewed-on: https://chromium-review.googlesource.com/837944Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Frank Henigman <fjhenigman@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:1595

Change-Id: I031beab818daca8a20726d7bff564649feefc1f3
Reviewed-on: https://chromium-review.googlesource.com/844214
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Treat aggregate constructors as having no side effects, which enables
pruning declarators that have a constructor initializer.

Some logic in RemoveUnreferencedVariables is fixed to make this work
correctly for structs. The bugs were previously not exposed since
constructors were treated as having side effects, but now that those
can be pruned the logic needs to be correct.

BUG=angleproject:2298
TEST=angle_unittests

Change-Id: I6fbe61a9e82065196baa29c200bf556fc21d8962
Reviewed-on: https://chromium-review.googlesource.com/856499Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

BUG=angleproject:2290
TEST=dEQP-GLES31.functional.texture.multisample.samples_*.sample_position
TEST=TextureMultisampleTestES31.CheckSamplePositions*

Change-Id: If8b74c16d5c104215456e35b8922279be972cee3
Reviewed-on: https://chromium-review.googlesource.com/844062
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Instead of referring to the gl_in symbol in the symbol table, create
a gl_in symbol with the right array size once the array size is known.
This makes the type of TIntermSymbol nodes pointing to gl_in
consistent with the variable type.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: I31673d33526a91f8d069ee8d7d2f181a49665fd0
Reviewed-on: https://chromium-review.googlesource.com/857004Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

NVIDIA OpenGL drivers at least up to version 388.59 don't clamp
gl_FragDepth when it is written to a floating point depth buffer.
This bug is now worked around by clamping gl_FragDepth in the shader
if it is statically used.

BUG=angleproject:2299
TEST=angle_end2end_tests on NVIDIA

Change-Id: I61589b2b0dd2813c4901a157c8d37e470063773c
Reviewed-on: https://chromium-review.googlesource.com/840842
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

Create new TVariables to change struct declaration qualifiers in
PruneNoOps so that the node doesn't end up with an inconsistent
qualifier from the variable.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: I7f6cd557eb3e46f4ead4ffbe37d8960ff7776d10
Reviewed-on: https://chromium-review.googlesource.com/850673Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

Was flaky.

BUG=angleproject:2301

Change-Id: Id71cf6c43e133810c64535bbde494d12546b0adc
Reviewed-on: https://chromium-review.googlesource.com/854978Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

The SPIRV-Tools 'external revision generate' script is coded such that
it assumes a .git folder is present. This causes a problem for the
tarball build. We can fix this by using the same tooling we use for
ANGLE's commit id script to check if the .git directory is present
before running the generator. If it is missing, we insert a hard-coded
dummy header. Also use the 'DEPS' file as a placeholder for .git/HEAD
to check if the current revision needs updating.

Bug: chromium:799620
Bug: angleproject:2237
Change-Id: Icea8e9c66f1600df7dca2aaa45fe449f687f5b55
Reviewed-on: https://chromium-review.googlesource.com/854255Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This is now updated in Chrome, so we can remove the last uses.

Bug: angleproject:2159
Change-Id: Ia31e42b8a685756ee70450be19a52248e3efa92f
Reviewed-on: https://chromium-review.googlesource.com/853119Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Added missing quotes.

BUG=angleproject:2297

Change-Id: Ieb6ca4ae37786f48ad3c6f5dccefef25afce23a2
Reviewed-on: https://chromium-review.googlesource.com/852636Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

This was causing a heavy performance regression in the Vulkan perf
test. Local testing shows it recovers most of the performance gap
with this fix.

Bug: angleproject:2264
Bug: chromium:799372
Change-Id: Ia2bbf526b305e1b2e901d904574dbe5618e6e5ef
Reviewed-on: https://chromium-review.googlesource.com/852365Reviewed-by: Frank Henigman <fjhenigman@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

The clamping doesn't happen on NVIDIA so this is a test that will
confirm a follow-up compiler workaround patch works properly.

BUG=angleproject:2299

Change-Id: I006b522d014e29d2a5e634dfb9cf827ee3bc0536
Reviewed-on: https://chromium-review.googlesource.com/852252
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>

for compute shaders on D3D

BUG=angleproject:1987
TEST=angle_end2end_tests.ComputeShaderTest.*

Change-Id: I075296ac3b6796a334929699c16f2399d7915e51
Reviewed-on: https://chromium-review.googlesource.com/844063
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

In case folding a ternary op or a comma op would change the qualifier
of the expression, the folding is deferred to a separate traversal
step.

After this there are no more cases where the type of a TIntermSymbol
node needs to differ from the type of the variable it is referring to.
There are still some cases where some parts of TIntermSymbol type are
changed while keeping the TVariable type the same though, like when
assigning array size to gl_PerVertex nodes or sanitizing qualifiers of
struct declarations.

BUG=angleproject:2267
TEST=angle_unittests, angle_end2end_tests

Change-Id: I1501c8d361f5f765f43ca810d1b7248d9e2c5986
Reviewed-on: https://chromium-review.googlesource.com/850672
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

This patch labels geometry_shading.vertex_transform_feedback.* as
"SKIP" instead of "FAIL" to fix some failures in dEQP tests.

OpenGL ES 3.1 extension GL_EXT_geometry_shader requires additional
validations on transform feedback, which hasn't been implemented
in ANGLE, so geometry_shading.vertex_transform_feedback.* fail just
after beginTransformfeedback(). As endTransformfeedback() isn't
called in dEQP function resetStateES():
1. An error occurs in this function when trying to clear transform
   feedback.
2. Some of the tests afterwards also fail because it isn't allowed
   to change active program by useProgram() when transform feedback
   is on.

So it is better to skip these tests before ANGLE supports these new
features.

BUG=angleproject:1941

Change-Id: I8834f71e6a655f18118ee4ecf26f4118da6de2f1
Reviewed-on: https://chromium-review.googlesource.com/843955
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

This makes the device type selection part of the ANGLE platform
extension. We currently support NULL driver selection on all
available back-ends (although on the NULL back-end, it already
has no device type). Optionally we could expose certain features
of this as separate extensions.

This currently also supports the old hidden enum, until we can
update Chrome and consolidate to the new exposed official enum.

Bug: angleproject:2159

Change-Id: I85d0811098e644e8192c207673af9e18ed7c1da2
Reviewed-on: https://chromium-review.googlesource.com/846021
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>