Commits · 3810bee333f4e7bd8980cbe5a180a3f4e383bde9 · Chen Yisong / angle

28 Jan, 2014 1 commit

Add the missing GL_DEPTH enum to the fbo attachment query. · 3810bee3

authored Jan 21, 2014

This enum is only availabe in GLES 3. We were failing a dEQP state
query test (fbo.draw_framebuffer_default_framebuffer)

Change-Id: I4cfb07b8597899561b8cc7956a9eb4cd4b0a99a8
Reviewed-on: https://chromium-review.googlesource.com/181782Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

3810bee3

23 Jan, 2014 6 commits

Remove system.h. · 83217796

authored Jan 16, 2014

The gyp files already define NOMINMAX and WIN32_LEAN_AND_MEAN.  windows.h
is also included via the D3D includes.

This ends up speeding up the build process significantly by not having
windows.h included in nearly every file.

Also fixes issues on non-windows systems by not having stdarg.h included
in debug.cpp.

Change-Id: Id32d9aac37a5a29df832a062dd8024302a798a1c
Reviewed-on: https://chromium-review.googlesource.com/183251Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

83217796

Fix FramebufferRenderbuffer validation. · ab9d82cd

authored Jan 21, 2014

We were not checking for an invalid renderbuffer when attaching
to a framebuffer.

Change-Id: Ie29dca1833cc8c2b974f746d51dbee848f52a741
Reviewed-on: https://chromium-review.googlesource.com/181558Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

ab9d82cd

Fix gl::ValidTextureTarget to work on all enum values. · d7460c7e

authored Jan 21, 2014

Change-Id: I347583ae1adcaaae9feeb1276f6150ceb8739885
Reviewed-on: https://chromium-review.googlesource.com/181557Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

d7460c7e

Refactor validation of FramebufferRenderbuffer. · 1fc7e2c5

authored Jan 21, 2014

Consolidate a lot of duplicated code into helper methods. Also
move GetTargetTexture to the context class.

Change-Id: I8e3990a5e3c1976cb533941d0a0946466accec30
Reviewed-on: https://chromium-review.googlesource.com/181556Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

1fc7e2c5

Remove __stdcall from non-windows builds. · 92bfd5c6

authored Jan 16, 2014

Change-Id: I424cb538808ec64137c85af3bbe8742043e1c573
Reviewed-on: https://chromium-review.googlesource.com/183260Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

92bfd5c6

Rework tracing and perf defines. · f5713124

authored Oct 07, 2013

Changed ANGLE_DISABLE_* to ANGLE_ENABLE_* for perf and tracing defines so
they are disabled by default. Updated the gyp files to only turn on perf
by default for windows debug builds.

Change-Id: I71706674e6d12fbf4208acc8f100d963b82c7674
Reviewed-on: https://chromium-review.googlesource.com/183250Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

f5713124

21 Jan, 2014 5 commits

Clamp stencil reference value to D3D11 8-bit limitations. · ec91cd32

authored Jan 21, 2014

D3D11 can only mask 8 bits of a stencil reference value, so the
upper bits are ignored. GL, however, expects the reference value
to be able to scale to 32-bits.

We will expect to fail certain edge cases where the reference value,
and mask, both use particular 9+ bit values.

Change-Id: I8c7451270d9e40310f4154955d38e51bbf7de4df
Reviewed-on: https://chromium-review.googlesource.com/181555Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

ec91cd32

Only use 4-channel shaders for unpack buffers. · 24112d68

authored Jan 21, 2014

D3D11 supports sampling other channel sizes of backing object
and declaring them as 4-vectors in HLSL. This allows us to
simplify the logic for fast unpack shaders significantly.

Source:
http://msdn.microsoft.com/en-us/library/windows/desktop/bb509700(v=vs.85).aspx
(Default Values for Missing Components in a Texture)

Change-Id: I7f645372f266f57bd94cdb1c795f1d30bf2a60a4
Reviewed-on: https://chromium-review.googlesource.com/181901Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

24112d68

Fix zero-size textures and unpack buffers. · c30003d6

authored Jan 10, 2014

We would sometimes attempt to use a NULL staging texture when
initializing a zero size texture when using unpack buffers.

Change-Id: I2e03141c19d9c47eeffb0d56c03bcfe476a9e48d
Reviewed-on: https://chromium-review.googlesource.com/181781Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

c30003d6

Fix build on Visual Studio 2013. · 4b8c3eba

authored Jan 14, 2014

A breaking change in VS2013 necessitates we include <algorithm>
to use std::min/max.

BUG=angle:547

Change-Id: Ia1b21e61d22148ab6d268b34dbfe9a707ca3e59d
Reviewed-on: https://chromium-review.googlesource.com/182512Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

4b8c3eba

Properly clamp stencil mask query values to max int. · b155bbcb

authored Jan 13, 2014

We could overflow when casting from max unsigned int to integer, and
return a negative mask.

See dEQP functional.state_query.stencil_value_mask_getfloat

Change-Id: I59189a40b662ad9d8ded79cdfeded923b98f0b85
Reviewed-on: https://chromium-review.googlesource.com/181780Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

b155bbcb

15 Jan, 2014 6 commits

Added a utility application to generate c headers from dds textures. · a50232fd

authored Jan 10, 2014

Change-Id: Idb4c2ca318c84433f2b06bd4f0c66045f43e56de
Reviewed-on: https://chromium-review.googlesource.com/182191Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

a50232fd

Add swizzle tests. · 2c254d8f

authored Jan 15, 2014

Change-Id: If04bc249b9da8306896c89c28bb057c2cf4da511
Reviewed-on: https://chromium-review.googlesource.com/181771Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

2c254d8f

Replaced Stanford model images. · d701ea12

authored Jan 10, 2014

Change-Id: I76d568ce7b1acb84aba99adf8e6ca921e0933ac4
Reviewed-on: https://chromium-review.googlesource.com/182190Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

d701ea12

Add more D3D11 buffer usages. · 9c53f1e9

authored Jan 08, 2014

Works around performance regressions when index and vertex buffer bind flags are used on the same buffer.

Change-Id: I28bc0d3147c6bd70cec507f20e41d97ec4cc45a5
Reviewed-on: https://chromium-review.googlesource.com/181911Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

9c53f1e9

Don't include windows.h on non-windows systems. · 28576da5

authored Jan 13, 2014

Change-Id: I8cf650073ead5b52bac44e31c8c3c894bc31e01c
Reviewed-on: https://chromium-review.googlesource.com/182320Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

28576da5

Clean up state query methods. · 55856b16

authored Jan 02, 2014

Consolidate a lot of the code duplication in GetIntegerv, GetFloatv,
GetBooleanv and GetInteger64v.

BUG=angle:540

Change-Id: I7b4a5803ea76e5eeb0ebf25c5caadec4c647b485
Reviewed-on: https://chromium-review.googlesource.com/180971
Commit-Queue: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

55856b16

10 Jan, 2014 3 commits

Fix remaining discrepencies between master and es3proto project files. · 3cd50f7e

authored Jan 10, 2014

Change-Id: I335c9346ac268beab25184e2b18ccfdd0b15c7b1
Reviewed-on: https://chromium-review.googlesource.com/182150Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

3cd50f7e

Renderer11 tracks applied textures as SRVs. · 91382e55

authored Jan 07, 2014

Since swizzled textures have multiple SRVs and the same serial,
it was possible that the bound SRV would not be updated if the
texture became swizzled while already bound.

Change-Id: Id06e82f4002aa7f7661c7a69243692aa65a83b48
Reviewed-on: https://chromium-review.googlesource.com/181772Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

91382e55

Fix using wrong value for array size in 2D array storage. · b8f8b89b

authored Jan 07, 2014

We were incorrectly calling Texture::getBaseLevelDepth() which was
correctly reporting the number of 3D slices of the texture (1).

Also rename Texture2DArray::getDepth to getLayers for clarity.

Change-Id: I1968cbcb0a3528bb76ec3e4ea4148e5dc0f302c7
Reviewed-on: https://chromium-review.googlesource.com/181553Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

b8f8b89b

09 Jan, 2014 1 commit

Added missing depth swizzle backing formats and fixed compressed texture bit calculation. · 67938efc

authored Jan 07, 2014

Change-Id: I2390ace1fe5297f9fcad0c873c55dae564a09c43
Reviewed-on: https://chromium-review.googlesource.com/181773Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

67938efc

08 Jan, 2014 1 commit

Remove unnecessary int cast in ParseContext. · eaa84061

authored Dec 08, 2013

BUG=angle:536

Change-Id: I72287f5ce9736cd48fc241022e09446db717cf92
Reviewed-on: https://chromium-review.googlesource.com/181770Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

eaa84061

07 Jan, 2014 1 commit

Fix improper deferencing of a zero-size vector. · d2a88381

authored Jan 06, 2014

When doing a masked clear with only a depth-stencil buffer, we would
look for the zero-th element of an empty vector.

Change-Id: I17d61cf582c6e91fd46f8a8e13e35c6d32dfa109
Reviewed-on: https://chromium-review.googlesource.com/181554Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

d2a88381

06 Jan, 2014 5 commits

Create HLSL texture offset functions. · b1f45b70

authored Dec 19, 2013

BUG=angle:541

Change-Id: I63dd47c40d693724aa6bed93e9967e3b1f8535bd
Reviewed-on: https://chromium-review.googlesource.com/181521Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

b1f45b70

Add NetBSD and DragonFly to posix-compliant OS list · f831e3dd

authored Jan 06, 2014

BUG=angle:428

Change-Id: I282a6bf138b4e2a2c17baf428cbe1e636f43bdd6
Reviewed-on: https://chromium-review.googlesource.com/181640Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/181670
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

f831e3dd

Add textureOffset intrinsics to the symbol table. · 1fbc2873

authored Jan 03, 2014

BUG=angle:541

Change-Id: Ied96edd073017a507369319a781b8ed23f60790b
Reviewed-on: https://chromium-review.googlesource.com/181520Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

1fbc2873

Fix default vertex attribute component size to 4. · b6780326

authored Jan 03, 2014

The GL spec states that by default a vertex attribute has a size of 4.

Change-Id: Ic4c977fb936cc0b232ed4742eeb061d6ba6843be
Reviewed-on: https://chromium-review.googlesource.com/181480Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Commit-Queue: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

b6780326

Fix compressed formats breaking swizzle bits checks. · 80b5a55e

authored Jan 03, 2014

We defautled to zero max bit depth, which breaks the swizzle format lookup.

Change-Id: I4d1cd8bcfb79db3460950fa22630c259f90fa432
Reviewed-on: https://chromium-review.googlesource.com/181481Reviewed-by: Jamie Madill <jmadill@google.com>
Commit-Queue: Jamie Madill <jmadill@google.com>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

80b5a55e

03 Jan, 2014 4 commits

Fix compiler crash. · 44cc79f6

authored Jan 03, 2014

Create a fake variable for function identifiers used as a variable identifier to allow continuing compilation after reporting the error.

BUG=chromium:330222

Change-Id: I96c330694e3503fe2df66621375d2bf76115e325
Reviewed-on: https://chromium-review.googlesource.com/181491Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

44cc79f6

Regenerate the parser using Bison 2.7.12. · f9ea3e17

authored Jan 03, 2014

The next patch requires a parser grammar change, but Cygwin's Bison version got updated so this separates the changes caused by that update from the ones for the actual bug fix.

Change-Id: I6a596e02198725c7dbc6a1a356fdbe388ee512d7
Reviewed-on: https://chromium-review.googlesource.com/181490Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

f9ea3e17

Update guards in ShaderVariable.h. · ee42308e

authored Jan 02, 2014

We neglected to update the text of the guards when we renamed the
file from Uniform.h to ShaderVariable.h.

BUG=angle:533

Change-Id: I59969113536b69a418cf233ef0d7dd797e666ea9
Reviewed-on: https://chromium-review.googlesource.com/180978Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

ee42308e

Fix allowing ES3 enum queries to call through to ES2 contexts. · 79f2f45c

authored Dec 19, 2013

In some cases we would not validate the enums against the context version,
allowing the app to call through to unimplemented features.

BUG=angle:540

Change-Id: Ic89422a3a48882314c054f133961af0b4d8d739a
Reviewed-on: https://chromium-review.googlesource.com/180970Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

79f2f45c

02 Jan, 2014 1 commit

Add in fixes for dEQP state reset. · 2e503557

authored Dec 19, 2013

dEQP relies on a couple specific enums to reset state (see the
prerequisites test) which we don't currently implement. Prior
changes require us to implement a few query parameter to allow
dEQP to work.

BUG=angle:540

Change-Id: Ibd7caa08ffb821ea2de120717beedb2f82428da2
Reviewed-on: https://chromium-review.googlesource.com/180981Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Nicolas Capens <nicolascapens@chromium.org>

2e503557

18 Dec, 2013 2 commits

Fix sorting uninitialized attribute semantics to the end. · 03181abc

authored Dec 18, 2013

A missing condition would produce a sort order where sometimes -1 was shifted
to the front of the semantic array, instead of the end.

BUG=angle:527

Change-Id: I69b2e5ccc03f6523771601cd59293d6cd325be2f
Reviewed-on: https://chromium-review.googlesource.com/180651Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

03181abc

Implement max elements indices and vertices. · 13a2f85b

authored Dec 11, 2013

ES3 has integer queries for the maximum recommended number
of vertices and indices per draw call. These are roughly
correlated to D3D's resource limits -- however, while ES3
has recommended limits D3D has hard limits.

Change-Id: Ib653bc27e61607c78d0c5e70b0d97fea7af6464f
Reviewed-on: https://chromium-review.googlesource.com/179670Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Nicolas Capens <nicolascapens@chromium.org>

13a2f85b

17 Dec, 2013 1 commit

Trigger lost device on an error in D3D9 Present. · cd65ae16

authored Dec 17, 2013

This fixes device remove handling on AMD systems, as well as notifying
the app layer there may have been an internal problem during Present.

BUG=313210
Change-Id: I843ffb3946dd9ef34fbd24b3a46a7b97e3c0fd16
Reviewed-on: https://chromium-review.googlesource.com/179140Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/180450Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

cd65ae16

11 Dec, 2013 3 commits

Added a read pixels test. · f11dbdb3

authored Oct 23, 2013

Change-Id: Ia4c5a0290e62e2c312d86fa18ef4e76d782a4a41
Reviewed-on: https://chromium-review.googlesource.com/179357Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

f11dbdb3

Added compressed texture tests. · 066230a8

authored Oct 30, 2013

Change-Id: Id6090b134b957ca195afa615d61a10f8b008208e
Reviewed-on: https://chromium-review.googlesource.com/179358Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

066230a8

Added tests for maximum texture size. · 2e475a5a

authored Oct 23, 2013

Change-Id: I3bce6ce2a04a3347933bfe515bcaa9b5eaebf255
Reviewed-on: https://chromium-review.googlesource.com/179356Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

2e475a5a