In deleteTransformFeedback, we were using a const iterator, in a
non-const method. Fix the comparison by using auto, which delegates
more work to the compiler's static type checking.

BUG=angle:773

Change-Id: Ibc362fe49629331811a5302df1b68269dfa128a6
Reviewed-on: https://chromium-review.googlesource.com/238444Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

These changes we'll have to upstream at a later time.

BUG=angle:773

Change-Id: I18feb84ae58cb16e3e555c9ab65b6925ba35048e
Reviewed-on: https://chromium-review.googlesource.com/238443Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

std::tuple currently isn't available on Chromium/OSX.

BUG=angle:773

Change-Id: I9f9efc88dcfe904e98a76df8b04086b88f724424
Reviewed-on: https://chromium-review.googlesource.com/238442Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

This fixes the compile on OSX.

BUG=angle:773

Change-Id: I68111e178986bb78b73006a1559ba26120275599
Reviewed-on: https://chromium-review.googlesource.com/238441Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

We were using the c++11 iterator return value from std::map::erase.
Instead use the post-increment operator to keep a valid iterator
after the call to erase, even on older stl.

BUG=angle:773

Change-Id: Ieaa21a2b5a3fcd5ca229a31d40bdf9b8f3283a3c
Reviewed-on: https://chromium-review.googlesource.com/238440Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

We need the functionality of this extension to support dEQP. Likely
we only needed the minor version enum to not generate an error, but
we can take the time to implement the few cases for the other enums
as well.

We don't support any debug context functionality currently, but we
may want to support it in the future.

BUG=angle:501

Change-Id: Ib74cd2e4581e054f8153bb358824d9296b9f8a1c
Reviewed-on: https://chromium-review.googlesource.com/238083Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

We were not advertising the extension, though we require it for
ANGLE_platform_angle. This was blocking dEQP functionality.

Change-Id: I8781867e772b4b1af62f1387faa863f8ce21de76
Reviewed-on: https://chromium-review.googlesource.com/238082Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

It is quite valid for the app to pass in NULL for the attribs list.
In this case we currently crash. We could trigger this error using
dEQP.

Change-Id: I64aba1077f9095bd099c6b60f789ec076cb3d385
Reviewed-on: https://chromium-review.googlesource.com/238081Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

*_TYPELESS formats weren't supported in D3D10Level9 until
Windows 8. Some Win8 D3D9 drivers don't support them either.
To workaround this, we avoid _TYPELESS formats on D3D11 FL9_3.

BUG=angle:856
BUG=435726

Change-Id: I280dc7f87e3a2c737c14284ebb744188e7f10616
Reviewed-on: https://chromium-review.googlesource.com/237292Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Austin Kinross <aukinros@microsoft.com>
Tested-by: Jamie Madill <jmadill@chromium.org>

Like D3D9, D3D11 Feature Level 9_3 doesn't support large or negative
viewports. We have to emulate these in the vertex shader.

BUG=angle:858

Change-Id: I2bd53e3921dc3590cc7193164d73596deafca9ea
Reviewed-on: https://chromium-review.googlesource.com/236040Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

D3D11 Feature Level 9_3 supports instancing, but slot 0 in the input
layout must not be instanced. D3D9 has a similar restriction, where
stream 0 must not be instanced. This restriction can be worked around
by remapping any non-instanced slot to slot 0. This works because
HLSL uses shader semantics to match the vertex inputs to the elements
in the input layout, rather than the slots.

BUG=angle:858

Change-Id: I67b2be9095afc206a4b9f107ed61356820551afe
Reviewed-on: https://chromium-review.googlesource.com/237270Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

ANGLE's testing code recently got enabled in Chromium's builds. While it
builds fine with cl.exe, it isn't quite standards-conformant and doesn't
build with clang. Fix this.

There were three issues:

1. ANGLE_TYPED_TEST_CASE() is a variadic macro that tries to use
   __VA_ARGS__ as argument to a variadic template and then pass
   that template to another macro. However, [cpp.replace] describes
   that ANGLE_TYPED_TEST_CASE(Test, int, float) should be expanded
   to TYPED_TEST_CASE(Test, ::testing::Types<int, float>) which
   should be interpreted as a "call" of TYPED_TEST_CASE with the
   3 macro arguments `Test`, `::testing::Types<int`, and `float>`.
   As a fix, use a typedef for the variadic template and refer to
   it through the typedef in the macro call.

2. `#version` was used on its own line in a substitution of the
   SHADER_SOURCE macro. [cpp]p1 says that every line starting with
   a `#` is a preprocessing directive, and [cpp.replace]p11 says
   "If there are sequences of preprocessing tokens within the list
   of arguments that would otherwise act as preprocessing directives,
   the behavior is undefined" (with a footnote that this includes
   non-directives -- # followed by unknown text). As a fix, merge the
   `#version` line with the previous line. Now the line doesn't start
   with `#` and things are fine.

3. Unqualified lookup usually doesn't look into dependent bases. If
   this is desired, one usually has to make the call qualified, a
   good explanation for this is at
   http://eli.thegreenplace.net/2012/02/06/dependent-name-lookup-for-c-templates
   cl.exe doesn't implement this rule, and clang tries to emulate
   cl.exe's behavior to a certain extend when in Microsoft mode.
   However, that seems to not work for member templates with explicit
   types (filed http://llvm.org/PR22066 for this, but since it's not
   needed to parse Microsoft headers and not standards-conformant,
   I'm not sure if we'll fix that). As a fix, don't provide an explicit
   type, the inferred type is the same. This is also consistent with
   all the other tests in this file. (We might clean up -Wmicrosoft
   warnings in the future; if so I'll add the explicit this->s that
   are missing in this file when we do.)

BUG=chromium:445406

Change-Id: I77a2f3ab9601a1f0f39b56ed3d05217f123155b8
Reviewed-on: https://chromium-review.googlesource.com/238090Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

BUG=angle:658

Change-Id: If865910d52154f574f4d488d4c45fcac9a87b050
Reviewed-on: https://chromium-review.googlesource.com/234761Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Change-Id: I14d0b8ebd631e5c9c3c3b63c047c9ef7c11bf310
Reviewed-on: https://chromium-review.googlesource.com/236304Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Change-Id: Id8d884df31726546e871d75a719bc419dd767d6b
Reviewed-on: https://chromium-review.googlesource.com/236303Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

This crash happened with certain bad shaders which used temporary
values as array (or other) index expresisons.

Fixes the crash covered in the WebGL test
"conformance/bugs/undefined-index-should-not-crash"

BUG=angle:857

Change-Id: I13e2ba6d5f1ab0846ac902021bc0b57cbb37d759
Reviewed-on: https://chromium-review.googlesource.com/237460Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

We don't always have an InfoLog available for dynamic shaders, but we
can still capture data in some cases for default shaders.

Change-Id: Iccd022f24d5c2b8922e9254580705675cd4e405f
Reviewed-on: https://chromium-review.googlesource.com/237328Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

BUG=angle:854

Change-Id: If116de132dc83d93255749b54c1919a75abcb65c
Reviewed-on: https://chromium-review.googlesource.com/236330Tested-by: Gregoire Payen de La Garanderie <Gregory.Payen@imgtec.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Change-Id: I69795b97ef032838cd43e889119405aaee66fa4f
Reviewed-on: https://chromium-review.googlesource.com/237329Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

These tests were failing on SwapChain11 with errors relating to
the Depth Stencil backbuffer.

BUG=angle:856
BUG=435726

Change-Id: Idd371a380e9b302d7d5e40437e9d76589872b750
Reviewed-on: https://chromium-review.googlesource.com/237450Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

BUG=angle:462

Change-Id: I2c1c18027dee1c3b4efb87374caaadbf58367841
Reviewed-on: https://chromium-review.googlesource.com/236930Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

Change-Id: Id0d3ad6ec7764ed84ec504ad92eca81dff29aac8
Reviewed-on: https://chromium-review.googlesource.com/236043Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Austin Kinross <aukinros@microsoft.com>

Calling GSSetConstantBuffers with real data causes a device removed
error on 9_3. We therefore ensure that ANGLE doesn't call it on 9_3.

Change-Id: I151a74ee7ea81fc4b795d8bf10d5e5c42bfe7c86
Reviewed-on: https://chromium-review.googlesource.com/236042Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

angle_unittests subsumes the previous:
  angle_compiler_tests
  angle_preprocessor_tests
and will subsume angle_implementation_unit_tests in a follow-on CL.

angle_end2end_tests subsumes the previous:
  angle_tests
  angle_standalone_tests
  angle_implementation_unit_tests

The bulk of these two targets have been factored into their own
.gypi files, so that a different main.cpp can be trivially
plugged in for the gtest harness. This refactoring has been
tested both in ANGLE standalone builds, and builds within
Chromium.

BUG=chromium:435726

Change-Id: I231a3c1989c17e188cc469dcf80fe78b052afe78
Reviewed-on: https://chromium-review.googlesource.com/236681Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Kenneth Russell <kbr@chromium.org>

BUG=angle:841

Change-Id: I482e53a90606d9d6b105c7006234215d51ab1a6b
Reviewed-on: https://chromium-review.googlesource.com/232692Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

BUG=angle:841

Change-Id: I71deac9e755b5dfa010596cd1f8a213c24d895bf
Reviewed-on: https://chromium-review.googlesource.com/232691Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

BUG=angle:841

Change-Id: I95c9cbdc2d1c99731e19c48e18117358d22b9e94
Reviewed-on: https://chromium-review.googlesource.com/232690Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Feature Level 9_3 doesn't support as many formats for Input Layouts
as 10_0+. On 9_3, we have to make sure that GL vertex attributes are
converted into formats that 9_3 supports.

Change-Id: I27b9a85a6eb21a37bd36e60bf011b83fce743fd0
Reviewed-on: https://chromium-review.googlesource.com/234523Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Tested with angle_*_tests and WebGL CTS in Chrome Canary on Windows. Passed with no regressions.

Change-Id: Ied0a32ea75565ef19b8e87bed8bdd555b74edee3
Reviewed-on: https://chromium-review.googlesource.com/234110Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Dongseong Hwang <dongseong.hwang@intel.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

If there are multiple users of translator.dll then one could ShFinalize
and destroy the memory of all the others.  libANGLE needs it's own copies
of the global pool allocator to make sure this doesn't happen.

There should be no functional changes for non-component builds.

BUG=angle:823

Change-Id: Id6f7d50e86d8950834399b16a7ab14e6e3198d12
Reviewed-on: https://chromium-review.googlesource.com/234594Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

D3D11 FL9_3, like Shader Model 2.0 in D3D9, doesn't support reading from SV_Position in the pixel shader. We have to reconstruct gl_FragCoord using dx_ViewCoords instead.

Change-Id: I7e898038d210d73a9d224dcc18b033e5cd4a56f5
Reviewed-on: https://chromium-review.googlesource.com/234277Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

 * Allows for multiple contexts have to have different client versions, caps
   and extensions without causing shader compilation failures.

BUG=angle:823

Change-Id: I523679e90be031b0b7fa385d46d6839b1cf3029f
Reviewed-on: https://chromium-review.googlesource.com/227710Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Change-Id: Ib334d2506031466a73f1a233ee68c1658841a882
Reviewed-on: https://chromium-review.googlesource.com/234720Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

Change-Id: Ib9d2d155a6e062488ff5bb5ce578036b6187ca70
Reviewed-on: https://chromium-review.googlesource.com/234276Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Change-Id: I8d9054b5582cfe78beaff07146adc73b4716eaf9
Reviewed-on: https://chromium-review.googlesource.com/233680Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

We were using the entire level parameter of the cube map, instead
of using the helper functions for cube map ImageIndexes, which
set the layer corresponding to the cube map face.

BUG=angle:849
BUG=440701

Change-Id: Id78db5c8281b6b644392bb961d69a7f869755a34
Reviewed-on: https://chromium-review.googlesource.com/234380Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

On Feature Level 9_3, GetDesc() returns "Software Adapter" in the hardware
description string, instead of a description of the actual GPU. As a
result, glGetString(GL_RENDERER) on 9_3 wouldn't return any useful info
about the current hardware.

Change-Id: Ie4d329a08a03ee044fc0b594308aaf0bf235c74e
Reviewed-on: https://chromium-review.googlesource.com/233663Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Austin Kinross <aukinros@microsoft.com>

Change-Id: I660c74791ddb9917bd4796bb652eefab2a3e4863
Reviewed-on: https://chromium-review.googlesource.com/233660Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Austin Kinross <aukinros@microsoft.com>

BUG=angle:841

Change-Id: I04b4ffd086424569a15aa21447dd552e0a898928
Reviewed-on: https://chromium-review.googlesource.com/232394Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

BUG=angle:841

Change-Id: Ie819c253a900d105d768aee168a6a2de89754ccc
Reviewed-on: https://chromium-review.googlesource.com/232393Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>