Bug: angleproject:5759
Change-Id: Ieeb5a251e614a4df1b5362dee474b368f362e0fc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826121
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:5853
Change-Id: Id63922d881ce7778236e4ab3417bf9414fc0e59b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824431
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This reverts commit 8105d9ea.

Reason for revert: Fails compilation

Original change's description:
> Roll vulkan-deps from c18d8cd5016c to a441440ae454 (23 revisions)
>
> https://chromium.googlesource.com/vulkan-deps.git/+log/c18d8cd5016c..a441440ae454
>
> Changed dependencies:
> * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/1481399549..e6a0e7fc76
> * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/212895d4c2..a02a9205ff
> * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/e1d8c4931d..f5ac258209
> * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f563b367c7..13c4877ea2
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
> Please CC syoussefi@google.com on the revert to ensure that a human
> is aware of the problem.
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
>
> Bug: None
> Tbr: syoussefi@google.com
> Change-Id: Id3c917a802469caf50238bc268a328b2455ffa24
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826008
> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Bug: angleproject:5864
Change-Id: I093218ed8324562830f83a26378d164a86d00ae0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826472
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

https://chromium.googlesource.com/vulkan-deps.git/+log/c18d8cd5016c..a441440ae454

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/1481399549..e6a0e7fc76
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/212895d4c2..a02a9205ff
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/e1d8c4931d..f5ac258209
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f563b367c7..13c4877ea2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Id3c917a802469caf50238bc268a328b2455ffa24
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826008
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://swiftshader.googlesource.com/SwiftShader.git/+log/77edad299907..f32791f5d53b

2021-04-14 swiftshader.regress@gmail.com Regres: Update test lists @ b71a5569
2021-04-13 srisser@google.com Implement depthBoundsTest
2021-04-13 capn@google.com Eliminate the OpenGL ES 1.1 implementation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ifdd5c4c0f35d46d16090f27638002338b7f8f1a7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2825849
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/chromium/src.git/+log/cb430282a083..21426fd08f99

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/dde8d8929d..b30d9d1676
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/edbd63483e..5185dac7e9
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b226a4b7af
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d73d069a76..f9d141ab4d
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/633b99a892..59d5575e12
* tools/luci-go: git_revision:99ac75773c6241b6ddf82ade4c54553faa084530..git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6
* tools/luci-go: git_revision:99ac75773c6241b6ddf82ade4c54553faa084530..git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6
* tools/luci-go: git_revision:99ac75773c6241b6ddf82ade4c54553faa084530..git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bfc3b95479..fc7a3623d6
* tools/skia_goldctl/linux: mAuXqU7IqMTl2o166z_OMy_IZxh0ajpEUPuXYy4_BfcC..R23Oztsyro8ca7QGaNGKjN7duf5fsN6I6Dq2Nwyh2YQC
* tools/skia_goldctl/mac: TH-LRMBSdzpB3b-wmecnLTut5qaef26EM-ZbtQM2CIUC..Ipkmq4bl5d7VmPVlEonzZMPLnHxMr-LaDFi8Dz_r8-8C
* tools/skia_goldctl/win: Lzfohgeqx2FAmTxtM5eYQshIXb5YBoNk73cmoh_dP3sC..QCamcihHhiASX-AasohPdhiBOtj0ikJ3fUByIMEfrEIC
No update to Clang.

Bug: None
Tbr: syoussefi@google.com
Change-Id: I25b1ee88a463e431fbdbf5d0856d9f87d7257d0c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824767
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

This CL contains two changes. One to how we print out GLboolean
values, and another to how we capture GLbooleans.

According to the spec, anything non-zero can be considered
GL_TRUE when setting state:

    When the type of internal state is boolean, zero integer or
    floating-point values are converted to FALSE and non-zero values
    are converted to TRUE.

Dota Underlords is using 0xFF for GL_TRUE.

Before the change, this manifested as:

    // logcat
    glColorMask(context = 4, red   = kUnknownGLenumString,
                             green = kUnknownGLenumString,
                             blue  = kUnknownGLenumString,
                             alpha = GL_FALSE)

    // trace
    glColorMask(GL_INVALID_ENUM, GL_INVALID_ENUM, GL_INVALID_ENUM, GL_FALSE);

After:

    // logcat
    glColorMask(context = 4, red   = 0x00FF,
                             green = 0x00FF,
                             blue  = 0x00FF,
                             alpha = GL_FALSE)

    // trace
    glColorMask(0xFF, 0xFF, 0xFF, GL_FALSE);

Test: MEC for Dota Underlords
Bug: b/185192780
Bug: angleproject:5857
Change-Id: Ie53aeba8d8a40f91ee375467b325d8e6be053a98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821947
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Test: MEC for Dota Underlords
Bug: b/185192780
Bug: angleproject:5857
Change-Id: I59ced20117bde50b5b734a82cb2e5966d1b27227
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821946
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

Add the entrypoint, and when a buffer is immutable, recreate it
with glBufferStorageEXT.

Test: MEC for Dota Underlords
Bug: b/185192780
Bug: angleproject:5857
Change-Id: I29b934bdff4185d19594e49e9387dd79c6031aa5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821945Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

The current setup has problems producing tags in an ANGLE checkout.

Bug: angleproject:5114
Change-Id: I91864650ddb2a9df0ac533bf4c43259c476a99ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822238Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

The ContextVk::handleDirtyEventLogImpl() and ContextVk::endEventLog()
methods called the {begin|end}DebugUtilsLabelEXT() methods when the
VK_EXT_debug_utils extension is not enabled.  This manifests when
enabling/using VVL stand-alone (i.e. when the the debug-utils
extension is not also present).

Bug: b/183133198
Change-Id: I043b174d457a8796831184c092661f24b33c1db4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821943
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

'checkout_angle_restricted_traces' controls if we should check out
the trace tests. We can give restricted access to partners for these
traces. Defaults to the same setting as 'checkout_angle_internal'.

Bug: angleproject:5860
Change-Id: I36efffb180b35e11e104e2c99bc89fb4be4e0708
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822232Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/chromium/src.git/+log/ab36e1e42f00..cb430282a083

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/79006bea8b..dde8d8929d
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/e5f83f632d..edbd63483e
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2b4b340c6e
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/057831ef1f..d73d069a76
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7168936235..633b99a892
No update to Clang.

Bug: None
Tbr: syoussefi@google.com,jmadill@google.com
Change-Id: I8be169064f0704707d5ae8226f7ffbfce6e9dfd1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824358
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

These are now configured through mb_config.pyl. We still pass in the
properties to the lucicfg helper function set up the waterfall UI.

Bug: angleproject:5114
Change-Id: Ib46ab95f5803a166fd2342679afbfcaa6f467c45
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822233Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Because values might be the result of calculations that require some
accuracy, writing the float values with the default formatting may
not be sufficient to replay correctly, therefore format the values
so that they carry more digits.

In addition, enable the test that are now passing.

Bug: angleproject:5846
Bug: angleproject:5847
Change-Id: I305552a1ffa3cded6326df59883912e14c95f5f5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822257
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

On Linux with the amdgpu driver, the GL_RENDERER string contains
precise kernel and DRM version info. We should sanitize this info
before using these strings for user privacy.

Bug: chromium:1181193
Change-Id: I047d1abf5b51412b4258a021761cc450385ef0fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2727658
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Also removes the new linux-ozone-angle-try bot,
since we are no longer interested to test on this configuration.

Bug: angleproject:4483, chromium:1187259
Change-Id: Iaf50ba99905498cee5dbcac27e1cd7c936c8a975
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822234Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Bug: angleproject:5759
Change-Id: I79644e7bda3ad0a15eb041b2805b8765c0d22029
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822258Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: John Plate <jplate@google.com>

Add logic to check the program or the pipeline before erroring out when
validating glBeginTransformFeedeback.

Bug: angleproject:5557
Test: ProgramPipelineXFBTest31.VaryingIOBlockSeparableProgramWithXFB*
Change-Id: I0df8a8d87b3632745bc91dc2673f2fac31c6cdb1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743440Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

This will be used to set up gn args for standalone builds.
We can then set the GN args source-side instead of in the
recipe directly.

Bug: angleproject:5114
Change-Id: I6fac6d13903951031a7299aea203f6b3e13c72bc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819461Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

In preparation for more source-side configuration. Also adds a presubmit
check and some empty files to enable the presubmit to function.

Bug: angleproject:5114
Change-Id: Id9a0cbe1e78949720be39c65efab73c1345d4f39
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819942Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

The code that separated out declaration of nameless structs from uniform
variable declarations is generalized to separate out declaration of all
structs from uniform variable declarations.

As a result, a pass that outputs the struct types at the top of the
shader is no longer necessary.  The struct declarations are kept in the
AST to be output to GLSL as they normally would when not used in
conjunction with uniform variables.

After this change, the Vulkan and Metal translators no longer intermix
transformations and code generation; transformations are done first
entirely in AST, and code generation is done at the end.

Bug: angleproject:2461
Bug: angleproject:4889
Change-Id: Ieb4d3f7091845e50c3dc399603ab01182692521d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818153
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

Share the default VAO state between all frontend VAO when
there is no native VAO support. Forcefully sync state every
time a new frontend VAO is bound.

Bug: angleproject:5577, chromium:1167179
Change-Id: Ieaedb5108ad28fc78e7e58b74495639c5246bb05
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2665266Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Chrome started requiring this dep to 'gn gen' on Android so
ANGLE needs it too.

Bug: angleproject:5839
Change-Id: Ia8df8520975ed426667f2c59f0fd7761652b92ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818141
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

This reverts commit a51b57fa.

Original change's description:
> Revert "Vulkan: Add features to modify sampling parameters"
>
> Bug: b/167404532
> Change-Id: Iae19dfe165074e8c01216312bddd744c4fb504a4
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2510012
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Tim Van Patten <timvp@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: b/167404532
Change-Id: I2c756b8eb0f61701ef6e33275e557bc199a4d3b4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815259Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Fields of nameless interface blocks are stored as TVariables and
referenced through a TIntermSymbols (unlike named blocks which use
EOpIndexDirectInterfaceBlock with a constant field indices).  With this
change, the field index is stored in the variable's type which let's the
TField of the TInterfaceBlock be directly accessible (and not need a
search by name).

This will be helpful in translation to SPIR-V as interface block members
are accessed by field index.

Bug: angleproject:4889
Change-Id: If3ab45b1e5f5f9576721dc52e2bdf1161882514f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818242
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

... instead of generating text.  This will keep the tree in a consistent
state, as previously the references to uniform values where to
TVariable's whose declarations were removed.

Bug: angleproject:2461
Bug: angleproject:4889
Change-Id: I2ef3787dede371514a5f495f4cc8fc67ea45f451
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815564
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

It doesn't make much sense to keep the actual values and it makes
the diff needlessly large when the binaries differ.

Bug: angleproject:5856
Change-Id: I55664d6cb60ef680669c1243c2eabcb67cd4db23
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822256
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This can be used to make the Json comaprison less noisy.

Bug: angleproject:5856
Change-Id: I57df41eed3926647aaf8bcf97a7aea050e1c3d51
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822255
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Some transformations change variable declarations.  This validation
ensures that all references to said variables are appropriately replaced
as well.

Bug: angleproject:2733
Change-Id: I6c2873968eeed4cba66e70069f84eb69a1f77074
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818140
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

The correct define is ANGLE_HAS_RAPIDJSON

Bug: angleproject:5858
Change-Id: I21e3f3e632d5ceb4fce43f1d6be34e4fbbdafbc6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822254
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

When run with the --verbose flag, and a test fails because the context
comparison fails, then print the unified diff between the JSON
serialization of context that was captured and the context when it
was replayed.

Bug: angleproject:5715
Change-Id: I86210d96e5bbdf63f1ed663ddf8dfcb33764cbea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821535
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:5493
Change-Id: I894e08a86157032d1e68a3d2b460bfdbbaeb6680
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821415
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:5758
Change-Id: I6440dacf0db57a56923d2cab5a7c791981ba3b9d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822248
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

With this data available as JSON text files further analysis
can be executed to drill down to what the actual difference is.

Bug: angleproject:5715
Change-Id: I7012668ff9617f6232a6bbe1798a02d8c795321d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821534
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/chromium/src.git/+log/497fa2f8d899..ab36e1e42f00

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/563f147c85..79006bea8b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/85de9f3f89..e5f83f632d
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..db7e7f8a5d
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1cabb17575..057831ef1f
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/006bc90fc4..7168936235
* tools/luci-go: git_revision:f784260b204b2d93c7bd6d1a619f09c6822e5926..git_revision:99ac75773c6241b6ddf82ade4c54553faa084530
* tools/luci-go: git_revision:f784260b204b2d93c7bd6d1a619f09c6822e5926..git_revision:99ac75773c6241b6ddf82ade4c54553faa084530
* tools/luci-go: git_revision:f784260b204b2d93c7bd6d1a619f09c6822e5926..git_revision:99ac75773c6241b6ddf82ade4c54553faa084530
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a2223becbd..bfc3b95479
* tools/skia_goldctl/linux: hppkAohY9Cc45kW6zZWYXtdLKzo9CQ9XvcqLNIBaqQQC..mAuXqU7IqMTl2o166z_OMy_IZxh0ajpEUPuXYy4_BfcC
* tools/skia_goldctl/mac: JnqYnN3TwP__L0jvUBgcLpPQsBgz9ZcBk8-bsbiez6QC..TH-LRMBSdzpB3b-wmecnLTut5qaef26EM-ZbtQM2CIUC
* tools/skia_goldctl/win: 0el4SjlMxSJWhUyzmXXYXqGT59IZHXzEaDTufNH8bOwC..Lzfohgeqx2FAmTxtM5eYQshIXb5YBoNk73cmoh_dP3sC
No update to Clang.

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ia8f524d620a3b474cf74487a693455abdfd4491b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2823568
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

EGL_EXT_buffer_age was previously disabled for SwiftShader Vulkan
because of an Android test timing out on Cuttlefish when the buffer
age is queried. aosp/1672445 addresses the root cause of the timeout,
so EGL_EXT_buffer_age can be supported again.

Bug: b/182521420
Bug: angleproject:3529
Change-Id: I5949f721316855d9138eb9f657a6df4e7b49ed71
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821750Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@google.com>

The perf warning was previously only issued when a GPU buffer had to be
converted.  This change adds a warning when client data needs to change
format too.

Bug: b/184355822
Change-Id: I3539e22f277593d60e5e1ce172baf7b8db0477fa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821751
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

This is a reland of 8b9889bf

The previous CL relied on a define which now only exists in
a specific gn configuration. This reland removes D3D11 as a
multithread-supported platform in the test configuration.

Original change's description:
> Fix multithreaded crash on draw commands on D3D11 backend.
>
> A crash can occur if thread A is executing eglDestroyContext while
> thread B issues a draw call, if the threads are interleaved in such a
> manner that a makeCurrent occurs without triggering a change to the
> global context and a dirtyAllState call. We handle that case by
> explicitly making current the proper contexts in the eglDestroyContext
> call.
>
> A test has been added that triggers a crash without this fix when
> running on the D3D11 backend. In addition, all of MultithreadingTest
> is enabled for the D3D11 backend.
>
> Test: Ran MultithreadingTest. Test exhibits a crash before this
> change, and does not after this change. Also ran:
>     dEQP-EGL.functional.sharing.gles2.multithread.*
>     dEQP-EGL.functional.multithread.*
>
> Bug: b/183756357
> Change-Id: Ic6f76a062868b2f3b4e60d29dc087ec180bfb7cd
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2798591
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Doug Horn <doughorn@google.com>

Bug: b/183756357
Change-Id: I5be9a011ea99a69730eddc9e4da23bcf92ed3bf2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815243Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Doug Horn <doughorn@google.com>

Internal format doesn't play any role in this case, and causes confusion
due to mixing sized and unsized formats resulting in more complicated
code in Chromium.

Bug: angleproject:5538, chromium:1116101
Change-Id: Ie200026f014850053108aa0416e1da15bcda7b84
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808855
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>