Commits · a2ade89488203c137c4b09c75a508d166b907ce9 · Chen Yisong / angle

15 Apr, 2021 5 commits

Clear macros 'NEAR' and 'FAR' · a2ade894

authored Apr 13, 2021

Bug: angleproject:5861
Change-Id: Id4cccf5e06dd39c37bd4fa23965edd31633b0fef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824429Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: John Plate <jplate@google.com>

a2ade894

Tests: Add Idle Heroes trace. · ea6dd8b3

authored Apr 14, 2021

Test: angle_perftests --gtest_filter="*idle_heroes*"
Bug: b/180419827
Bug: angleproject:5865
Change-Id: Ia121c9c76b67c130534a06e5dc09ac8bd7d2efe9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826125Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

ea6dd8b3

Capture/Replay: Enable InstancingTest.LineLoop/* tests · 6f3bd395

authored Apr 13, 2021

Bug: angleproject:5853
Change-Id: Ia1a7a1cec781dca22ab49a9189dd3560ac148216
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824435
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

6f3bd395

Roll Chromium from 21426fd08f99 to cac0b331e3fc (436 revisions) · 5186af3b

authored Apr 15, 2021

https://chromium.googlesource.com/chromium/src.git/+log/21426fd08f99..cac0b331e3fc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/b30d9d1676..e966858a7e
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/5185dac7e9..4ef8239f68
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/5447d00cc9..10b50b69d8
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0fb9b3ace8
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f9d141ab4d..b1cc5ed9e8
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/59d5575e12..eefe475693
* tools/luci-go: git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6..git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0
* tools/luci-go: git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6..git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0
* tools/luci-go: git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6..git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/fc7a3623d6..fae4e7d723
No update to Clang.

Bug: None
Tbr: syoussefi@google.com
Change-Id: I8ef062cf57e98b30672d8ad397b56b303595e6ee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2827775
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5186af3b

JsonSerializer: Add tests for sorting and non-unique keys · 6362dcf1

authored Apr 14, 2021

Bug: angleproject:5853
Change-Id: I85e64900a58a2706087b71769470bb33fb4e8522
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824434
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

6362dcf1

14 Apr, 2021 17 commits

Capture: store some array values as vector · 212849e9

authored Apr 13, 2021

This reduces the number of values that are added with
the same key.

Bug: angleproject:5853
Change-Id: Ie13408cc7ad419dec06746dc38b753f76292fae6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824433
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

212849e9

JsonSerializer: Sort group members before writing them out · 3116c91c

authored Apr 13, 2021

Use a multimap to accumulate the values added to a group and
then add them to the Json group when it is finished.

Bug: angleproject:5853
Change-Id: Idbe82acc5f9a9671063f02bd1af039575aa52e87
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824432
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

3116c91c

Allow Chromecast tests to run on SwANGLE · 45344f05

authored Apr 14, 2021

This cl makes 2 changes allowing Chromecast tests to use
SwANGLE:
1) It sets angle_use_vulkan_display to true when using
   Chromecast, effectively allowing SwANGLE to be used
2) It sets angle_vulkan_display_mode to "headless", allowing
   it to use DisplayVkHeadless instead of DisplayVkSimple,
   which ends up using "VK_EXT_headless_surface" instead of
   "VK_KHR_display", so that it's supported by SwiftShader
   Vulkan on Chromecast.

Bug: chromium:1060139
Change-Id: Ia521ebddac14f5e34666bb9b64603bec598c41ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826196Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>

45344f05

Upgrade overlay fonts generator to Python 3 · 90d18b03

authored Mar 10, 2021

Bug: angleproject:5707
Change-Id: I809669d7a7de16ed2e098f59067c8e1d9c44a75c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773292Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>

90d18b03

infra: Remove osx_sdk cache. · 12342643

authored Apr 14, 2021

This is no longer necessary now that we use mac_toolchain.py.

Bug: angleproject:5114
Change-Id: I0afac641d55e9be2bd04103301aec3080d3332c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2823859Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

12342643

Workaround for missing include in OpenCL headers · 9e1ccb24

authored Apr 14, 2021

Bug: angleproject:5759
Change-Id: Ieeb5a251e614a4df1b5362dee474b368f362e0fc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826121
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

9e1ccb24

Capture: Fix storing strings instead of scalars · 9254eb8e

authored Apr 13, 2021

Bug: angleproject:5853
Change-Id: Id63922d881ce7778236e4ab3417bf9414fc0e59b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824431
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

9254eb8e

Revert "Roll vulkan-deps from c18d8cd5016c to a441440ae454 (23 revisions)" · c9b33729

authored Apr 14, 2021

This reverts commit 8105d9ea.

Reason for revert: Fails compilation

Original change's description:
> Roll vulkan-deps from c18d8cd5016c to a441440ae454 (23 revisions)
>
> https://chromium.googlesource.com/vulkan-deps.git/+log/c18d8cd5016c..a441440ae454
>
> Changed dependencies:
> * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/1481399549..e6a0e7fc76
> * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/212895d4c2..a02a9205ff
> * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/e1d8c4931d..f5ac258209
> * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f563b367c7..13c4877ea2
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
> Please CC syoussefi@google.com on the revert to ensure that a human
> is aware of the problem.
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
>
> Bug: None
> Tbr: syoussefi@google.com
> Change-Id: Id3c917a802469caf50238bc268a328b2455ffa24
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826008
> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Bug: angleproject:5864
Change-Id: I093218ed8324562830f83a26378d164a86d00ae0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826472
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

c9b33729

Roll vulkan-deps from c18d8cd5016c to a441440ae454 (23 revisions) · 8105d9ea

authored Apr 14, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/c18d8cd5016c..a441440ae454

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/1481399549..e6a0e7fc76
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/212895d4c2..a02a9205ff
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/e1d8c4931d..f5ac258209
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f563b367c7..13c4877ea2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Id3c917a802469caf50238bc268a328b2455ffa24
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826008
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

8105d9ea

Roll SwiftShader from 77edad299907 to f32791f5d53b (3 revisions) · 9cbb7106

authored Apr 14, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/77edad299907..f32791f5d53b

2021-04-14 swiftshader.regress@gmail.com Regres: Update test lists @ b71a5569
2021-04-13 srisser@google.com Implement depthBoundsTest
2021-04-13 capn@google.com Eliminate the OpenGL ES 1.1 implementation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ifdd5c4c0f35d46d16090f27638002338b7f8f1a7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2825849
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

9cbb7106

Roll Chromium from cb430282a083 to 21426fd08f99 (209 revisions) · 4393c0f8

authored Apr 14, 2021

https://chromium.googlesource.com/chromium/src.git/+log/cb430282a083..21426fd08f99

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/dde8d8929d..b30d9d1676
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/edbd63483e..5185dac7e9
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b226a4b7af
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d73d069a76..f9d141ab4d
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/633b99a892..59d5575e12
* tools/luci-go: git_revision:99ac75773c6241b6ddf82ade4c54553faa084530..git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6
* tools/luci-go: git_revision:99ac75773c6241b6ddf82ade4c54553faa084530..git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6
* tools/luci-go: git_revision:99ac75773c6241b6ddf82ade4c54553faa084530..git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bfc3b95479..fc7a3623d6
* tools/skia_goldctl/linux: mAuXqU7IqMTl2o166z_OMy_IZxh0ajpEUPuXYy4_BfcC..R23Oztsyro8ca7QGaNGKjN7duf5fsN6I6Dq2Nwyh2YQC
* tools/skia_goldctl/mac: TH-LRMBSdzpB3b-wmecnLTut5qaef26EM-ZbtQM2CIUC..Ipkmq4bl5d7VmPVlEonzZMPLnHxMr-LaDFi8Dz_r8-8C
* tools/skia_goldctl/win: Lzfohgeqx2FAmTxtM5eYQshIXb5YBoNk73cmoh_dP3sC..QCamcihHhiASX-AasohPdhiBOtj0ikJ3fUByIMEfrEIC
No update to Clang.

Bug: None
Tbr: syoussefi@google.com
Change-Id: I25b1ee88a463e431fbdbf5d0856d9f87d7257d0c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824767
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4393c0f8

Capture/Replay: Support non-binary GLboolean · fdfb2b82

authored Apr 09, 2021

This CL contains two changes. One to how we print out GLboolean
values, and another to how we capture GLbooleans.

According to the spec, anything non-zero can be considered
GL_TRUE when setting state:

    When the type of internal state is boolean, zero integer or
    floating-point values are converted to FALSE and non-zero values
    are converted to TRUE.

Dota Underlords is using 0xFF for GL_TRUE.

Before the change, this manifested as:

    // logcat
    glColorMask(context = 4, red   = kUnknownGLenumString,
                             green = kUnknownGLenumString,
                             blue  = kUnknownGLenumString,
                             alpha = GL_FALSE)

    // trace
    glColorMask(GL_INVALID_ENUM, GL_INVALID_ENUM, GL_INVALID_ENUM, GL_FALSE);

After:

    // logcat
    glColorMask(context = 4, red   = 0x00FF,
                             green = 0x00FF,
                             blue  = 0x00FF,
                             alpha = GL_FALSE)

    // trace
    glColorMask(0xFF, 0xFF, 0xFF, GL_FALSE);

Test: MEC for Dota Underlords
Bug: b/185192780
Bug: angleproject:5857
Change-Id: Ie53aeba8d8a40f91ee375467b325d8e6be053a98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821947
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

fdfb2b82

Capture/Replay: Support glGetQueryiv · 7a95a620

authored Apr 09, 2021

Test: MEC for Dota Underlords
Bug: b/185192780
Bug: angleproject:5857
Change-Id: I59ced20117bde50b5b734a82cb2e5966d1b27227
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821946
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

7a95a620

Capture/Replay: Support glBufferStorageEXT · 4f723d2c

authored Apr 09, 2021

Add the entrypoint, and when a buffer is immutable, recreate it
with glBufferStorageEXT.

Test: MEC for Dota Underlords
Bug: b/185192780
Bug: angleproject:5857
Change-Id: I29b934bdff4185d19594e49e9387dd79c6031aa5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821945Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

4f723d2c

Disable location tags in test isolates. · 68f1203d

authored Apr 13, 2021

The current setup has problems producing tags in an ANGLE checkout.

Bug: angleproject:5114
Change-Id: I91864650ddb2a9df0ac533bf4c43259c476a99ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822238Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

68f1203d

Don't call {begin|end}DebugUtilsLabelEXT() when not enabled · 9c51f93d

authored Apr 12, 2021

The ContextVk::handleDirtyEventLogImpl() and ContextVk::endEventLog()
methods called the {begin|end}DebugUtilsLabelEXT() methods when the
VK_EXT_debug_utils extension is not enabled.  This manifests when
enabling/using VVL stand-alone (i.e. when the the debug-utils
extension is not also present).

Bug: b/183133198
Change-Id: I043b174d457a8796831184c092661f24b33c1db4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821943
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

9c51f93d

Add gclient variable to checkout traces. · bf6e074f

authored Apr 13, 2021

'checkout_angle_restricted_traces' controls if we should check out
the trace tests. We can give restricted access to partners for these
traces. Defaults to the same setting as 'checkout_angle_internal'.

Bug: angleproject:5860
Change-Id: I36efffb180b35e11e104e2c99bc89fb4be4e0708
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822232Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

bf6e074f

13 Apr, 2021 18 commits

Roll Chromium from ab36e1e42f00 to cb430282a083 (277 revisions) · ae99b3d5

authored Apr 13, 2021

https://chromium.googlesource.com/chromium/src.git/+log/ab36e1e42f00..cb430282a083

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/79006bea8b..dde8d8929d
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/e5f83f632d..edbd63483e
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..2b4b340c6e
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/057831ef1f..d73d069a76
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/7168936235..633b99a892
No update to Clang.

Bug: None
Tbr: syoussefi@google.com,jmadill@google.com
Change-Id: I8be169064f0704707d5ae8226f7ffbfce6e9dfd1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824358
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

ae99b3d5

infra: Remove unused debug/cpu properties from tests. · 6faf9ef3

authored Apr 13, 2021

These are now configured through mb_config.pyl. We still pass in the
properties to the lucicfg helper function set up the waterfall UI.

Bug: angleproject:5114
Change-Id: Ib46ab95f5803a166fd2342679afbfcaa6f467c45
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822233Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

6faf9ef3

FrameCapture: write the float values with high precision · fb3173b9

authored Apr 13, 2021

Because values might be the result of calculations that require some
accuracy, writing the float values with the default formatting may
not be sufficient to replay correctly, therefore format the values
so that they carry more digits.

In addition, enable the test that are now passing.

Bug: angleproject:5846
Bug: angleproject:5847
Change-Id: I305552a1ffa3cded6326df59883912e14c95f5f5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822257
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

fb3173b9

GL: Workaround to sanitize amdgpu renderer strings. · 2d873e0c

authored Mar 01, 2021

On Linux with the amdgpu driver, the GL_RENDERER string contains
precise kernel and DRM version info. We should sanitize this info
before using these strings for user privacy.

Bug: chromium:1181193
Change-Id: I047d1abf5b51412b4258a021761cc450385ef0fe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2727658
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

2d873e0c

Remove obsolete Linux, Ozone and Fuchsia bots from CQ · ad01350e

authored Apr 13, 2021

Also removes the new linux-ozone-angle-try bot,
since we are no longer interested to test on this configuration.

Bug: angleproject:4483, chromium:1187259
Change-Id: Iaf50ba99905498cee5dbcac27e1cd7c936c8a975
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822234Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

ad01350e

Migrate CL entry points to libGLESv2 · 8994fc7b

authored Apr 12, 2021

Bug: angleproject:5759
Change-Id: I79644e7bda3ad0a15eb041b2805b8765c0d22029
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822258Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: John Plate <jplate@google.com>

8994fc7b

Vulkan: Fix a validation bug in glBeginTransformFeedback · c8ee13c7

authored Apr 02, 2021

Add logic to check the program or the pipeline before erroring out when
validating glBeginTransformFeedeback.

Bug: angleproject:5557
Test: ProgramPipelineXFBTest31.VaryingIOBlockSeparableProgramWithXFB*
Change-Id: I0df8a8d87b3632745bc91dc2673f2fac31c6cdb1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743440Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

c8ee13c7

infra: Add angle_mb_config.pyl. · fe4053ba

authored Apr 13, 2021

This will be used to set up gn args for standalone builds.
We can then set the GN args source-side instead of in the
recipe directly.

Bug: angleproject:5114
Change-Id: I6fac6d13903951031a7299aea203f6b3e13c72bc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819461Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

fe4053ba

infra: Move and check gn_isolate_map. · 29dc2b6e

authored Apr 13, 2021

In preparation for more source-side configuration. Also adds a presubmit
check and some empty files to enable the presubmit to function.

Bug: angleproject:5114
Change-Id: Id9a0cbe1e78949720be39c65efab73c1345d4f39
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819942Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

29dc2b6e

Vulkan: Remove special output of structs and keep them in AST · cc56e1aa

authored Apr 09, 2021

The code that separated out declaration of nameless structs from uniform
variable declarations is generalized to separate out declaration of all
structs from uniform variable declarations.

As a result, a pass that outputs the struct types at the top of the
shader is no longer necessary.  The struct declarations are kept in the
AST to be output to GLSL as they normally would when not used in
conjunction with uniform variables.

After this change, the Vulkan and Metal translators no longer intermix
transformations and code generation; transformations are done first
entirely in AST, and code generation is done at the end.

Bug: angleproject:2461
Bug: angleproject:4889
Change-Id: Ieb4d3f7091845e50c3dc399603ab01182692521d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818153
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

cc56e1aa

GL: Support VAOs without native VAOs. · 18c6d628

authored Mar 09, 2021

Share the default VAO state between all frontend VAO when
there is no native VAO support. Forcefully sync state every
time a new frontend VAO is bound.

Bug: angleproject:5577, chromium:1167179
Change-Id: Ieaedb5108ad28fc78e7e58b74495639c5246bb05
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2665266Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

18c6d628

Add the jdk dep when building standalone for Android. · fe790824

authored Apr 09, 2021

Chrome started requiring this dep to 'gn gen' on Android so
ANGLE needs it too.

Bug: angleproject:5839
Change-Id: Ia8df8520975ed426667f2c59f0fd7761652b92ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818141
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

fe790824

Reland "Vulkan: Add features to modify sampling parameters" · 065c2329

authored Apr 08, 2021

This reverts commit a51b57fa.

Original change's description:
> Revert "Vulkan: Add features to modify sampling parameters"
>
> Bug: b/167404532
> Change-Id: Iae19dfe165074e8c01216312bddd744c4fb504a4
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2510012
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Tim Van Patten <timvp@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: b/167404532
Change-Id: I2c756b8eb0f61701ef6e33275e557bc199a4d3b4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815259Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

065c2329

Translator: Track nameless interface block field indices in type · c2d1a464

authored Apr 09, 2021

Fields of nameless interface blocks are stored as TVariables and
referenced through a TIntermSymbols (unlike named blocks which use
EOpIndexDirectInterfaceBlock with a constant field indices).  With this
change, the field index is stored in the variable's type which let's the
TField of the TInterfaceBlock be directly accessible (and not need a
search by name).

This will be helpful in translation to SPIR-V as interface block members
are accessed by field index.

Bug: angleproject:4889
Change-Id: If3ab45b1e5f5f9576721dc52e2bdf1161882514f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818242
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

c2d1a464

Vulkan: Use AST transformation for gathering default uniforms · 6ec55494

authored Apr 08, 2021

... instead of generating text.  This will keep the tree in a consistent
state, as previously the references to uniform values where to
TVariable's whose declarations were removed.

Bug: angleproject:2461
Bug: angleproject:4889
Change-Id: I2ef3787dede371514a5f495f4cc8fc67ea45f451
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815564
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

6ec55494

Capture/Replay: Serialize only a hash of the shader binary · faa86bc9

authored Apr 13, 2021

It doesn't make much sense to keep the actual values and it makes
the diff needlessly large when the binaries differ.

Bug: angleproject:5856
Change-Id: I55664d6cb60ef680669c1243c2eabcb67cd4db23
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822256
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

faa86bc9

JsonSerializer: add method to store only a hash for vectors · 6d2f9cb4

authored Apr 13, 2021

This can be used to make the Json comaprison less noisy.

Bug: angleproject:5856
Change-Id: I57df41eed3926647aaf8bcf97a7aea050e1c3d51
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822255
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

6d2f9cb4

Translator: Validate consistent variable references · 58eabfd7

authored Apr 08, 2021

Some transformations change variable declarations.  This validation
ensures that all references to said variables are appropriately replaced
as well.

Bug: angleproject:2733
Change-Id: I6c2873968eeed4cba66e70069f84eb69a1f77074
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818140
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

58eabfd7