In https://chromium-review.googlesource.com/c/453888/, we changed how
blendstates were applied in masked clears. This change would apply a
null blendstate when all color channels were disabled, but this seems
to have an issue on Intel Cherry View drivers. Work around this issue
by restoring the prior functionality of making a simple masked blend
state.

Also clean up some of the code style in the Clear11 class.

BUG=chromium:730126

Change-Id: I9a4044201b2f07e9483525513a59e19bb2a8bcd3
Reviewed-on: https://chromium-review.googlesource.com/533684Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

internalFormat is GL_NONE when validating these calls for glTexSubImage
and leads to an expected minimum size of 0.

Add extra unsized formats that are never supported to the format tables.
These are needed for determining the size of input data.

BUG=angleproject:2054

Change-Id: Ic827a279a246ff92c9f279232574521692b1c6f2
Reviewed-on: https://chromium-review.googlesource.com/526356Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

This puts explicit dependencies from white_box_tests and perftests
on libANGLE. There may be one or two other places where it is
necessary.

BUG=None

Change-Id: Iaa7ea2cade8313c00a396a38f99b5bc8006105db
Reviewed-on: https://chromium-review.googlesource.com/533676Reviewed-by: Jamie Madill <jmadill@chromium.org>

This simplifies the state management code inside this manager. Also
it should improve the speed of lookups due to using hashing instead
of a tree lookup.

BUG=angleproject:1156
BUG=angleproject:2044

Change-Id: I19ea8dbac6f2dfd7d30dd403d77b66ba0aa85d73
Reviewed-on: https://chromium-review.googlesource.com/527693
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

This method doesn't really belong to GL, and was only used by the D3D
back-end to compute some attribute indexes. Simplify the code by
moving it into ProgramD3D. Also add the ability for the ShaderImpl to
assert that any pending compiles have resolved.

BUG=angleproject:1156

Change-Id: I0af3d3082ff8c908e6a87b9734989efbefd28808
Reviewed-on: https://chromium-review.googlesource.com/526336
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This patch intends to clean up all coding style issues in
InstancingTest.cpp.
1. Replace SHADER_SOURCE by std::string
2. Use (expected, actual) as the order of the parameters
   in ASSERT_NE
3. Replace C-style type cast operators into C++ ones.
4. Use ANGLE_GL_PROGRAM to build shader programs
5. Use constexpr when necessary
6. Other format changes done by 'git cl format'

BUG=angleproject:2005

Change-Id: I37d866c5df681160a66226bf5927dd6e00a6d6b2
Reviewed-on: https://chromium-review.googlesource.com/528649
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

The patch decorates all members in VertexBinding as private and limits
access to them only through getters and setters. This makes it easier to
debug and keep track of any assignments to the class members.

BUG=angleproject:2062
TEST=angle_end2end_tests

Change-Id: Iddd49063d060f136bc9cf11c313a5af0931d433c
Reviewed-on: https://chromium-review.googlesource.com/530786
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

ANGLETest provides useful functionality for end2end tests, but it
cannot be used for tests which take other test parameters than the
platform. The patch introduces another level of abstraction by moving
all of ANGLETest's functionality to another class - ANGLETestBase -
which does not inherit from ::testing::TestWithParam<>. New tests can
either inherit from ANGLETest as before to have only platform
parameters, or they can inherit from ANGLETestBase and add handling
of custom test parameters.

Example:

// The new parameter type must inherit from PlatformParameters.
struct MyCustomParameters : PlatformParameters
{
    bool mWorkaroundState;
};

class MyTest : public ANGLETestBase,
               public ::testing::TestWithParam<MyCustomParameters>
{
    protected:
    void overrideWorkaroundsD3D(
        angle::WorkaroundsD3D *workaroundsD3D) override
    {
        workaroundsD3D->myCustomWorkaround = GetParam().mWorkaroundState;
    }

};

ANGLE_INSTANTIATE_TEST(MyTest, MyCustomParameters(ES3_D3D11(), false),
                               MyCustomParameters(ES3_D3D11(), true));

BUG=angleproject:2062
TEST=angle_end2end_tests

Change-Id: Ia36e429cff8c4c291fc87a286a1d1a3004d6fad6
Reviewed-on: https://chromium-review.googlesource.com/530945
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

RewriteElseBlocks used to have an issue where it could add an
unprefixed struct name to the AST in a TIntermRaw node, as opposed to
the prefixed name that the struct would be defined with. Use a proper
return statement node instead of a raw node to fix this issue and make
the code more robust.

BUG=angleproject:2061
TEST=angle_unittests

Change-Id: I3993b5093646983f038268f3a5ffe26ccdae66e8
Reviewed-on: https://chromium-review.googlesource.com/530785Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

This class will manage GPU binary programs in memory. It will be
owned by the Display, and shared between Contexts. Currently this
CL just refactors the Program binary saving and loading into static
members of this new class.

BUG=angleproject:1897

Change-Id: I34f5afb2c02416f6fd80dd65ba3827a8637ce190
Reviewed-on: https://chromium-review.googlesource.com/522873
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

This is a derived type from gl::Error so makes sense to be there.
Also makes it more accessible than in ProgramImpl.h

BUG=angleproject:1897

Change-Id: Id41b13e5a072745d8c361057f5bef8f152e0452b
Reviewed-on: https://chromium-review.googlesource.com/522872Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Refactoring cleanup patch only.

BUG=angleproject:1897

Change-Id: I6d12de5dab16ead9684886a1cf15b570e3c98156
Reviewed-on: https://chromium-review.googlesource.com/522871Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This class is an MRU cache for sized objects, like Textures or
Program binaries. It is based on the base::HashingMRUCache type,
and evicts objects automatically.

BUG=angleproject:2044

Change-Id: I83859a0388f984e872fb9209e4c9efbf5d6c93f1
Reviewed-on: https://chromium-review.googlesource.com/517380Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

The behavior is undefined in GL ES when multiple attachments are used
with gl_FragColor but WebGL clarifies that:
 - If the extension is enabled, broadcast happens
 - If the extension isn't enabled, only the first attachment is written

BUG=angleproject:2048

Change-Id: I6d85ba91df77d42fb8863a03f1faa006cd7817bf
Reviewed-on: https://chromium-review.googlesource.com/523809Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

Bug: chromium:697758
Change-Id: I8a3a990b14cde0fdd45319d593040bfc571abf3e
Reviewed-on: https://chromium-review.googlesource.com/527602
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

In WebGL one can Clear, DrawArrays, and DrawElements to a framebuffer
with a missing attachment with no error.

BUG=angleproject:1822

Change-Id: I4dece2fa8fad31c812e24ae18bdc380c2857a1f8
Reviewed-on: https://chromium-review.googlesource.com/502967Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

This makes shader compiler support the new basic type 'atomic_uint'
and validate its layout qualifiers properly.

BUG=angleproject:1729
TEST=angle_unittests:AtomicCounterTest
     angle_deqp_gles31_tests:dEQP-GLES31.functional.atomic_counter.layout.invalid*
     angle_deqp_gles31_tests:dEQP-GLES31.functional.debug.negative_coverage.*.atomic*

Change-Id: Ia237eadf6ea72314f436a0abbb93a05598e71eba
Reviewed-on: https://chromium-review.googlesource.com/500088
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

With this change, IASetVertexBuffers is only called from a single
code site in StateManager11. All other classes call through to here.
This will make adopting the dirty bits for InputLayouts and VBs much
simpler.

BUG=angleproject:2052

Change-Id: I6e7b6146deb7f80f5f0e75dd0aff18eb4cc2bfc2
Reviewed-on: https://chromium-review.googlesource.com/524232Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Several issues showed up in testing with WebGL:
 * Images should only be forcefully re-defined when there is no data to
   upload.
 * After an image is marked dirty, a later call to subImage would cause
   assertion failures because the texture storage would try to verify that
   the image was not dirty, don't try to copy directly to storage in this
   case.

BUG=angleproject:1635

Change-Id: I9e5d83850d743b7d4d2db938312ee5c35a3a79ee
Reviewed-on: https://chromium-review.googlesource.com/527348
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Make this a proper class, fix the extends method (previously did not
work as expected), add a contains method, and add tests. Also add an
iterator helper class so we can iterate over the range with range-for
loops.

This also fixes the shader resource unsetting code, which was not
actually unsetting all the possible applied textures.

BUG=angleproject:2052

Change-Id: I2a6fa97f96ccb612ad01a5e3f24dc869c54c967b
Reviewed-on: https://chromium-review.googlesource.com/527318Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Refactor texStorage2D and texStorage3D.

BUG=angleproject:747
Change-Id: Id5ab6bbff5ce6debc84318e28b12683bf8b106b1
Reviewed-on: https://chromium-review.googlesource.com/526371
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This merges the mrucache and numerics into one folder, to prevent
having to make two identical versions of logging.

BUG=angleproject:2044

Change-Id: Iba6dab05b21eb9ba0de44f27a90579c590a9a7fd
Reviewed-on: https://chromium-review.googlesource.com/522870Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Eliminates one more usage of FormatString and its static initializer.

Add more ErrorStream types
and replace gl::Error and egl::Error with them.

BUG=angleproject:1644

Change-Id: Ib498d0ae4b81a332ec71aed7cf709993b154e6bb
Reviewed-on: https://chromium-review.googlesource.com/505429
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

It was overkill to always destroy the storage, especially for cube maps.
Instead, just make sure the image thinks it's dirty when robust resource
init is enabled so that it is always copied to the storage after
redefinition.

BUG=angleproject:1635

Change-Id: Ieba065d1873ca66a216bd05f4f8afa9c75349ff9
Reviewed-on: https://chromium-review.googlesource.com/526295Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Second patch for addressing missed comments.

BUG=angleproject:2053

Change-Id: I1268d571913f8ce7efa7b94a5d4e47cf9a80c3c0
Reviewed-on: https://chromium-review.googlesource.com/526275Reviewed-by: Jamie Madill <jmadill@chromium.org>

This merges all calls to IASetInputLayout to a single place in
StateManager11. This means we no longer have to invalidate the state
for D3D11, and can always lazily apply the input layout state.

Introduces a new ResourceSerial class to replace the uintptr_t and
DirtyPointer design.

BUG=angleproject:2052

Change-Id: I76b874218b754395f25a129967c769b1f8f82115
Reviewed-on: https://chromium-review.googlesource.com/523025Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Only dirty the uniforms if the uniforms are dirty. This gives about a
20% reduction in ANGLE overhead on a targeted micro-benchmark. It
probably won't have that large of an impact on most real-world
applications, but it was strictly unnecessary work.

Something that came up when investigating the internal program binary
cache in ANGLE D3D11.

BUG=angleproject:2053

Change-Id: I2d55c010c29ce9627a9001dd2abe6e549f0b7e8c
Reviewed-on: https://chromium-review.googlesource.com/524297Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This makes us use std::ostringstream in more places, instead of
string concatenation.

BUG=chromium:697758

Change-Id: Ifdcaa2e7e119664fc9cfdc566ea13b519a294714
Reviewed-on: https://chromium-review.googlesource.com/521729
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

GLSL 1.017 4.2.4:
Structures must have the same name, sequence of type names, and
type definitions, and field names to be considered the same type.

TEST=conformance/glsl/misc/shaders-with-uniform-structs
BUG=angleproejct:2013

Change-Id: Ieedaaca2d28ef4e1cc0b5480f413ebd513c1dc1f
Reviewed-on: https://chromium-review.googlesource.com/524036
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

If the user repreatedly calls glTexImage with null data and the same size,
it is expected that the texture would re-fill itself with zero'd data.
TextureD3D and ImageD3D would no-op these calls when the texture is
already the right size.

TEST=conformance2/rendering/blitframebuffer-filter-outofbounds
BUG=angleproject:1635

Change-Id: I810b15922759a4acfc0ef7da198f068b81e9efc4
Reviewed-on: https://chromium-review.googlesource.com/524436
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

BUG=angleproject:2051

Change-Id: I09e8548ef76b7d824743d06b0bba21633bc40a24
Reviewed-on: https://chromium-review.googlesource.com/523671
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

When using the program binary memory cache inside ANGLE, this will
give a potential fast path. If the user doesn't query the shader
compile status or info log before calling LinkProgram, then we can
check the program cache before translating the program, and if it
finds a hit, we don't even need to call the translator.

To preserve the shader settings at compile time, a reference to the
current shader translator is kept in a binding pointer on the call
to compile. This mirrors a similar implementation in Chromium's
command buffer. Also the compile options and source are cached at
compile to preserve the correct shader state.

BUG=angleproject:1897

Change-Id: I3c046d7ac8c3b5c8cc169c4802ffe47f95537212
Reviewed-on: https://chromium-review.googlesource.com/517379Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Also remove dead code in Tokenizer.l

BUG=chromium:668842

Change-Id: Ice18313a64f0bb2242299993bfaa882a6578ad54
Reviewed-on: https://chromium-review.googlesource.com/435042Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

The only way to get a core profile context of the highest version using
CreateContextAttrib is to try creationg contexts in decreasing version
numbers. It might look that asking for a core context of version (0, 0)
works on some driver but it create a _compatibility_ context of the highest
version instead which might not be supported on some drivers.

BUG=angleproject:1994

Change-Id: Ic8a33243909c54ea5940ee81c9c866b141bea420
Reviewed-on: https://chromium-review.googlesource.com/480739
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This compiles the resource refactor for D3D11. The only remaining
non-smart handles are for things like SwapChains and ID3D11Blob.

This might be more easily managed by using angle::ComPtr or
similar smart pointers instead of the Resource Manager class.

BUG=angleproject:2034

Change-Id: I53c753a1c19b05c4e72859dd5046e3ed10866847
Reviewed-on: https://chromium-review.googlesource.com/506777Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Similar to the InputLayout init, this adds a small helper type to act
as a wrapper around shader init data (binary and size).

This also adds error trapping to the blit shader compilation. It also
removes the LazyResource2 class, and the CompileXS helper methods.

BUG=angleproject:2034

Change-Id: I3fd718393c8a0250e4263890f00d0e9147ec9567
Reviewed-on: https://chromium-review.googlesource.com/506776Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

In WebGL mode turn on checking that precision qualifiers match in
corresponding vertex/fragment uniform blocks.  Add test for this behavior.

BUG=angleproject:2015

Change-Id: Ie035138e8c46e430bdcf8fb5bbc3e0a3ab7d6391
Reviewed-on: https://chromium-review.googlesource.com/517724
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This is helpful for implementing program binary caching in ANGLE.

in order to maintain the current behaviour in Chrome, we will need
to defer shader compilation until link time. Since WebGL allows the
app layer to enable and disable extensions explicitly, the app can
enable or disable an extension between the calls to glCompileShader
and glLinkProgram. Then, if we're deferring shader compilation, we
will have to preserve the extension settings at the time of the call
to compile, not the current settings at the time of link. Making the
compiler reference-counted gives us a pretty simple and robust
solution.

This also changes the Context class to lazily init the shader
compiler. Lazy init prevents any unexpected nulls, and also ensures
the releaseShaderCompiler does exactly that: just releases the shader
compiler, and does not immediately re-initialize it.

BUG=angleproject:2044

Change-Id: I0f0eeb4eb94dc4eee238f92482804a0921c77df0
Reviewed-on: https://chromium-review.googlesource.com/522868Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Flex version is 2.6.4
Bison version is 3.0.4

BUG=chromium:668842

Change-Id: Ia05ae338c9b9e588534f8346ff5c59ed747c56bf
Reviewed-on: https://chromium-review.googlesource.com/435553Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This introduces a helper type to act as the initialization data type
for input element arrays. A WrappedArray class acts as a helper class
to wrap a C array and size into a C++ class, similar to std::array
but without the data storage.

Also move resource deallocation memory counting into a single code
path.

BUG=angleproject:2034

Change-Id: I5e108254777f0df65f5f60fe26e760c71b95b542
Reviewed-on: https://chromium-review.googlesource.com/506775Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>