Commits · ee85d1bb2f9988644654299a87f476357a5ac79d · Chen Yisong / angle

17 Sep, 2014 6 commits

Fix enum in FRAMEBUFFER_ATTACHMENT_COMPONENT_TYPE query. · ee85d1bb

authored Sep 17, 2014

We were using DEPTH_STENCIL instead of DEPTH_STENCIL_ATTACHMENT.

BUG=angle:739

Change-Id: I0c746c374577dca2b965dfd7ccfac793f7075efb
Reviewed-on: https://chromium-review.googlesource.com/218592Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

ee85d1bb

Accept ImageIndex in TextureD3D::subImage and getImage. · feda4d29

authored Sep 17, 2014

This paves the way for setting data on the TextureStorage directly
instead of working through the Image objects.

BUG=angle:741

Change-Id: I3be3d5f9b2e45707c1630b74ad3f4789e034c3fd
Reviewed-on: https://chromium-review.googlesource.com/218311Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

feda4d29

Fix the varying sort comparator in ShaderD3D. · e6256f87

authored Sep 17, 2014

The comparator was actually a <= operator, while sort requires a
strict < operator. This was causing a potential assertion failure.

Bug report from Kerim Borchaev.

BUG=angle:742

Change-Id: I37c2925ab0b85e70ee1b2be3c72c6ddc062e8d28
Reviewed-on: https://chromium-review.googlesource.com/218506Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

e6256f87

Move validation of ANGLE_instanced_arrays to the validation layer. · 87a93308

authored Sep 16, 2014

BUG=angle:520

Change-Id: Idb3c50235a7029e72c58bc202aba0cfab735202a
Reviewed-on: https://chromium-review.googlesource.com/218510Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

87a93308

Don't modify the function parameters in ProgramBinary::setUniform. · 61f54180

authored Sep 16, 2014

BUG=414450

Change-Id: Ib5ebf18e57af671b8694ffcfc3cb152557f7f002
Reviewed-on: https://chromium-review.googlesource.com/218500Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

61f54180

Add several missing header guard comments · 08a59f85

authored Sep 16, 2014

These were causing build failures under GCC.

Change-Id: Iba19ed166f909fe559d19731f31849770619f412
Reviewed-on: https://chromium-review.googlesource.com/218580Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

08a59f85

16 Sep, 2014 2 commits

gn: Fix source paths · f8a16d7b

authored Sep 16, 2014

Change-Id: Idf0c746d7e4e9f03b176744e8ff027be2d5f25ad
Reviewed-on: https://chromium-review.googlesource.com/218520Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Commit-Queue: Cem Kocagil <ckocagil@chromium.org>
Tested-by: Cem Kocagil <ckocagil@chromium.org>

f8a16d7b

Update Queries to return Error objects instead of calling gl::error. · 5aad9673

authored Sep 08, 2014

BUG=angle:520

Change-Id: If8f2bb1c4de7b9cc30861a06aab1d89c97305b26
Reviewed-on: https://chromium-review.googlesource.com/216699Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

5aad9673

12 Sep, 2014 4 commits

Moving more D3D-only logic into ProgramBinaryD3D · 22502d52

authored Aug 29, 2014

BUG=angle:731

Change-Id: Ia62ec9a912c8bd63fcee51ca206d52688dd999da
Reviewed-on: https://chromium-review.googlesource.com/217495Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Brandon Jones <bajones@chromium.org>

22502d52

Remove dead RenderbufferStorage::getDepthBuffer. · e1f0d00c

authored Sep 12, 2014

This code was unused.

BUG=angle:732

Change-Id: I764d7c5624bdb81650e05a22c4ef0431c2002b18
Reviewed-on: https://chromium-review.googlesource.com/217331Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

e1f0d00c

Add a helper to replace FBO attachment's getSerial. · 612e2e44

authored Sep 12, 2014

Ideally we could store a render target serial in the render target
itself. For now, this helper function allows us to finally stop
exposing rx::RenderTarget from gl::Texture.

BUG=angle:732

Change-Id: I4ffc5e0af6f0542212ad4e74adced21ebbd89462
Reviewed-on: https://chromium-review.googlesource.com/217330Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

612e2e44

Add an attachment helper to replace getRenderTarget. · 9f0b42a6

authored Sep 12, 2014

We would like to stop exposing rx::RenderTarget to any GL-layer
code, like the Context, or Framebuffer. Then we can pull any
necessary information inside the Renderer back-ends.

BUG=angle:732

Change-Id: Ifa35218f097c528e616d732bda4bcd8e5f1c3843
Reviewed-on: https://chromium-review.googlesource.com/217029Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

9f0b42a6

10 Sep, 2014 10 commits

Fix signed-unsigned mismatch · 231943bf

authored Sep 10, 2014

Change-Id: Ie7fba8a0fd0475a395205139c4f7169cc94e61b7
Reviewed-on: https://chromium-review.googlesource.com/217510Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

231943bf

Updated the index buffer classes to use Error objects. · c9e69b19

authored Sep 08, 2014

BUG=angle:520

Change-Id: Ifc249058a3ed3ffffe163a9e3ec21d6fc8c75bd0
Reviewed-on: https://chromium-review.googlesource.com/217101Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

c9e69b19

Only allocate the streaming index buffers when they are first needed. · 1c134e6c

authored Sep 08, 2014

BUG=angle:520

Change-Id: I111e4fd830ad19f6a4ff50749ba891fc14f9154b
Reviewed-on: https://chromium-review.googlesource.com/217100Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

1c134e6c

Move the counting IB from IndexDataManager to Renderer9. · 23ba30e4

authored Sep 08, 2014

BUG=angle:520

Change-Id: Ice0a04b296af6c0a61a604f629b08603e594bb0b
Reviewed-on: https://chromium-review.googlesource.com/216919Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

23ba30e4

Update the RenderStateCache to use Error objects. · 157f9374

authored Sep 08, 2014

BUG=angle:520

Change-Id: I14e2a84c6d2e6f98a50395b63ac206e32bc10f8b
Reviewed-on: https://chromium-review.googlesource.com/216918Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

157f9374

Add queries for attachment targets. · 5b5d1244

authored Sep 09, 2014

Queries for the FBO attachment Textures and Renderbuffers allow us
more options than specific methods for querying the texture
storage or texture serial.

BUG=angle:732

Change-Id: Ieb4ddca3955fcf716dbf54331524d0c1e25fe946
Reviewed-on: https://chromium-review.googlesource.com/217028Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

5b5d1244

Add a TexSubImage benchmark. · bbffd556

authored Sep 10, 2014

Currently we are about 2x as slow on this micro-benchmark in D3D11.
Preliminary testing suggests using CopySubresourceRegion gives
improved performance across the board, but testing could disprove
this hypothesis.

Modified from a sample from bajones.

BUG=angle:705

Change-Id: Iedf36a4e7b9b9bbed308302fd2bf3912acacbd2c
Reviewed-on: https://chromium-review.googlesource.com/216272Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

bbffd556

Fix Win32Window::resize breaking angle_tests. · 9e16d40d

authored Sep 08, 2014

We were messing up the client rect on resize, which caused the
ReadPixels checks to mess up around the window edges. Disabling
the window styles on the test windows masked this bug. Fix this
by using a style-less child window inside the parent window.
This gives us access to window styles for the samples project,
along with the ability to use tiny 1x1 windows for testing.

BUG=angle:730

Change-Id: Ic6dd931df7b4e32fbbcacbb004d3bbc49917f658
Reviewed-on: https://chromium-review.googlesource.com/217024Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

9e16d40d

Get stencil buffer clear parameters format directly. · dd8488d3

authored Sep 03, 2014

The state layer should not be querying render targets directly,
since they are not a GL concept.

BUG=angle:732

Change-Id: I5ee96ae54cced8a32c5082ddd9f8796a975e2591
Reviewed-on: https://chromium-review.googlesource.com/213971Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

dd8488d3

Only use direct buffers for static data in D3D11. · 82cceb2d

authored Sep 09, 2014

For highly dynamic data, which gets updated every frame, or almost
every frame, we're better off using our existing dynamic buffer
path. We could further optimize the dynamic buffer path by only
uploading changed data every frame.

BUG=angle:705

Change-Id: Icbb357b889be789b30f73067f75b13664c806929
Reviewed-on: https://chromium-review.googlesource.com/217280Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

82cceb2d

09 Sep, 2014 4 commits

Starting refactor of ProgramBinary · c9610c51

authored Aug 25, 2014

This is gonna take a while...

BUG=angle:731
Change-Id: Ief72c3361b6429f3f6e0bc2d2ea0810d523ff178
Reviewed-on: https://chromium-review.googlesource.com/215661Tested-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

c9610c51

Squash the Texture attachment classes into one. · eeb7b0e9

authored Sep 03, 2014

BUG=angle:732

Change-Id: Ib6b26fe1351bc09e729178f6ec8b8d2ec1f7ff58
Reviewed-on: https://chromium-review.googlesource.com/213970Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

eeb7b0e9

Revert "Optimize dynamic buffers." · cc00239d

authored Sep 09, 2014

This reverts commit 3e3813f7.

Conflicts:
	src/libGLESv2/renderer/d3d/d3d11/Buffer11.cpp

Change-Id: I6470059672d3b377ce0fafbc8b637318a91f62c8
Reviewed-on: https://chromium-review.googlesource.com/217106Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

cc00239d

Move assertion into if-block. · 5ac5ae86

authored Sep 09, 2014

Since the loop always goes up to MAX_VERTEX_ATTRIBS, the ASSERTION may be
triggered even though no more attributes are enabled.

BUG=angle:740

Change-Id: I2bb30d7e9f426ae1a0b8250e65c1fd02107973ac
Reviewed-on: https://chromium-review.googlesource.com/217027Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

5ac5ae86

08 Sep, 2014 3 commits

Update the ReadPixels calls to return Error objects instead of calling gl::error. · 63d2fc7f

authored Jul 25, 2014

BUG=angle:520

Change-Id: I2ead221e7d1f02cf088b60d0e98376fcd68dde8e
Reviewed-on: https://chromium-review.googlesource.com/211441Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

63d2fc7f

Update clear calls to return Error objects instead of calling gl::error. · cc79b8c6

authored Jul 25, 2014

BUG=angle:520

Change-Id: I474a6ed29b882963f7f3425515e7d65f8f69b3e4
Reviewed-on: https://chromium-review.googlesource.com/211440Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

cc79b8c6

Update Buffers to return Error objects instead of calling gl::error. · 2a1c15a1

authored Jul 25, 2014

BUG=angle:520

Change-Id: I4b6af8e2d4fae97639518e2acd26e2d4be93c925
Reviewed-on: https://chromium-review.googlesource.com/209881Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

2a1c15a1

05 Sep, 2014 7 commits

Eliminate typed render target Texture attachment method. · 1d743d3d

authored Sep 03, 2014

More convergance to the base TextureAttachment class.

BUG=angle:732

Change-Id: I9aae1a49ab3908a4eb4cec4bce201b88a7d93926
Reviewed-on: https://chromium-review.googlesource.com/213859Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

1d743d3d

Use ImageIndex to return Texture attachment properties. · de3ed704

authored Sep 03, 2014

This and subsequent patches will eliminate the need for typed
attachments.

BUG=angle:732

Change-Id: Ia1cfa672855b577f7a2ce219e6ed8ca1e3e16cc1
Reviewed-on: https://chromium-review.googlesource.com/213858Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

de3ed704

Fix typo in "PixelShaderOuputVariable". · f6be8d7c

authored Sep 05, 2014

Change-Id: I2b223c9b80faa3ff2a0f94bd52ca73edf3d67cf7
Reviewed-on: https://chromium-review.googlesource.com/216273Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

f6be8d7c

Drop support for the old "full multiplexed" MRT shaders. · f9479eff

authored Sep 05, 2014

This will simplify the code somewhat. It should no longer be
necessary now that we have the nVidia workaround.

BUG=angle:705

Change-Id: I1abe1abd9f03472341ce4315975a76c56b252bb4
Reviewed-on: https://chromium-review.googlesource.com/216111Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

f9479eff

Enable MRT pixel shader rewriting. · 3f2e61de

authored Sep 05, 2014

Writing to all 8 pixel outputs was causing performance problems on
Intel and AMD. Enabling Geoff's work to rewrite our pixel shaders
solves the regression.

This patch also includes a workaround to the nVidia driver bug
where it would ignore NULL RT values in OMSetRenderTargets, by
compacting the RT list to skip NULL values.

BUG=angle:705
BUG=365078

Change-Id: Ia68af6f0ccd5f10c484d6f76297a0bec694948f0
Reviewed-on: https://chromium-review.googlesource.com/214852Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

3f2e61de

Use attachment binding points for dynamic PS key. · aef95dec

authored Sep 05, 2014

Because our output signature is only dependent on the arrangment
of the attachments, not the attachment type, use the output
layout key for now. If we need to, we could store both, in the
future.

BUG=angle:705

Change-Id: I3b99954d30b91a4741fdd6f48f8ffcf88c0bea7a
Reviewed-on: https://chromium-review.googlesource.com/215846Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

aef95dec

Declare commit_id a gyp 'hard_dependency'. · b33b4777

authored Sep 04, 2014

Hard dependencies are marked for static library targets, unlike
normal soft dependencies which the static libraries ignore. This
change ensures we run the commit_id script before compiling any
static libraries that depend on it.

Change-Id: Ic29652012883273810c2863132d6f49bd6ada4b8
Reviewed-on: https://chromium-review.googlesource.com/216461Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

b33b4777

04 Sep, 2014 1 commit

Fix MSVC librarian warning about no target machine. · 58f79422

authored Sep 04, 2014

We had the appropriate setting in our linker settings, but were
missing the entry in our librarian settings. The new static lib
target exposed the error.

Change-Id: I689ccb3cd6dbf2218c869b33500aaef43b8a421f
Reviewed-on: https://chromium-review.googlesource.com/216460Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

58f79422

03 Sep, 2014 3 commits

Add a new TextureAttachment class to simplify FBO attachments. · 3592a338

authored Sep 03, 2014

This single class will eventually replace the four child classes.

BUG=angle:732

Change-Id: Ie2862b4458c8b1302ff4fc5fbe0e4ded3b81894d
Reviewed-on: https://chromium-review.googlesource.com/213857Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

3592a338

Add an ImageIndex helper struct to index into tex levels. · 945f7329

authored Sep 03, 2014

This encapsulates the three values needed to index into the image
array. It will simplify the logic for querying texture images from
the base calss.

BUG=angle:732

Change-Id: I31c55b3f972fd4d96ab540ec8498ef4b9b2ba16b
Reviewed-on: https://chromium-review.googlesource.com/213856Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

945f7329

Refactor Framebuffer::invalidateSub. · 6d708263

authored Sep 03, 2014

Use our new helper methods to simplify this method.

BUG=angle:732

Change-Id: I56b837678d5efbc60de6de4bdb01447ca811e71d
Reviewed-on: https://chromium-review.googlesource.com/213855Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

6d708263