1. 11 Jan, 2018 2 commits
  2. 10 Jan, 2018 5 commits
  3. 09 Jan, 2018 2 commits
  4. 08 Jan, 2018 2 commits
  5. 06 Jan, 2018 1 commit
  6. 05 Jan, 2018 7 commits
  7. 04 Jan, 2018 8 commits
  8. 03 Jan, 2018 7 commits
    • Move angle_enable_* inside declare_args(). · 6df487ef
      Frank Henigman authored
      This allows enabling and disabling parts of the build via gn args,
      similar to what gyp allowed.
      
      BUG=angleproject:1569
      
      Change-Id: Ia95c134f98f8941408df96b1d4e2563e713a9ef2
      Reviewed-on: https://chromium-review.googlesource.com/838260
      Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
      Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    • HandleAllocator: Fix heap ordering using std::greater. · fc3463da
      Jamie Madill authored
      The default heap ordering is to return the greatest element in the
      heap. Since the handle allocator expects a minimal return value on
      a new allocation, this caused a bug. The bug is triggered by reserving
      handles, allocating new handles, then freeing the handles and
      allocating again with the same allocator. Fix the bug by using
      std::greater instead of std::less, which will make the heap
      return the smallest value instead of largest.
      
      Also adds some logging debugging code for the handle allocators.
      
      Bug: angleproject:1458
      Change-Id: Ibef5dcbed0a664ccad0e0335f081e2355162584b
      Reviewed-on: https://chromium-review.googlesource.com/848644
      Commit-Queue: Jamie Madill <jmadill@chromium.org>
      Reviewed-by: 's avatarFrank Henigman <fjhenigman@chromium.org>
    • Revert "Enable depth buffer to workaround driver bug on Intel windows" · 36937a64
      Jamie Madill authored
      This reverts commit 63ba357c.
      
      Reason for revert: May be causing Windows GPU.FYI bot failures.
      
      https://ci.chromium.org/buildbot/chromium.gpu.fyi/Win10%20Release%20%28Intel%20HD%20630%29/1443
      
      maps_pixel_test on Intel GPU:
      Unexpected Failures:
      * gpu_tests.maps_integration_test.MapsIntegrationTest.Maps_maps
      
      webgl2_conformance_tests on Intel GPU:
      Unexpected Failures:
      * gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_deqp_functional_gles3_fboinvalidate_default
      * gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_deqp_functional_gles3_fboinvalidate_sub
      
      Bug: chromium:798757
      
      Original change's description:
      > Enable depth buffer to workaround driver bug on Intel windows
      >
      > Rendering with depth buffer disabled and stencil buffer enabled
      > leads to memory leak if we set viewport a large size on Intel
      > windows platforms. So we enable depth buffer if stencil buffer
      > is enabled to workaround this issue.
      >
      > TEST=gl_test.exe --gtest_filter=GLClearFramebufferTestWithParam/GLClearFramebufferTest.ClearDepthStencil/0
      > TEST=conformance/rendering/rendering-stencil-large-viewport.html
      > TEST=RenderStencilBufferTest.DrawWithLargeViewport/ES3_D3D11
      >
      > BUG=782317
      >
      > Change-Id: Idb185db296f13e3fa897534514e198651a56439f
      > Reviewed-on: https://chromium-review.googlesource.com/809574
      > Commit-Queue: Jamie Madill <jmadill@chromium.org>
      > Reviewed-by: Jamie Madill <jmadill@chromium.org>
      
      TBR=zmo@chromium.org,geofflang@chromium.org,jmadill@chromium.org,kbr@chromium.org,cwallez@chromium.org,yunchao.he@intel.com,jiajia.qin@intel.com,xinghua.cao@intel.com,bryan.bernhart@intel.com,yizhou.jiang@intel.com,yang.gu@intel.com
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: 782317
      Change-Id: I7e29da683b22fd4640c230598c7b220cfae6a177
      Reviewed-on: https://chromium-review.googlesource.com/848133
      Commit-Queue: Jamie Madill <jmadill@chromium.org>
      Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    • Replace remaining usage of TName with TSymbol · 8b5e8fdb
      Olli Etuaho authored
      TName used to contain just a subset of the information stored in
      TSymbol. It makes more sense to use TSymbol directly instead of
      converting it to TName.
      
      This also improves type safety a bit by making some functions only
      take in TVariable or TFunction instead of the more generic TName.
      
      BUG=angleproject:2267
      TEST=angle_unittests
      
      Change-Id: Icb46923c25d33ebbbbc06ddc487da25957dda771
      Reviewed-on: https://chromium-review.googlesource.com/829143
      Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
      Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    • Index symbols by id in OutputHLSL · 93b059db
      Olli Etuaho authored
      This is cleaner than indexing them by their name string.
      
      BUG=angleproject:2267
      TEST=angle_unittests
      
      Change-Id: I0d0ef5e3f6a3f26c94f096b086cdf3da40d495e4
      Reviewed-on: https://chromium-review.googlesource.com/845559
      Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
      Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
      Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
    • Start D3D constant register allocations from 1 on NVIDIA · d8724a94
      Olli Etuaho authored
      Recent NVIDIA drivers have a bug where a specific optimized path
      inside the driver doesn't handle constant register 0 correctly. Work
      around this by starting constant register allocations from 1. This
      should make sure that the bug doesn't trigger if the ordering of
      uniforms is changed on the D3D backend.
      
      The repro case seems to require some specific driver state to be set
      that's used inside Chromium. Because of this we have not been able to
      develop a standalone test case so far.
      
      The maximum number of available uniform slots is reduced accordingly.
      This should not take them below required minimums in the spec.
      
      BUG=angleproject:2294
      TEST=WebGL tests on passthrough command buffer,
           angle_end2end_tests --gtest_filter=*GLSLTest*Uniform*
      
      Change-Id: I92fff71efe5432ea7f15a7e90d497492514c65dc
      Reviewed-on: https://chromium-review.googlesource.com/847481
      Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
      Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
      Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    • ES31 program query: support TRANSFORM_FEEDBACK_VARYING · 910a3daf
      jchen10 authored
      TRANSFORM_FEEDBACK_VARYING corresponds to the set of output variables
      in the last non-fragment stage of program that would be captured when
      transform feedback is active. The resources enumerated by this query
      are listed as specified by the most recent call to
      TransformFeedbackVaryings before the last call to LinkProgram.
      This mainly collects these resources for query.
      
      BUG=angleproject:1920
      TEST=angle_end2end_tests:ProgramInterfaceTest*
           dEQP-GLES31.functional.program_interface_query.transform_feedback_varying.*
      
      Change-Id: I0655b12c6d82cef1b44d4ca57ea55bb60d1f78fb
      Reviewed-on: https://chromium-review.googlesource.com/770450
      Commit-Queue: Jamie Madill <jmadill@chromium.org>
      Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
  9. 02 Jan, 2018 6 commits