- 16 May, 2020 3 commits
-
-
Nicolas Capens authored
This is just a refactoring which avoids storing the type as a Variable fields, since the 'LValue<T>' subclass knows the type statically and we only need it during materialization. This gives us a vtable for overloading other methods in subsequent changes, at no additional storage cost for Variable. Bug: b/155302798 Change-Id: I36f6ef8f5f4d2b50ba04d539dc8b9735481c816a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44668 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
This is just a refactoring which will allow adding a virtual getType() method in a subsequent change without overload naming conflicts. 'isVoid()' has been removed since it appears unused now. Bug: b/155302798 Change-Id: I16f5cbd947da9581e0f20837497f6b61cfeb7a21 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/45008 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
Previously any SPIR-V OpExecutionMode instruction would override the execution mode parameters, so a shader module with multiple entry points with different execution modes would not work as intended. Bug: b/155550449 Change-Id: I86211e66a3cef5a3bbf9e535e9be8415b5d69d4b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/45249 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
-
- 15 May, 2020 1 commit
-
-
Nicolas Capens authored
Doing a test run with LLVM after the one with Subzero results in various tests timing out (including some 'UNSUPPORTED' ones). The Subzero test run doesn't exhibit this issue. It's unclear at this point why this happens, but reversing the order appears to stabilize it. Bug: b/156728197 Change-Id: I6450d2d95d6043ef206d09f0020313fbf4b3f2e2 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/45149Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
-
- 14 May, 2020 1 commit
-
-
Sean Risser authored
In has16bitTextureFormat(), we were missing several formats. Also this function was poorly named, as it made it seem like we were just duplicating the work of the bytes() function but giving less informations. What has16bitTextureFormat() is really checking for is if the texture format is 16 bit Packed. So it's been renamed to has16bitPackedTextureFormat() Bug: b/150076646 Change-Id: I8082e8e9d3845cfa3b5c3ec4a269454457d558ce Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42688Tested-by:
Sean Risser <srisser@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
- 13 May, 2020 3 commits
-
-
Alexis Hetu authored
ANGLE uses image blit to generate mipmaps so, for cubemaps, a border update is required after we blit into an image so that the cube's border are still seamless when using lower mip levels. Fixes WebGL Conformance Test: conformance/textures/misc/texture-size.html Bug: b/154620294 Change-Id: I22daf60afd9143c52a57c67ae0039eb49be4f1ca Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44990 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Jonah Ryan-Davis authored
The reply function for xcb_get_geometry was called without handling errors, causing a null-dereference in the fuzzer. These calls should be wrapped and handled safely. Bug: chromium:1080987 Change-Id: Ie1377909b68375fa9bc6eb54bdcbfda0627fd680 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/45068 Presubmit-Ready: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Jonah Ryan-Davis <jonahr@google.com>
-
Alexis Hetu authored
According to the Vulkan spec: 2.9.2. Conversion from Floating-Point to Normalized Fixed-Point "The conversion from a floating-point value f to the corresponding unsigned normalized fixed-point value c is defined by first clamping f to the range [0,1], then computing ..." Also, in section 18.3. Clear Values: "float32 are the color clear values when the format of the image or attachment is one of the formats in the Interpretation of Numeric Format table other than signed integer (SINT) or unsigned integer (UINT). Floating point values are automatically converted to the format of the image, with the clear value being treated as linear if the image is sRGB" Added a clamp to sRGB values to avoid getting out of bound values for the sRGB color space. Bug: b/151469361 Change-Id: I22615b807384904ca4fa887e93529d5a4b185d04 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/45090 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
- 11 May, 2020 1 commit
-
-
Antonio Maiorano authored
This lets users specify the level of sampling precision they want. Chromium needs this to pass WebGL tests with SWANGLE. Bug: b/146423360 Bug: b/154620295 Change-Id: I83575823b5909d836c3d4c02803ba7909ce08935 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42268Tested-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
-
- 08 May, 2020 1 commit
-
-
Nicolas Capens authored
This prevents '400 Bad Request' responses. The limit of 16000 was determined through experimentation. Bug: b/150284316 Change-Id: I5507efdcfbaac2c09c2dffde9bf173f4f9219a72 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44989Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
-
- 07 May, 2020 3 commits
-
-
Nicolas Capens authored
This reverts commit cd09f8e9. Reason for revert: Kokoro build failures Bug: b/130335507 Change-Id: I5479cc40723ae3a95e3d9fb7b74de8506f188e08 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44928Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
Nicolas Capens authored
Exporting all typeinfo was copied over from the GLES version scripts which addressed crbug.com/737384. However, this can lead to ODR violations, and we have several other solutions in place for avoiding UBSan failures. Remove it entirely for now. If this causes a regression and we still have to export some typeinfo, we should do so selectively. For example to only export typeinfo for objects in the vk namespace: _ZTS*vk*; _ZTI*vk*; Alternatively, or in addition, we can try using '-mllvm -asan-use-private-alias=1'. Bug: b/155441530 Change-Id: I07303ac01b05d02b879fff829b6a9945c16fdf82 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44689 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
Nicolas Capens authored
This is already a warning treated as an error by GCC/Clang: -Werror=delete-non-virtual-dtor Bug: b/130335507 Change-Id: I9d44f668168e2a77da8839017871e469f5d53bcb Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44788Tested-by:
Nicolas Capens <nicolascapens@google.com> Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
-
- 06 May, 2020 4 commits
-
-
Alexis Hetu authored
Followup to: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43950 Fixes dEQP.KHR_GLES31/core_compute_shader_copyimage. This dEQP test was passing by chance, because load and store were paired properly together, being equally incorrect with regards to the OpenGL ES specs, which mentions: GLES 3.1 spec, section 8.22: If the individual texel identified for an image load or store operation doesn’t exist, the access is treated as invalid. Invalid image loads will return a vector where the value of R, G, and B components is 0 and the value of the A component is undefined. Invalid image stores will have no effect. Bug: b/150464740 Change-Id: I5aa508ed7f08e234387478d3a6faee958ca9dd97 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44868 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Ben Clayton authored
`target_compile_options` should have been `target_compile_definitions` Also remove the global `set_cpp_flag` for these defines which are now unnecessary. Bug: b/145758253 Change-Id: Ie03b0ad196bd1ee155e3f4953d920d6b502db51c Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44848Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
James Price authored
Fixes more MSan LLVM JIT false positives. Change-Id: I0579e2cc71b089424fe168cc60fed63c4b431f91 Bug: b/140204746 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44708 Presubmit-Ready: James Price <jrprice@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
James Price <jrprice@google.com>
-
Alexis Hetu authored
When the out of bounds behavior is defined and any of the image coordinates is out of bounds, this cl manually pushes the pointer out of bounds in order to trigger the out of bounds behavior even if the resulting pointer would still be within memory bounds. Bug: b/150464740 Change-Id: I685973dfac440a8bca830810cf974819cfbc0f33 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43950 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
- 05 May, 2020 3 commits
-
-
SwiftShader Regression Bot authored
Reactor backend: LLVM Change-Id: Idacca75cfd2a18886dc9f86f3d9a60d9d40d8bd3 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42930Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
Ben Clayton authored
`runDailyTest()` calls `test.cleanup()` before returning, removing the entire checkout directory, along with coverage data, and the git repo. This breaks both `postDailyResults()` and `postCoverageResults()`. Instead use a callback to handle the daily results. This way we can keep the `defer` to clean up even in case of error. Change-Id: I9730d7dd8ac9c3a19d82d07a68325afdf38bfd40 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44748Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
turbo-cov can only process clang coverage information, so there's no point building it for other toolchains. turbo-cov depends on the llvm-10 libs and headers, and does not build against llvm-7. Bug: b/152192800 Change-Id: I522ecb3adfbd448aa47673c452a83083134a36ca Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44728 Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
- 04 May, 2020 1 commit
-
-
Nicolas Capens authored
This typeinfo was added for UBSan failures reported in crbug.com/737384, but it didn't address other 'Incorrect-function-pointer-type' failures for crbug.com/746914. We've suppressed sanitization for these functions with the NO_SANITIZE_FUNCTION macro, refactored interfaces used across library boundaries into purely abstract ones for crbug.com/732667, and use '-mllvm -asan-use-private-alias=1' to address b/128551743. It's unclear whether this typeinfo still serves ay purpose We shouldn't have to export typeinfo for objects used only inside the shared library, to avoid ODR violations. Remove it entirely for now. If this causes a regression and we still have to export any typeinfo, we should do so more selectively. For example to only export typeinfo for objects in the egl namespace: _ZTS*egl*; _ZTI*egl*; Alternatively, or in addition, we can try using '-mllvm -asan-use-private-alias=1' for more build systems. Bug: b/155441530 Change-Id: Ia966c40dfe45817f356d11725910afef1bb94d6e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44688 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
-
- 02 May, 2020 6 commits
-
-
Nicolas Capens authored
Bug: b/146166966 Bug: angleproject:4071 Change-Id: Ib2c69de7fb00ae1917b657840f7c456792f804f6 Tests: dEQP-VK.* Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44531Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
Nicolas Capens authored
Bug: b/146166966 Bug: angleproject:4071 Change-Id: Ifbfcf2d68c8789b0f91fef48db95bd9dc5a7576a Tests: dEQP-VK.* Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44530Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
Bug: b/146166966 Bug: angleproject:4071 Change-Id: If5746fac41ba8890804819efd2f05b359e666b4f Tests: dEQP-VK.* Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44529Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
Bug: b/146166966 Bug: angleproject:4071 Change-Id: I154e0fa9395e7bd10d82cc2564fa507af68d7497 Tests: dEQP-VK.* Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44528Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
Nicolas Capens authored
Bug: b/146166966 Bug: angleproject:4071 Tests: dEQP-VK.* Change-Id: I07008936fbb09f134283a21a6d3bba881f97fe09 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40668Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Nicolas Capens authored
Currently all conditional branches in SPIR-V shaders are 'flattened', resulting in the execution of all instructions in both code paths, even in the case where none of the SIMD lanes are active. If a logically never taken code path contains an image sampling instruction which accesses a sampler or image array out of bounds, this could lead to reading invalid descriptor data, or a page fault. This is fixed by checking if any SIMD lanes are active, and if not, jumping over the actual sampling operations which access the descriptor data. Bug: b/153380916 Change-Id: I8e0cf7ef855e1250ce6dce9ebf7a47e29da7814d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43549Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
- 01 May, 2020 2 commits
-
-
Nicolas Capens authored
Bug: b/154013190 Change-Id: I0a51912c3fad45f6ce0d04cbc7d4b56e1276d1dc Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44588 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
-
Antonio Maiorano authored
Use the Subzero backend instead of LLVM when running Regres per CL. Turnaround times should be faster, and since Chromium now uses SwiftShaderVK/Subzero, we'll know which CL breaks it, if any. Change-Id: If164d87c4946a1f7899c3407cc31fa2f1eba4931 Bug: b/152216043 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44628Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
-
- 30 Apr, 2020 8 commits
-
-
Ben Clayton authored
Changes: 3c643dd4c Reduce size of marl::ConditionVariable ffa88289a Pool::Loan::get(): Return nullptr if has no item. 6c9341313 Add a new test for 16-byte stack alignment for fibers. 924493413 Fix marl::parallelize race. Commands: ./third_party/update-marl.sh --squash Bug: b/140546382 Change-Id: Ie3d376ae9e80d5a40960aee07b664be2d75c69d5 -
Ben Clayton authored
3c643dd4c Reduce size of marl::ConditionVariable ffa88289a Pool::Loan::get(): Return nullptr if has no item. 6c9341313 Add a new test for 16-byte stack alignment for fibers. 924493413 Fix marl::parallelize race. git-subtree-dir: third_party/marl git-subtree-split: 3c643dd4c88d612a2622366074e029dca6a794d1
-
Ben Clayton authored
OpLine is produced for any line / column change. Column information may be useful for stack frame information (say two function calls on the same line), diagnosing a crash in a complex expression, or some other tooling. However, it's not so useful for IDE debugger stepping, unless you have a location for the span end (which we don't). Bug: b/155390706 Bug: b/148401179 Change-Id: Ic416c6e3c47044d707bfa36112e1153588669424 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44549Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Fix warning treated as error that loop only iterates once. Bug: b/148401179 Change-Id: I8caf237ede034ba6802a6fbc8167140b27cc13cb Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44548Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
Instead of using raw pointers, use `std::unique_ptr`. Bug: b/126126820 Change-Id: Ia095f6aec1448c2153a0b0159f25a2946054e64b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43813Tested-by:
Ben Clayton <bclayton@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Antonio Maiorano authored
Script runs a cmake command to generate and open a png with a dependency graph of currently enabled SwiftShader targets. Note that you should use CMake 3.17 to get the best looking graph, as many fixes and improvements were made to the graphviz support in 3.17. Bug: none Change-Id: Ie84eb18377b15f823bcdfe34612bf532502adf48 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/43748Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com>
-
James Price authored
Applied same fix as done in 0e6a044d for the same macro in src/Common/Types.hpp (including copying the comment verbatim). Change-Id: I822db18f19a5473d9cf56ab57339ae91e96f458e Bug: b/155089897 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44508Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
James Price <jrprice@google.com>
-
Nicolas Capens authored
When JIT_IN_SEPARATE_THREAD is defined we generate Reactor routines on LLVM in a new thread. With Variable::unmaterializedVariables now a thread-local pointer, we have to avoid touching it from the separate thread. This is accomplished by moving the createRet() call out of the lambda which gets called on the separate thread. Note that while the 'jit' object is no longer needed after acquireRoutine(), that method may not be called since one may return early from Reactor code generation. Its deletion was removed from acquireRoutine() since Nucleus destruction follows quickly after and this keeps the object's explicit lifetime management simple. Note also that 'Variable' objects may still exist after acquireRoutine() has been called, so the earliest we can delete the set of unmaterialized variables is still at Nucleus object destruction when Function<> is destructed. Bug: b/153803432 Bug: b/149829034 Change-Id: Ic3940e5c52a3009e48fb1e1ff6137db6fd5ca96b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44488 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
-
- 29 Apr, 2020 1 commit
-
-
Nicolas Capens authored
Chrome supports Linux versions which don't come with a glibc library which supports __cxa_thread_atexit_impl. This function is required for destroying C++11 thread_local objects at thread exit. The 'jit' and 'unmaterializedVariables' thread-local objects used by Reactor are only needed between Function<> creation and Routine acquisition, so replace them by explicitly managed raw pointers. Bug: chromium:1074222 Bug: b/153803432 Change-Id: I0a92bdd30940048b9ce0c208d3a2c1a952091283 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44428 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
- 28 Apr, 2020 2 commits
-
-
Antonio Maiorano authored
As per Khronos, these enums will no longer be available in future Vulkan headers: https://www.khronos.org/news/permalink/khronos-group-asking-for-feedback-on-removing-begin-range-end-range-range-size-tokens-from-headers This change now asserts that our Vulkan driver is built using a known version of the Vulkan headers (vk::SwiftShaderVulkanHeaderVersion), and when we update, the static assert will trip, reminding us to validate the range constants that we use, and must manually maintain. Bug: b/153337629 Bug: b/154215163 Change-Id: I319978e3979893a8a0cc44caf6cc79a584e518fb Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44388Tested-by:
Antonio Maiorano <amaiorano@google.com> Kokoro-Result: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Antonio Maiorano authored
Our script, src/clang-format-all.sh, applies only to .hpp, not .h files. Ran it again after renaming the Vulkan-source .h to .hpp. Bug: b/144825072 Change-Id: I2c6d11ec2285567155f207830bdf560431b927f4 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44390 Kokoro-Result: kokoro <noreply+kokoro@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-