Commits · 7a8ed2e14ad40356a624826df166c41fec7e2525 · Chen Yisong / swiftshader

02 Nov, 2017 1 commit

Prevent initializing outline edges to out of bound values · 7a8ed2e1

authored Nov 02, 2017

When multisampling is enabled, outline edges were getting
initialized to one of the  primitive's X position. If the
primitive was out of bounds, then the default position was
out of bounds, which led to an initial out of bounds memory
access.

Added a clamp to fix the issue.

Bug chromium:779364

Change-Id: I4661f4229ee28a3032c763ed18dde799d3c3926b
Reviewed-on: https://swiftshader-review.googlesource.com/13528Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

7a8ed2e1

01 Nov, 2017 1 commit

translator: Add define to disable pool allocation. · 3d7c786f

authored Oct 31, 2017

This will help ASan find bugs in the translator when fuzzing, by making
separate allocations instead of using suballocations within the pool.

BUG=swiftshader:86

Change-Id: Ic59f7eef2c7985f7bf545d41be956df478331e2d
Reviewed-on: https://swiftshader-review.googlesource.com/13488Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Corentin Wallez <cwallez@google.com>

3d7c786f

31 Oct, 2017 3 commits

Fix Visual Studio warning treated as error. · f9fd0d9b

authored Oct 31, 2017

Was an implicit narrowing from size_t (64-bit) to unsigned int (32-bit).

Change-Id: I9726d70370d97da1bae2652bbce9db929179a292
Reviewed-on: https://swiftshader-review.googlesource.com/13469Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

f9fd0d9b

Fix pedantic Linux warning treated as error. · 3e2b1093

authored Oct 31, 2017

Unused variable 'entry'.

Change-Id: I115b7d599d871c0f130f72e32618a8ed29776b81
Reviewed-on: https://swiftshader-review.googlesource.com/13468Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

3e2b1093

Enable executable code generation and linking. · 13d16092

authored Oct 31, 2017

Bug swiftshader:86

Change-Id: If98cbf93e8b8d41246d9f06503da0752fe968ff8
Reviewed-on: https://swiftshader-review.googlesource.com/13448Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Corentin Wallez <cwallez@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

13d16092

30 Oct, 2017 3 commits

Fix vertex stream count and normalized data layout. · 194c8e03

authored Oct 30, 2017

Bug swiftshader:86

Change-Id: Ide76f9e7d8c490e5057959e1a7c28dfc7119151a
Reviewed-on: https://swiftshader-review.googlesource.com/13428Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Corentin Wallez <cwallez@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

194c8e03

Support for gl_MaxDrawBuffers in OpenGL ES 3.0 · 665757de

authored Oct 30, 2017

gl_MaxDrawBuffers is still available in OpenGL ES 3.0.
It was just a matter of making it part of the common builtins.

Change-Id: Icd3ca9f4f50cba43c345974ef72603800155a573
Reviewed-on: https://swiftshader-review.googlesource.com/13389Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

665757de

Switching MacOS to use Subzero · e2febff0

authored Aug 02, 2017

Currently Windows and Linux already use the Subzero backend, while
MacOS still uses the LLVM backend. This cl switches MacOS to using
the Subzero backend.

Change-Id: Ibc20add93c5f413271832fd1dd7fe7ae00cda9f4
Reviewed-on: https://swiftshader-review.googlesource.com/11213Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

e2febff0

27 Oct, 2017 6 commits

vertex_routine_fuzzer: Get source from `data` · 1730b2df

authored Oct 27, 2017

BUG=swiftshader:86

Change-Id: Ia57c894170e790cdd1ea2fe3b92bbba7f643ba64
Reviewed-on: https://swiftshader-review.googlesource.com/13368Tested-by: Corentin Wallez <cwallez@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

1730b2df

Fill vertex routine state for fuzzer. · b6f0e40b

authored Oct 27, 2017

Bug swiftshader:86

Change-Id: I8339f3882163daa078ac71034aaf37147e51d725
Reviewed-on: https://swiftshader-review.googlesource.com/13349Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

b6f0e40b

Fix last stream type enum. · 73082975

authored Oct 27, 2017

Change-Id: I119c9bd65624035cbb0afb850b061e140b6a296f
Reviewed-on: https://swiftshader-review.googlesource.com/13348Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

73082975

Fix MSVC compilation of the VertexRoutineFuzzer · 6e27fea8

authored Oct 27, 2017

We should really have these suppressions in a shared config over all
swiftshader.

BUG=swiftshader:86

Change-Id: I1b8fa6342090e78e2338a7d748bcb29911f9e393
Reviewed-on: https://swiftshader-review.googlesource.com/13328Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Corentin Wallez <cwallez@google.com>

6e27fea8

VertexRoutineFuzzer: Add code able to compile a simple shader · f521ac05

authored Oct 24, 2017

The fuzzer still needs to parse state and source from `data` before it
can actually be useful.

Bug swiftshader:86

Change-Id: Iafcbce4748b83a4fb9f829e3e8a473d161d3a696
Reviewed-on: https://swiftshader-review.googlesource.com/13249Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

f521ac05

libGLESv2: compile entry points in the shared library. · b0397118

authored Oct 26, 2017

Without this the GN shared library doesn't export any of the gl
entry-points making it useless.

Bug swiftshader:86

Change-Id: I97f6acf4204d6e908ad12c89c79d40769dc824a4
Reviewed-on: https://swiftshader-review.googlesource.com/13308Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

b0397118

26 Oct, 2017 4 commits

Use more explicit include paths. · 708c24b3

authored Oct 26, 2017

This helps clarify dependencies and simplifies include paths.

Bug swiftshader:86

Change-Id: I564ee420bb9029fa6428e49b63a86d633301bec2
Reviewed-on: https://swiftshader-review.googlesource.com/13288Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

708c24b3

Data race fix · f2520e19

authored Oct 26, 2017

There's a data race involving threadCount,
so it is now an AtomicInt object.

Also removed unused extern variables.

Bug chromium:778254 chromium:776621

Change-Id: I93174e8f4e5e48f26414ba9c81bb9a2c317dbf73
Reviewed-on: https://swiftshader-review.googlesource.com/13290Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

f2520e19

Primitive restart implementation · 74b91b5a

authored Oct 25, 2017

Wrote a new version of primitive restart
entirely handled by the index data manager.

Passes all primitive_restart dEQP tests

Change-Id: I0ce28764a33300a6625f1c369f95d8d178e1e3c0
Reviewed-on: https://swiftshader-review.googlesource.com/10951Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

74b91b5a

Fix rendering to single-channel color buffers. · 7a473b78

authored Oct 25, 2017

Render targets with only a red or alpha component were getting swapped
values within pixel quads at the edge of primitives. Also provide
format mappings for GL_EXT_texture_rg.

Change-Id: Ifb395039fb2958400ab36d5d184d7952d60fa9c6
Reviewed-on: https://swiftshader-review.googlesource.com/13268Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

7a473b78

24 Oct, 2017 1 commit

Add a stub "vertex routine" fuzzer · 57eb063d

authored Oct 24, 2017

Bug: swiftshader:86

Change-Id: I351e433123abfaf010e3b1641383054e77dc6383
Reviewed-on: https://swiftshader-review.googlesource.com/13228Tested-by: Corentin Wallez <cwallez@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

57eb063d

19 Oct, 2017 1 commit

Update the Windows Target Platform Version · 66fff4e8

authored Oct 19, 2017

Rather than have to download a previous version (10.0.15063.0),
we can update the solution to the current version (10.0.16299.0).
Built solution in 32b/64b release/debug with no failures.

Change-Id: If19d8f6edcce4bcfac21c005f647ab1619837d16
Reviewed-on: https://swiftshader-review.googlesource.com/13208Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

66fff4e8

11 Oct, 2017 1 commit

Fix Visual Studio 2017 build of Debug D3D8. · 70844755

authored Oct 10, 2017

Visual Studio 2017 doesn't like configuration elements with empty
content. Remove it to use the default value.

Change-Id: Idc4f281aff145c7e9a143c0a5dbdd54eb4658ee9
Reviewed-on: https://swiftshader-review.googlesource.com/13128Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

70844755

10 Oct, 2017 1 commit

Upgrade SwiftShader solution and projects to Visual Studio 2017. · 8c59ccdc

authored Oct 04, 2017

Chrome now uses Visual Studio 2017 as the default compiler on Windows.
To ensure we maintain compatibility during standalone development, we
should use VS2017 for SwiftShader as well. The 'Community' edition of
Visual Studio 2017 is freely available.

Bug chromium:683729

Change-Id: I3ed1edaeb9fa786b575202ba5b9c86faf1daa3c0
Reviewed-on: https://swiftshader-review.googlesource.com/13048Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

8c59ccdc

06 Oct, 2017 3 commits

Do not assign a location to uniform block members · ec5da193

authored Oct 06, 2017

Uniform block members do not get a uniform location, since they
cannot be set (or get) through regular glUniform* functions. These
are instead always set using uniform buffers.

Bug chromium:763675,chromium:763698,chromium:771639

Change-Id: Icf65eba3faab420c63f70af66f828a786e3fc446
Reviewed-on: https://swiftshader-review.googlesource.com/13068Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

ec5da193

Rename version scripts to linker scripts. · e75d3348

authored Oct 06, 2017

Blaze (Bazel) requires linker dependencies to have a .ld, .lds, or
.ldscript extension. Note that version scripts are just the contents of
the VERSION command in (true) linker scripts. However, the gold linker
used by Android does not support implicit linker scripts (which amend
the default linker script), nor the INSERT command. Therefore these
linker scripts are still actually just version scripts.

https://sourceware.org/binutils/docs/ld/VERSION.html

Bug b/67482470

Change-Id: I3bbe25dab6d916376bdc41bb723279ed2ef62fb0
Reviewed-on: https://swiftshader-review.googlesource.com/13108Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

e75d3348

Fix depth clamping during 'very' early depth test. · 5ba372fa

authored Oct 05, 2017

We perform depth testing before computing scanline invariants, as an
optimization. But it was not taking into account that the
fixed-function depth value may require clamping due to the depth bias.

Bug swiftshader:82

Change-Id: I6f8953f9d060c73b5fe209b8cbad70e7cb7588b4
Reviewed-on: https://swiftshader-review.googlesource.com/13088Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

5ba372fa

03 Oct, 2017 8 commits

Increase coverage of Swizzle test in Reactor · 9d56da27

authored Oct 03, 2017

Test: Improved test passes
Bug: b/67106219
Change-Id: Iab15a2331a91dffaaeb1627a42d0fb88dfa841d0
Reviewed-on: https://swiftshader-review.googlesource.com/13028Tested-by: Casey Dahlin <sadmac@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

9d56da27

Fix for 3D texture sampling · 42e5303d

authored Oct 03, 2017

3D texture sampling did not support width*height > MAX_USHORT(65535).
Changed for 32 bit integer computation for that multiplication to
solve this issue.

Verified with 3D texture related dEQP tests.

Bug b/26105892 chromium:763382

Change-Id: Ifd07278f6263d000620a0b525c07ed4fcbdcf2e7
Reviewed-on: https://swiftshader-review.googlesource.com/12988Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

42e5303d

Enable use of NEON intrinsics on ARM. · 091f350c

authored Oct 03, 2017

Bug b/37496338
Bug b/37495545
Bug b/37496078
Bug b/37496856
Bug b/37496321
Bug b/37496082

Change-Id: I173a296703fcc1f49810742d95ae6abe7c9bcf01
Reviewed-on: https://swiftshader-review.googlesource.com/12868Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

091f350c

Spill whole vector registers to the stack. · f4c4ecab

authored Oct 03, 2017

Subzero assumes that stores and loads to/from stack memory can take an
immediate offset. This isn't true for sub-vector loads and stores. We
can just use regular full vector loads and stores instead.

Bug b/37496321

Change-Id: Iaffd60f8077a4c9d602665421f90a7288ab04050
Reviewed-on: https://swiftshader-review.googlesource.com/13008Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

f4c4ecab

Add test for MulAdd in Reactor · b098c54d

authored Oct 03, 2017

Test: New test passes
Bug: b/37496078
Change-Id: Ieff1b080bdde3f9c86a0531566c8b08d7cdf24fe
Reviewed-on: https://swiftshader-review.googlesource.com/13009Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Casey Dahlin <sadmac@google.com>

b098c54d

Optimize common vector shuffle patterns for ARM32. · f6951fa3

authored Oct 02, 2017

Use VDUP for replicating a single element.
Use VZIP for interleaving vectors.
Use VMOV Dd, Dm for rearranging quadword vectors.

Bug b/67106219

Change-Id: I0de1457454c1db6d467bf870288b7af7cb59ac09
Reviewed-on: https://chromium-review.googlesource.com/695004Reviewed-by: Jim Stichnoth <stichnot@chromium.org>
Reviewed-on: https://swiftshader-review.googlesource.com/12968Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

f6951fa3

Fix vector packing pseudo-instruction. · 416cfb9f

authored Oct 02, 2017

When the first source register is different from the destination
register, but equal to the second source, we need to first narrow
the second source to prevent overwriting data we still need. Similar
when the destination is equal to the first source.

Bug b/37496082

Change-Id: I908a8e125a77ec4bf1eb5eab9e48c6112ee4ca13
Reviewed-on: https://chromium-review.googlesource.com/696032Reviewed-by: Jim Stichnoth <stichnot@chromium.org>
Reviewed-on: https://swiftshader-review.googlesource.com/12949Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

416cfb9f

Adding support for more format/internalformat combinations · 355a5dc1

authored Oct 02, 2017

OpenGLES 3.0 allows for more combinations of format/internalformat
for floating point types. These types were already supported, just
not using the combinations added here.

Bug chromium:763384

Change-Id: I146548c2920799c7ea0d5d537d556ba562708147
Reviewed-on: https://swiftshader-review.googlesource.com/12928Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

355a5dc1

02 Oct, 2017 6 commits

Add test for MulHigh in Reactor · 36fad3cc

authored Oct 02, 2017

Test: New tests pass
Bug: b/37496856
Change-Id: Ifae1f802d61a7d51f6e8f5c135e3c8c67be30125
Reviewed-on: https://swiftshader-review.googlesource.com/12950Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Casey Dahlin <sadmac@google.com>

36fad3cc

Fix emulation of Short to Byte saturation. · 7f301812

authored Oct 02, 2017

We weren't clamping the value when less than zero.

Bug b/37496082

Change-Id: I3170d14a622f8571f0142dd4ce80f96617c7e0aa
Reviewed-on: https://swiftshader-review.googlesource.com/12948Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Casey Dahlin <sadmac@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

7f301812

Fix vector packing regression. · 75b9c1c8

authored Oct 02, 2017

When SSE4.1 isn't available, we were infinitely calling PackUnsigned()
recursively.

Bug b/37496082

Change-Id: Ie1fa8150d64740776c5b80baf07d997dde9d51be
Reviewed-on: https://swiftshader-review.googlesource.com/12929Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Casey Dahlin <sadmac@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

75b9c1c8

Add test for PackSigned/PackUnsigned in Reactor · 1165812d

authored Sep 29, 2017

Test: New tests pass
Bug: b/37496082
Change-Id: I4a0aae14318f03b5ce59f12f7542db13270f52ab
Reviewed-on: https://swiftshader-review.googlesource.com/12848Tested-by: Casey Dahlin <sadmac@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

1165812d

Fix for integer modulo operations · 2895810b

authored Oct 02, 2017

Integer division already had this modification, to avoid
division by 0, but integer modulo hadn't been modified
to match the other fix, which is now done here.

Bug chromium:763435

Change-Id: I40f4ed9f1c4b5889ddf47abc1bb7c70c21cbd7b8
Reviewed-on: https://swiftshader-review.googlesource.com/12908Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

2895810b

Implement vector intrinsics for ARM32. · 675e15b3

authored Sep 27, 2017

MultiplyAddPairs is implemented using VMULL+VPADD.
MultiplyHighSigned/Unsigned is implemented using VMULL+VSHRN.
SubVectorLoad/Store is implemented using VLDR/VLD1/VSTR/VST1.
VectorPackSigned/Unsigned is implemented using two VQMOVN.

Bug b/37496078
Bug b/37496856
Bug b/37496321
Bug b/37496082

Change-Id: I141fd901d53da24ce780f503dc7ad17b94fc6ba8
Reviewed-on: https://chromium-review.googlesource.com/693049Reviewed-by: Jim Stichnoth <stichnot@chromium.org>
Reviewed-on: https://swiftshader-review.googlesource.com/12709Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

675e15b3

29 Sep, 2017 1 commit

Add test for Unpack in Reactor · 4e759e4e

authored Sep 29, 2017

Test: New test passes
Bug: b/67106219
Change-Id: Ib21f73d312d39cf2b3aa15a11d2a207885a58978
Reviewed-on: https://swiftshader-review.googlesource.com/12828Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Casey Dahlin <sadmac@google.com>

4e759e4e