Skip to content

S
swiftshader
Switch branch/tag
  1. 10 Feb, 2016 7 commits
  3. 09 Feb, 2016 3 commits
  5. 08 Feb, 2016 1 commit
  7. 07 Feb, 2016 1 commit
    • Subzero: Clean up some uses of *_cast<>. · 2d6c8267
      Jim Stichnoth authored 
      Some casts to size_t for use as array indexes are simply unnecessary.

Some explicit declaration types are changed to "auto" to avoid redundancy with the static_cast type.

A few llvm::dyn_cast<> operations are changed to llvm::cast<>, and vice versa.

A few explicit declaration types are changed to "auto" when used with llvm::cast<> and llvm::dynamic_cast<>.  Some of these were missed during an earlier cleansing because of multi-line issues.

There are still a few opportunities related to Variable register numbers, but they are ignored for now because they are being addressed in another CL.

BUG= none
R=jpp@chromium.org

Review URL: https://codereview.chromium.org/1674033002 .
  9. 05 Feb, 2016 4 commits
    • Subzero: Fix a mul lowering error. · 28df6bad
      Jim Stichnoth authored 
      The low-level mul instruction may produce results in a register pair where one register is the explicit dest of the instruction, and the other register is defined through a FakeDef.  If the FakeDef portion is ultimately unused, the FakeDef gets dead-code eliminated, and the register allocator doesn't know that the mul instruction affects the other register.

On x86, this can silently produce incorrect code.  On ARM, the emitter complains that the explicitly represented second dest variable does not have a register.

The fix is to add a FakeUse of the FakeDef'd register.  Unfortunately, this prevents the low-level mul instruction from ever being dead-code eliminated, but that's probably OK because it should have been eliminated at the high level.

BUG= none
R=eholk@chromium.org

Review URL: https://codereview.chromium.org/1678523002 .
    • Subzero: Improve an error message. · 45bec54f
      Jim Stichnoth authored 
      Add the variable name and function name to the fatal error message.

BUG= none
R=kschimpf@google.com

Review URL: https://codereview.chromium.org/1677593003 .
    • Subzero: Cleanup Inst==>Instr. · 8cfeb69e
      Jim Stichnoth authored 
      In the beginning, Ice::Inst was called IceInst, and patterns like "IceInst *Inst = ..." made perfect sense.

After the Ice:: name change, "Inst *Inst = ..." continued to compile, mostly.

However, shadowing a type name is clumsy and newer code tends to use "Inst *Instr", so we might as well switch all the instances over.

Some are still called "I" and those are left alone.

BUG= none
R=kschimpf@google.com

Review URL: https://codereview.chromium.org/1665423002 .
    • Clean up assembling MOV instructions in the integrated ARM assembler. · 282d7afd
      Karl Schimpf authored 
      Flattens out MOV's emitIAS methods making it easier to see valid types
for source/destination of the move.

BUG=None
R=stichnot@chromium.org

Review URL: https://codereview.chromium.org/1665323002 .
  11. 04 Feb, 2016 4 commits
  13. 03 Feb, 2016 3 commits
  15. 02 Feb, 2016 9 commits
  17. 01 Feb, 2016 5 commits
  19. 29 Jan, 2016 3 commits