The error happens when a RWTexture is used in shader. However, there is
no resource binding to it. We should clear the corresponding UAV in case
the previous view type is a bufer not a texture.

Meanwhile, this patch removes clearSRVs/clearUAVs since we use
unsetConflictingSRVs/unsetConflictingUAVs to do the similar thing.

Bug: angleproject:3512, angleproject:3548
Change-Id: I01752bb9bc6aca5b767599639c4dc613b4e2e2d2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1662017Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

Bug: 891996
Change-Id: I64381bea1bcbddb76748dd03c7caaf2f5360e1ed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1674258Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/7c294608ca19..df86bb44fe47


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@df86bb44fe47

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=jonahr@google.com

Change-Id: I04e0b7ee52f1c981eb42d20dcd045eff4812c1f1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1673826Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

We could expand this functionality in the future to only update the
pipeline when a signficiant bit of pipeline state changes. For now this
is mostly a proof of concept.

Significantly improves performance in the textures microbenchmark.

Bug: angleproject:3117
Change-Id: I3957dd2f08d7d89694f94ddbe45eeeeb620bac0a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1650790Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

The call to abi::__cxa_demangle() with too small of a char[] can cause
segfaults or hangs.   This change increases the array from 256 to 4096.

Bug: angleproject:3553
Test: Verify validation layers don't segfault/hang
Change-Id: I6704ff00bfab62c99eb288f803ccda35a037dd9d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1670580Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

In GLES 3.0, depth textures where changed to behave like RED textures,
but in GLES 2.0 with ARB/OES_depth_texture, they were treated as
luminance textures.
This change produces the expected behavior on GLES 2.0 for the GL
backend and on GLES 3.0 for the Vulkan backend.

Bug: angleproject:3540
Change-Id: Iad6b4e03cf947b27eb97dbb10419bc8bcdb11024
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1666363Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: James Dong <dongja@google.com>

Android devices will often fail to allocate textures this large and it is
prefereable to return an error from ANGLE instead of losing the context
due to an out of memory error.

This mirrors the limits Chrome applies with the max_texture_size_limit_4096
and max_msaa_sample_count_4 workarounds that are broadly applied to Android.

BUG=882580

Change-Id: I63890baa8712f13b37c607fa475432e67e9384a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1351357
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

This workaround is always enabled in Chrome, do the same in ANGLE.

BUG=882580

Change-Id: I2c01f34a589b07bd0035d7408be884f7a51b1706
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1666699Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Bug: chromium:977330
Change-Id: I25b2ac11b8ee9b5c084bd828a4d0ddf2b8c1b3eb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1670092
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Issue exposed by a transform feedback test.  Since we already create a
scissor to match the viewport (be it 0-sized or not), we can create the
Vulkan viewport with a small width/height if they are 0, as that's not
allowed by Vulkan.

Bug: angleproject:3205
Change-Id: Ib23d8b9f5e84447be2c4b7e8aff805e7d9e57323
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1665352
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

The ANGLE Vulkan backend is now thread safe for non-share group contexts. This
means that a global GL lock only adds overhead for most use cases.

Remove the angle_force_thread_safety gn argument.

BUG=angleproject:2464

Change-Id: Ic6ba89e18b46e5dd72aa83d0f409097441fcca3a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1635749
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>

Implemented as part of an experiment.  Allows easier buffer-related
testing by providing a quick way of filling the buffer with dummy data.

Bug: angleproject:3205
Change-Id: Ice8cfd0c2566c91a5fb10aaea57985d671d0e7b7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1665351
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2090d7a2d26c..7c294608ca19


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@7c294608ca19

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=jonahr@google.com

Change-Id: I92f99e50eaa01782b74f311b1f0d77d4580ab9fa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1670005Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Bug: chromium:973992
Change-Id: Iee5cf6a4b6b0469b81cd0c1a7cd0ebea05060580
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1670009Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

The issue occurs that binds the same buffer and calls glDrawElements
with the same indices. The offset has been reset in the
VertexArrayVk::syncState(), but it doesn't check the actual value
in the ContextVk::setupIndexedDraw().
Also corrected case where update via BufferSubData wasn't being
sent to the HW.

Bug: angleproject:3362
Change-Id: I0f7d2fc162bc8f1c36cb09ba689fd27b482b9035
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1666345
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

They can be re-enabled with the angle_enable_trace option.
Prevents validation errors from being output in NoFixture tests,
as the default platform methods aren't overridden.

Bug: angleproject:3525
Change-Id: I77342230b6c7cd167cfc3169f09d4e74b4579244
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1669848Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Since a6242e4d ("Vulkan: Support submitting multiple semaphores"),
we can submit up to 2 semaphores at a time, but pWaitDstStageMask
is still a single value. Change it to an array of two elements to
prevent an out of bounds access.

Bug: angleproject:3289

Change-Id: I5147802ce350af7b78dbf54cfa4a9519dd495f01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1666347
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Implement BufferVk::copySubData().

Bug: angleproject:3194
Test: dEQP-GLES3.functional.buffer.copy.*
Test: dEQP-GLES3.functional.negative_api.buffer.copy_buffer_sub_data
Test: angle_end2end_tests BufferDataTestES3
Change-Id: I220cd490eb1eb799604e217b3e377af3fd431d97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1648669
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This captures a bit more information about where the call time goes
during a flush. It can show at least on desktop NVIDIA that we spend a
fair amount of time in vkQueuePresentKHR.

Bug: angleproject:3117
Change-Id: I2d0195b9338bcac80e8dd8cfb550402271f286f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1650787
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

We can use the DIRTY_BIT_IMPLEMENTATION internal dirty bit in the
gl::Texture class to force calls to ContextVk::syncState. In syncState
we can ensure we call ensureImageInitialized before we get to the
ContextVk. This in turn means we can remove some of the command graph
breaks from TextureVk.

We need to make sure the dirty bits are propagated to EGL Image
siblings with this method. This fixes a potential implementation issue
with EGL images with the GL back-end.

Also makes a state change test a little better by removing some of the
VAO and program init calls before the draw.

Improves perf on the texture change microbenchmark by 12.5%.

Bug: angleproject:3539
Bug: angleproject:3117
Change-Id: I2b5481690801fa98f859a6c02e3f4b974590cd3d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1663839
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Requires that we update the TRACE_EVENT macros to accept a platform as
an argument. The refactor isn't complete. In order to finish we'd need
to ensure we have the Display's PlatformMethods available at all sites.

Unblocks adding trace events directly in the perf tests.

Bug: angleproject:1892
Bug: angleproject:3117
Change-Id: Iee0ca086ccfe23acab3fc186fb042f018711a94c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1664794
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:3547
Change-Id: I83e491fb0121f0a8473630ead6e48b062ae06da5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1668234Reviewed-by: Jamie Madill <jmadill@chromium.org>

The keys in vk_format_map.json were incorrect.  The format table
generation script is enhanced to give an error in such a case.  This
revealed a number of entries with no corresponding angle format, which
are also removed.

Bug: angleproject:2898
Bug: angleproject:3190
Change-Id: I32caf2d2a8abb6f76b25436725670a8e84d576fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1666700
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

By using the helper isTransformFeedbackActive* functions.

Bug: angleproject:3205
Change-Id: I50b3e9db427da9f65c3e2b50d7847464e8c28202
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1665353
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

BUG=angleproject:1944

Change-Id: I123bb4f97f947272364c765b18d11dba476eee01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1666696
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Corrects texture swizzle in Vulkan backend. Previously user-supplied
swizzle was applied before internal swizzle; this change applies the
internal swizzle first, causing the correct behavior.

Also recreates image views when swizzle is dirty.

Test: ./angle_deqp_gles3_no_gtest --deqp-egl-display-type=angle-vulkan -n 'dEQP-GLES3.functional.texture.swizzle.*'
Test: ./angle_end2end_tests --gtest_filter='SwizzleTest.*/ES3_Vulkan'

Bug: angleproject:3212
Change-Id: Ie2c44b479da5c19ba744ace7562a73c944f97a49
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1660909
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/11805e41d992..f9d08a25fbe1


Created with:
  gclient setdep -r ./third_party/glslang/src@f9d08a25fbe1

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=jonahr@google.com

Change-Id: Iaa82e2e9fadbbd02b8dae865d61c7f1217746a8e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1666931Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

D3D11 cannot allow the same (sub)-resource bound as both
a SRV and an UAV at the same time. Unset conflicting SRVs
and UVAs between render pipeline and compute pipeline.

Bug: angleproject:3152
TEST=angle_end2end_tests.ComputeShaderTest.*

Change-Id: I9cb8b902edbf987166a57af314af6b21a6874998
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1576504Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Xinghua Cao <xinghua.cao@intel.com>

This this was missed because it doesn't add its own enum value and
instead reuses GL_NONE.

Bug: chromium:976374
Test: chrome --enable-features=UseSkiaRenderer,UiGpuRasterization \
  --enable-gpu-rasterization \
  --enable-oop-rasterization \
  --use-vulkan=native \
  --use-gl=angle \
  --use-angle=vulkan

Change-Id: I73437211fef3253801e899cb6e50a8e18865cc65
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1665329
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This patch adds the support of overwriting angle_root to the one
defined outside ANGLE, which is useful for other projects which
intend to configure ANGLE in their GN builds.

Bug: angleproject:3263
Change-Id: I70a56a3d0afdca2eb66fb9619f0dd4d3efc58dee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1522912
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This reverts commit 9aa865a6.

Reason for revert: Seems to be causing crashes on Android in glmark2.
Might also be responsible for a perf regression.

Bug: angleproject:3542

Original change's description:
> Vulkan: Add missing command pool reset.
> 
> We were still calling destroy in checkCompletedCommands. We can
> instead call reset.
> 
> May not significantly impact performance.
> 
> Bug: angleproject:3489
> Change-Id: I61a2cb154faac56dc78a49678dd822d81ce16ad2
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1647029
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Tobin Ehlis <tobine@google.com>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

TBR=tobine@google.com,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:3489
Change-Id: Icb0e99f18ecab09798654605973958bd2b263002
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1665748Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Also update doc.

Bug: chromium:973992
Change-Id: I59a27935d2bcd438df025945b885384b1d5b0792
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1665328
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

The Android SurfaceTexture API has to be initialized with a texture id
which Chrome has to query from an ANGLE external texture. It also
rebinds and sets the texture dimensions on calls to
SurfaceTexture.updateTexImage so ANGLE must be notified about these
changes so that state tracking and validation continue to function.

BUG=967410

Change-Id: I92e9077f75835b088da3a8caffb3ff40e9ad0361
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1630293
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

NVIDIA Shield do not implement Vulkan, which is used to populate
vendor IDs in SystemInfo. The vendorIDs are used to check IsNVIDIA().
This CL adds a workaround so IsNVIDIA() returns true for NVIDIA
Shield.

Bug: angleproject:3541
Change-Id: Ib36dd376207163acfc8d3a0e341f07a7d6aa3122
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1663080
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Implement EGL_ANGLE_image_d3d11_texture extension.  Images created with
this extension might not be renderable based on bind flags and resource
usage of the client provided texture in which case attaching them to a
framebuffer won't succeed.

The intended use case is to bind the front and back buffers of a swap
chain to GL textures that can be used for rendering in the case of the
back buffer and as a shader input for the front buffer.

Bug: chromium:939655
Change-Id: Ic3328e831880292217b88be84740740df6031fa6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1646732
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

A function was renamed which broke the platformMethods table strings.
This CL reverts the rename (originally from crrev/c/1660952)

Bug: angleproject:1621
Change-Id: I8121a4956ba1d3e3c5036f72f6f1fdf5509dc491
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1664792Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

It was only used in exactly one instance in VertexArray. Instead we can
cache a bool and avoid needing to pass it around.

Will make signaling dirty easier in the Vulkan back-end.

Bug: angleproject:3539
Change-Id: Ia570aec051a24a5280df49edc4345c54022b46ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1663838Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

SPIRV-Tools roller did not roll the correct headers version.

Change-Id: Ifa1c9e2ee92e11a5e84ba78249e422884f5b6582
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1663840Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

The removed function had incorrect Windows implementation,
the return value was checked incorrectly.

Last use was removed in commit 573f76b3
https://chromium-review.googlesource.com/c/1042785

Bug: angleproject:2532
Change-Id: I66907fcb33041b097062208d53ca88752c05f9cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1664153Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Kimmo Kinnunen FI <kkinnunen@nvidia.com>

Allow 24-bit depth as a valid Renderbuffer format.

Bug: angleproject:3229
Test: angle_end2end_tests --gtest_filter=DepthStencilFormatsTest.DepthBuffer/*
Change-Id: I166639ec0e000595dc55848e4b8b7bef627b6471
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1661050
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>