This crash could occur when saving and loading a program with UBO
bindings that was never used in a draw operation. The fix is to
ensure the D3DLinkedUniforms are properly initialized before we
save the program binary.

BUG=angleproject:1637

Change-Id: I9691e375d19dc628f34f351ae94b68bd0f2f76b8
Reviewed-on: https://chromium-review.googlesource.com/422665
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

The OVR_multiview and OVR_multiview2 extensions add gl_ViewID_OVR to
shaders. gl_ViewID_OVR can be translated either as is in GLSL output
or as a uniform by setting the SH_TRANSLATE_VIEWID_OVR_AS_UNIFORM
compiler flag.

If WebGL output is selected, the shaders will be validated according
to proposed rules in the WEBGL_multiview spec.

BUG=angleproject:1669
TEST=angle_unittests

Change-Id: I19ea3a6c8b4edb78be03f1a50a96bfef018870d0
Reviewed-on: https://chromium-review.googlesource.com/422848Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

BUG=angleproject:1390

Change-Id: I7e8eb1f7924014bbde38269ef0fd0f7d65639083
Reviewed-on: https://chromium-review.googlesource.com/420518
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1523
BUG=chromium:668223

Change-Id: I0726769c938fdfd50af0fad1cef1746d4af2a589
Reviewed-on: https://chromium-review.googlesource.com/422084
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

libEGL should use libGLESv2 for EGL implementation,
to prevent libANGLE global variables being duplicated.

BUG=angleproject:1660

Change-Id: I84c1e22fcce8f4a21acfb1fcde0c84ebd77204f8
Reviewed-on: https://chromium-review.googlesource.com/422574Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

This reverts commit e2d0e41f.

Reason for revert: The driver on these machines has been rolled back to the previous version, so these tests are expected to pass again.

Original change's description:
> Supress failures for the 16.12.1 Windows AMD D3D11 driver.
> 
> BUG=676333
> 
> Change-Id: I2c29b3dd4ee00bb68575371fe3b1320aad087575
> Reviewed-on: https://chromium-review.googlesource.com/422479
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> 

TBR=geofflang@chromium.org
BUG=676333
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: Ia2952ef55002201dc8c34a4f45c2483bffbf6f43
Reviewed-on: https://chromium-review.googlesource.com/423126Reviewed-by: Kenneth Russell <kbr@chromium.org>

BUG=chromium:675997

Change-Id: I3058892b80ccf61664d023419651fd4aa1dfec2a
Reviewed-on: https://chromium-review.googlesource.com/423111Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Includes a fix for Clang call cast conversion warning.

BUG=chromium:676217

Change-Id: I1b8bf8698714f4280aea52415ae5f96272a2219a
Reviewed-on: https://chromium-review.googlesource.com/422440
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=None

Change-Id: I07ebad06057671791c2e0524dc3af2da5f884582
Reviewed-on: https://chromium-review.googlesource.com/422910Reviewed-by: Geoff Lang <geofflang@chromium.org>

BUG=676333

Change-Id: I2c29b3dd4ee00bb68575371fe3b1320aad087575
Reviewed-on: https://chromium-review.googlesource.com/422479Reviewed-by: Geoff Lang <geofflang@chromium.org>

With this CL we have the ability to create Vulkan test configs and run
basic tests, although the only thing that works is creating a Vulkan
Renderer using the extension.

BUG=angleproject:1319

Change-Id: I8ad17bba01241334be7da16e68fea38762ca6a20
Reviewed-on: https://chromium-review.googlesource.com/367750
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

BUG=chromium:675819

Change-Id: I7d143ba51bb16f28b145aa2b0410929d29e0b464
Reviewed-on: https://chromium-review.googlesource.com/422493Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

BUG=None

Change-Id: I28af0d2be5ef545e78b8283d43d14078c0d1b62a
Reviewed-on: https://chromium-review.googlesource.com/422491Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1523
BUG=chromium:668223

Change-Id: Ic89c476a6c95824069772e22ede596ba85ac8859
Reviewed-on: https://chromium-review.googlesource.com/422347
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

The usage of checked numerics showed has a big hotspot in ValidateDrawAttribs.
BUG=angleproject:1671
BUG=chromium:674143

Change-Id: I96392e099b2257e465fb47e1c96f9aa1f54a89ba
Reviewed-on: https://chromium-review.googlesource.com/422428
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

The uniforms check was not correctly validating vector count instead
of uniform count. Fix this, and reduce the maximum maxtrix uniforms
to fix a crash on the perf bots.

BUG=angleproject:1385
BUG=angleproject:1390
BUG=angleproject:1671

Change-Id: I261477c33639ed516ff6a29b38ab87f89309a7f1
Reviewed-on: https://chromium-review.googlesource.com/422533Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

When the tiny depth texture would get re-created on change, it was
not freeing any cached SRVs which were pointing to the old tex.
Fix this by erasing the cache entry if the texure is recreated.

Also include a test which hooks into the workarounds to force
testing on every platform.

Also narrow the workaround to only apply to depth/stencil textures
which use these mips in GL, rather than D3D, where we always create
a full mip chain.

BUG=angleproject:1664

Change-Id: If0ac396b8847e1bf9b50165e5332da573e9bb3e4
Reviewed-on: https://chromium-review.googlesource.com/421567
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

Lots of these tests aren't actually testing malformed shaders, so the
name was misleading. ShaderValidationTest reflects the content of the
tests better.

Some test classes that needlessly used different API spec versions are
also merged.

BUG=angleproject:1673
TEST=angle_unittests

Change-Id: Ib842af153a09d3887f9bb857709fd0cd29bcc9c4
Reviewed-on: https://chromium-review.googlesource.com/422368Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

This integrates the build files for the loader SDK, and tests the
compilation by calling InitInstance. There's no current way to
test the runtime behaviour since there's no way for the tests to
initialize the Vulkan back-end, that will come in the next CL.

BUG=angleproject:1319

Change-Id: Ia8bf96ca068eaf40744c9753b59ffaaa5ada8a73
Reviewed-on: https://chromium-review.googlesource.com/367519
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

We're finding that D3Dcompile is being called with a null
compiler handle. This means at some point we successfully linked
a program, using a valid compiler handle, and likely we went
through some traumatic event like a GPU device lost. This unloaded
the compiler DLL and hence leads to a null deref.

It's not clear how this is happening since a device lost should
trigger a restart of the browser process in all cases with Chrome,
but this should fix the NULL deref and lead to a user-visible
program link error.

BUG=chromium:671162

Change-Id: Ibf85f19d4f099d2f00921c230ee0a52b46bfd8cf
Reviewed-on: https://chromium-review.googlesource.com/422553Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

We will roll the DEPS through to Chromium first, so avoid the problem
where DEPS rolls in ANGLE break the CQ (http://crbug.com/643346)

We will follow up with build files after this CL makes it into Chrome.
Likely we won't roll Vulkan DEPS until the above issue is fixed.

BUG=angleproject:1319

Change-Id: I4121143887a614667affe750185d1bc7b8474fa7
Reviewed-on: https://chromium-review.googlesource.com/419720
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

The test class provides facilities for parsing test shader source into
an AST and determining compile status. Compilation flags change for
some of the tests, but this should only have a minor effect on code
coverage - mostly affecting non-core parts such as intermediate
output.

BUG=angleproject:1673
TEST=angle_unittests

Change-Id: I7d0900ef490e021272a27c4b0c938bfee02abf39
Reviewed-on: https://chromium-review.googlesource.com/422367Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

This test also adds a mode which controls if the uniform data changes
frame-to-frame. Could be useful when we test removing redundant
data checking.

BUG=angleproject:1385
BUG=angleproject:1390
BUG=angleproject:1671

Change-Id: I936702b83f3d7cd97918542b06ecc1372884b412
Reviewed-on: https://chromium-review.googlesource.com/422348Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

The Error should be consumed in the Context call.

BUG=angleproject:747

Change-Id: I5daae602e8f6c7feed89573c6c9387c295ba9a32
Reviewed-on: https://chromium-review.googlesource.com/421258Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Use the same kind of interface for reporting preprocessor errors as
for reporting regular compiler errors, and make global errors like
having too many uniforms also go through Diagnostics. Also don't
create std::string objects unnecessarily.

Includes cleanups of some dead code related to reporting errors.

BUG=angleproject:1670
TEST=angle_unittests

Change-Id: I3ee794d32ddeec1826bdf1b76b558f35259f82c0
Reviewed-on: https://chromium-review.googlesource.com/421527Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

This will be accessible to the Impl, so they won't have to store a
copy of the pointer.

BUG=angleproject:1319

Change-Id: I298a11a243d3d32f4c885273e55162e6862f3e16
Reviewed-on: https://chromium-review.googlesource.com/419697
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:1523
BUG=chromium:668223

Change-Id: I2dffa3c92dd32e384d3b3109084420650ca7f795
Reviewed-on: https://chromium-review.googlesource.com/421113Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

BUG=chromium:668223

Change-Id: I2068370f3e6963f297d0cb6545c40abf84d543ce
Reviewed-on: https://chromium-review.googlesource.com/421092
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

A va_list is undefined after it has been used by vsnprtinf. This was
causing crashes in the GL backend when the driver was returning big
info logs.

BUG=chromium:668223

Change-Id: I444194ecce2846960c8a27f20f322f7099c651e5
Reviewed-on: https://chromium-review.googlesource.com/421271Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

In new back-ends (Vulkan) this will allow us to avoid storing a ref
to the Renderer in the Surface class.

BUG=angleproject:1319

Change-Id: I3b3f50893070d2993e4e91dd82ee539a083b3727
Reviewed-on: https://chromium-review.googlesource.com/419837
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Otherwise when trying to use a DEPTH texture for DEPTH_STENCIL,
attach(nullptr) gets called but the FramebufferAttachment still returns
true when isAttached is called.

BUG=angleproject:1523

Change-Id: I30b78aff619eb6cd63e0befac886bddc177a2e58
Reviewed-on: https://chromium-review.googlesource.com/418403
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

This makes error messages more consistent. It was not clear what was
supposed to go to the extraInfo parameter, and previously it was
mostly being misused, resulting in poorly formatted error messages.
Sometimes the order of parameters to the diagnostic functions like
error() and warning() was wrong altogether. The diagnostics API is
simpler when there's only the "reason" and "token" parameters that
have clear meaning and that are separated by consistent punctuation
in the output.

Fixes error messages like

"redifinition interface block member"

to be grammatically reasonable like the rest of the error messages. For
other error messages, punctuation is added to make them clearer. Example:

"invalid layout qualifier location requires an argument"

is changed to

"invalid layout qualifier: location requires an argument".

Extra spaces are also removed from the beginning of error messages.

BUG=angleproject:1670
BUG=angleproject:911
TEST=angle_unittests

Change-Id: Id5fb1a1f2892fad2b796aaef47ffb07e9d79759c
Reviewed-on: https://chromium-review.googlesource.com/420789Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

BUG=angleproject:1671
Change-Id: I4b13113b41e6d429f771d7a405fd62ef61064c6c
Reviewed-on: https://chromium-review.googlesource.com/420853Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

Encapsulate all of the implementation inside the .cpp file, and pass
just the diagnostics object instead of the whole ParseContext to the
validation function.

BUG=angleproject:1670
TEST=angle_unittests

Change-Id: I89713b63e554dbedaa12b2270208f1fac496c54e
Reviewed-on: https://chromium-review.googlesource.com/420788Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

BUG=angleproject:1463

Change-Id: I9f3e1190cc42e0cb37d80b94c35b61e88203dd32
Reviewed-on: https://chromium-review.googlesource.com/420475Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Change-Id: If88ac23ef5dbb67176bcc4b111100a0126269d08
Reviewed-on: https://chromium-review.googlesource.com/420474Reviewed-by: Jamie Madill <jmadill@chromium.org>

The patch decouples the list of unmangled built-ins' names into levels
based on the ESSL version they are from. This is required
because ESSL31 and above built-ins' names should not conflict with
user-declared functions in ESSL3 shaders.

BUG=angleproject:1666
TEST=angle_unittest

Change-Id: I731918a058629c7b6d9d15eb7eac19ce47280315
Reviewed-on: https://chromium-review.googlesource.com/420324Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

How to build and run tests

BUG=angleproject:1607

Change-Id: I6d5c341c32a37535d59e8dae508173b5ab6664d6
Reviewed-on: https://chromium-review.googlesource.com/419798
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1637

Change-Id: I411252fa719f79c26795522ea5f1504ef460c6c0
Reviewed-on: https://chromium-review.googlesource.com/420306Reviewed-by: Jamie Madill <jmadill@chromium.org>

This seems to fail on the Nexus 6P, and possibly 5X. Does not
seem to affect some other devices.

BUG=angleproject:1660

Change-Id: I1d456b2033fb6b2a664ac24ea0a3f7ff160922ab
Reviewed-on: https://chromium-review.googlesource.com/419856Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>