Commits · ef599fb0f431ebe030d066edd710305e833ff9e7 · Chen Yisong / angle

13 Feb, 2020 7 commits

Vulkan: Fold glClear into draw call when command graph is disabled · ef599fb0

authored Feb 11, 2020

This sets ContextVk::mRenderPassCommandBuffer properly when glClear get
called so that it wonr end up start anotyer render pass during setupDraw
call.

Bug: angleproject:4395
Change-Id: Id2110719ad4d70b4c410062466d32381fb5e1f88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050966
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

ef599fb0

Capture/Replay: Track and restore mapped buffer data · 94c19142

authored Feb 12, 2020

When a buffer is mapped writable by the host, we need to
track its final contents, and then restore them during replay.

This implementation just blindly captures the whole mapped
range if writable, and can be optimized in the future.

This change renders the moving billboards in Manhattan correctly.

Test: First 500 frames of Manhattan and TRex
Bug: angleproject:4091
Change-Id: I5f7775235f569efb264bde679fd3045d7012c622
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053512
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

94c19142

Vulkan: expose ANGLE_compressed_texture_etc · b79b57e0

authored Feb 13, 2020

Bug: angleproject:4399
Change-Id: I51cd304c8726c985c5f70b78bd98c8af19d2a80d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053889Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

b79b57e0

Provide default implementation of rx::DisplayEGL · e82ab75a

authored Feb 12, 2020

Will allow to use EGL instead of GLX on X11.

Meant to be used on modern EGL so it requires the extensions
EGL_KHR_no_config_context and EGL_KHR_surfaceless_context.
This keeps the default implementation simple (no pBuffer
fallback)

Also provide simple WorkerContextEGL.

Bug: angleproject:4328
Change-Id: I825c6998e4a3727a13e533ede3d9fb1820edc804
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2031699
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e82ab75a

Roll third_party/vulkan-tools/src 45b9d01815d9..db0a1553991d (1 commits) · 77a5100d

authored Feb 13, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/45b9d01815d9..db0a1553991d

git log 45b9d01815d9..db0a1553991d --date=short --first-parent --format='%ad %ae %s'
2020-02-12 charles@lunarg.com vulkaninfo: new vkconfig_output backdend

Created with:
  gclient setdep -r third_party/vulkan-tools/src@db0a1553991d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I0e52a00d48b755401d759170be99689d682e7c3d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053853Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

77a5100d

Roll third_party/vulkan-validation-layers/src d439b17da022..30794ac2f91b (12 commits) · 1f12c947

authored Feb 13, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d439b17da022..30794ac2f91b

git log d439b17da022..30794ac2f91b --date=short --first-parent --format='%ad %ae %s'
2020-02-12 mikes@lunarg.com scripts: Rename src argument for safe_* copy funcs
2020-02-12 mikes@lunarg.com scripts: Only use safe_* types when needed
2020-02-12 mikes@lunarg.com scripts: Handle arrays with const/non-member len
2020-02-12 shannon@lunarg.com scripts: Fix codegen infinite recursion
2020-02-12 s.fricke@samsung.com tests: Add test for 01004 and 02652
2020-02-12 s.fricke@samsung.com layers: Add support for 01004 and 02652
2020-02-12 mark@lunarg.com tests: Remove non-API range enums
2020-02-12 mark@lunarg.com layers: Remove non-API range enums
2020-02-12 mark@lunarg.com layers: Remove deprecated log_msg() function
2020-02-12 mark@lunarg.com layers: Removed last log_msg calls
2020-02-12 s.fricke@samsung.com tests: Added test for 00624 and 00625
2020-02-12 s.fricke@samsung.com stateless: Added support for 00624 and 00625

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@30794ac2f91b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: Ibe4ff7d019861e0e6db0aae06637b79dc04d8e49
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053852Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

1f12c947

Roll third_party/SwiftShader 6cbb02e0dc93..ac4e1d236088 (2 commits) · d4be305e

authored Feb 13, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/6cbb02e0dc93..ac4e1d236088

git log 6cbb02e0dc93..ac4e1d236088 --date=short --first-parent --format='%ad %ae %s'
2020-02-12 gmouse@google.com Add missed symbol __aeabi_idivmod for Android.
2020-02-12 swiftshader.regress@gmail.com Regres: Update test lists @ 6cbb02e0

Created with:
  gclient setdep -r third_party/SwiftShader@ac4e1d236088

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I3f0ef9910eafd7b340aa11c9a4cd0fd1a0849142
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053854Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

d4be305e

12 Feb, 2020 11 commits

Vulkan: Disable command graph by default. · 74ab0bff

authored Feb 12, 2020

Also removes the angle_end2end_tests feature override.

Bug: angleproject:4029
Change-Id: I0d0bd087fc2143360185592d9fa1238a9bafc55d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046054
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

74ab0bff

Fix vpython caching in trigger.py script. · 9e4cf7ca

authored Feb 12, 2020

Several necessary CPID packages were missing from the swarming params.
Add these based on the packages in mb.py:

https://chromium.googlesource.com/chromium/src/tools/mb/+/2192df66cd0ed214bcfbfd387ad0c5c8c0a21eb1/mb.py#586

Allows testing the ANGLE test launcher without modifying recipes.

Bug: angleproject:3162
Change-Id: I3e84bf0d3fd92aed623a918b4d9cfd53f51f2dee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050427
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

9e4cf7ca

Test Runner: Increase default timeouts. · 593706bc

authored Feb 10, 2020

In particular the Debug timeout was not generous enough. Increase the
test timeout to 20 seconds in Release and 60 seconds in Debug. Increase
the batch timeout to 240 seconds in Release and 600 seconds in Debug.

Bug: angleproject:3162
Change-Id: I0bd0ea18cb5cdab005143b8deed9500d9d2e8ea1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2047415
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

593706bc

Move dither from blend state to rasterizer state · caf7becc

authored Feb 11, 2020

Dither is technically not a part of blend state so it was removed from there as a first step towards exposing OES_draw_buffers_indexed (that defines independent blend state for each draw buffer).

Rasterizer state seems to be the closest (although also not accurate) place for it to keep code changes to a minimum. ANGLE's D3D11, Vulkan, and Metal renderers ignore dithering altogether.

Bug: angleproject:4394
Change-Id: Ib138624b9218851d18cd63e2033e8e8ac8ca71d9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050464Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

caf7becc

Roll deqp to get some test fixes · 92b00ca8

authored Feb 10, 2020

Bug: angleproject:4107
Change-Id: Icfb6b3fc075b9febf486386c26d90b4020ace9ee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2047388Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

92b00ca8

Update comment to reflect changes in · bd2f2575

authored Dec 06, 2019

Bug: angleproject:4087
Change-Id: I3c26fae4fde24308fa877256c190a5bb47fe1a82
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954568Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

bd2f2575

Fix compressed formats validation with TEXTURE_3D · 33b1e31e

authored Feb 08, 2020

Bug: angleproject:4385
Change-Id: Ibc1b482ec851d8076aacad84ab67fe20a745c122
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2045512
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

33b1e31e

Roll third_party/spirv-tools/src fe10239f92f4..6c218ec60b5f (3 commits) · cf03c7ae

authored Feb 12, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fe10239f92f4..6c218ec60b5f


Created with:
  gclient setdep -r third_party/spirv-tools/src@6c218ec60b5f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I181af12ac2a95d8619b581c8734f38ab63e09273
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050005Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

cf03c7ae

Roll third_party/vulkan-validation-layers/src b60b35843e66..d439b17da022 (38 commits) · 7adc9736

authored Feb 12, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b60b35843e66..d439b17da022

git log b60b35843e66..d439b17da022 --date=short --first-parent --format='%ad %ae %s'
2020-02-12 s.fricke@samsung.com tests: Add test for 00360
2020-02-12 s.fricke@samsung.com layers: Add support for 00360
2020-02-12 s.fricke@samsung.com tests: Add tests for 01973 and 01069
2020-02-12 s.fricke@samsung.com layers: Add support for 01973 and 01069
2020-02-11 mark@lunarg.com layers: Update stateless validation doc
2020-02-11 mark@lunarg.com corechecks: Convert core val to use new logging funcs
2020-02-11 mark@lunarg.com corechecks: Converted buffer validation to new logging funcs
2020-02-11 mark@lunarg.com corechecks: Use new logging calls in shader validation
2020-02-11 mark@lunarg.com corechecks: Move helpers inside validation object
2020-02-11 mark@lunarg.com threading: Change log_msg calls to LogError calls
2020-02-11 mark@lunarg.com theading: Pass object pointer instead of report_data
2020-02-11 mark@lunarg.com corechecks: Move misplaced validation call into core validation
2020-02-11 mark@lunarg.com chassis: Changed log_msg calls to LogWarning calls
2020-02-11 mark@lunarg.com corechecks: Convert drawdispatch.cpp to new logging funcs
2020-02-11 mark@lunarg.com gpuval: Moved to new-style logging functions
2020-02-11 mark@lunarg.com corechecks: Converted descriptor_sets.cpp to new logging calls
2020-02-11 mark@lunarg.com practices: Convert WARNINGS to new logging calls
2020-02-11 mark@lunarg.com practices: Convert perf warnings to new logging funcs
2020-02-11 mark@lunarg.com practices: Change info message to warning
2020-02-11 mark@lunarg.com objlifetimes: Convert object tracker to new logging calls
2020-02-11 mark@lunarg.com stateless: Convert parameter validation to new logging calls
2020-02-11 mark@lunarg.com tests: Fix pipeline create state test
2020-02-11 s.fricke@samsung.com tests: Added test for 00701
2020-02-11 s.fricke@samsung.com layers: Added support for 00701
2020-02-11 s.fricke@samsung.com layers: Added condition to display 01427
2020-02-11 s.fricke@samsung.com layers: Added condition to display 01430
2020-02-11 s.fricke@samsung.com tests: Added test for 01988
2020-02-11 s.fricke@samsung.com layers: Added support for 01988
2020-02-11 s.fricke@samsung.com tests: Added test for 01143
2020-02-11 s.fricke@samsung.com layers: Added support for 01143
2020-02-11 s.fricke@samsung.com tests: Added test for 00317 and 00318
2020-02-11 s.fricke@samsung.com layers: Added support for 00317 and 00318
2020-02-11 raul.tambre@cleveron.com layers: Don't issue VU01564 for immutable samplers
2020-02-10 jeremy@lunarg.com tests: Test unaligned CmdPushDescriptorSet
2020-02-10 jeremy@lunarg.com layers: Validate unaligned CmdPushDescriptorSet
2020-02-10 jzulauf@lunarg.com tests: Add layout for middle subresource test
2020-02-10 jzulauf@lunarg.com layers: Fix range_vector excess erasure
2020-02-10 jeremy@lunarg.com layers: Fix unitialized variable.

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@d439b17da022

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I8275b4fab12c0b5124af7583c0ce1e5c0a318594
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050004Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

7adc9736

Roll third_party/SwiftShader b3b2a4fc756f..6cbb02e0dc93 (11 commits) · 58e7790c

authored Feb 12, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/b3b2a4fc756f..6cbb02e0dc93

git log b3b2a4fc756f..6cbb02e0dc93 --date=short --first-parent --format='%ad %ae %s'
2020-02-11 bclayton@google.com CMakeLists: Drop the explicit include path to marl
2020-02-11 bclayton@google.com Bulk clang format
2020-02-11 bclayton@google.com Change SpirvShaderInstructions.inc extension to .inl
2020-02-11 bclayton@google.com Merge changes Ide16cac3,Id5d767fc
2020-02-11 jiaxun.yang@flygoat.com Fix MIPS build cflags
2020-02-11 bclayton@google.com Don't use std::initializer_list for array views.
2020-02-11 sugoi@google.com Support for VK_KHR_separate_depth_stencil_layouts
2020-02-11 sugoi@google.com Support for VK_KHR_create_renderpass2
2020-02-11 bclayton@google.com Revert "Add missed symbol __aeabi_idivmod for Android."
2020-02-11 gmouse@google.com Add missed symbol __aeabi_idivmod for Android.
2020-02-10 bclayton@google.com Debug: Rename levels.

Created with:
gclient setdep -r third_party/SwiftShader@6cbb02e0dc93

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: Ie73f8091b61e7a08e6fa11aac7801d3b7f50080c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2049960Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

58e7790c

Don't print INFO level log messages in Release by default. · e1ccac7f

authored Feb 11, 2020

Even with dcheck_always_on.
INFO level log messages will still be printed in Debug
or when angle_enable_trace is enabled.

Bug: angleproject:3525
Change-Id: Ic3807f94307af2878aee78426c969ab846ae3881
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050890Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

e1ccac7f

11 Feb, 2020 4 commits

Vulkan: Command graph linearization (Step 5). · 3b82506a

authored Feb 11, 2020

Implements ES 3.1 support.

Bug: angleproject:4029
Change-Id: I3c08602cf4ec64621bfdb40cd40d142b666e6edf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046052
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

3b82506a

Vulkan: Update bug number in KHR ES 3.1 expectations · 72e9f4d7

authored Feb 11, 2020

It was pointing to general ES 3.1 bug.

Bug: angleproject:4107
Change-Id: Ief726c57d5a853d633df705eb30e8cdad3f6c9ca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050030Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

72e9f4d7

Roll third_party/vulkan-tools/src 428455ca6121..45b9d01815d9 (2 commits) · 8c0b4889

authored Feb 11, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/428455ca6121..45b9d01815d9

git log 428455ca6121..45b9d01815d9 --date=short --first-parent --format='%ad %ae %s'
2020-02-10 charles@lunarg.com vulkaninfo: Check for surface extensions
2020-02-10 petr_kraus@email.cz build: Fix android update not understanding headers version

Created with:
gclient setdep -r third_party/vulkan-tools/src@45b9d01815d9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: I709bbc83ddf30dd93235b8bc731859265c8a13f1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2049668Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

8c0b4889

Fix assignment of CacheOpResult::EnumCount · 1a8b7758

authored Feb 11, 2020

The special enum value 'EnumCount' is used by EnumSize() to determine
how large to make the PackedEnumMap::mPrivateData array. However, that
enum entry was being assigned an incorrect value, leading to the array
being constructed too small and causing a crash in PackedEnumMap's
std::initializer_list constructor when it went beyond the size of the
array to assign each of the necessary values.

The fix is to remove the assignment of CacheOpResult::EnumCount and let
it indicate the real number of entries in the enum.

Bug: angleproject:4393
Test: end2end
Change-Id: If9635c61e72aadc6527d416f83be18add8b24572
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050026Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

1a8b7758

10 Feb, 2020 10 commits

Vulkan: Remove ensure init from updateActiveImages. · b40d48a6

authored Feb 09, 2020

The ensure should already be triggered from the front-end.

Bug: angleproject:3539
Bug: angleproject:3887
Change-Id: Ic7ee10f9c767440e55befb929b414c0c894754c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046051Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

b40d48a6

Vulkan: Fix EGLBlobCacheTest. · cd8167fb

authored Feb 10, 2020

Several runs of the same test in a row would cause a failure if the
cache would get hit. Fix the flakiness by resetting the cache between
runs.

Also cleans up some of the variable naming and adds a stream output
for pretty test errors.

Fixed while working on the standalone test harness.

Bug: angleproject:3162
Change-Id: I64da8a37eedf562860e3e5409cbf6fb08e81dfa4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2047417Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

cd8167fb

Vulkan: Command graph linearization (Step 4). · 3c066404

authored Feb 05, 2020

Implements GLES 3.0 functionality for the new command recording style.
Tested with angle_end2end_tests. dEQP/CTS testing will come later.

Bug: angleproject:4029
Change-Id: Ibdc4f1355a7b880946699ec227fd9807f4a27af9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2040197Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

3c066404

Speed up InstancingTest.LineLoop. · 041ebfed

authored Feb 10, 2020

This test was taking 14-20 seconds in release mode. Likely because of
the way we were issuing a ReadPixels and "std::endl" to a stream for
every pixel of a 256x256 Framebuffer. Instead issue a single ReadPixels
call and no stream flushes. Now runs in less than 500ms.

Helps prevent timeouts when running tests multi-process. Also enables
the test on D3D9.

Bug: angleproject:3162
Change-Id: I27aad773040d6b6668cbde003802345e01044a7d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2047414Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

041ebfed

Vulkan: Defer RenderPass image barriers. · 8257ac30

authored Feb 07, 2020

We accumulate image barriers in two places:

 * for GL sampler textures
 * for GL framebuffer attachments (Render Targets)

Then we issue the barriers together in a single call before the RP.
This fixes a bug where we were missing a layout transition in some
cases when transitioning between a sampler and a render target. It
should also be faster to issue a single barrier before a RP than issue
several smaller barriers.

Bug: angleproject:3539
Bug: angleproject:4029
Change-Id: I180b770f0df6b44d209e5c618ba36bcc1c6372e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2044236
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

8257ac30

Suppress two failing NVIDIA D3D11 tests. · 788fa360

authored Feb 10, 2020

Bug: angleproject:4391
Bug: angleproject:4392
Change-Id: I81cbf261cf206cd2d38cff93d16056c21bf78557
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2047416Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

788fa360

Capture/Replay: Avoid null pointer dereference in MEC · 9d86f331

authored Feb 04, 2020

Small fix to progress Manhattan MEC.

Bug: angleproject:4091
Test: Working through Manhattan frames 5-10, TRex still works
Change-Id: I7981e19a64f121b2ecca4451574ca2886641c6ac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2039532
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

9d86f331

Capture/Replay: Initial support for framebuffer textures · fc1e8503

authored Feb 05, 2020

Bug: angleproject:3662
Test: Working through Manhattan frames 5-10, TRex still works
Change-Id: I3d9b4dced4c1667382154fb68839d01ba2db9b98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2039531
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

fc1e8503

Roll third_party/SwiftShader dd48b7e2d06e..b3b2a4fc756f (11 commits) · 00b96fe7

authored Feb 10, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/dd48b7e2d06e..b3b2a4fc756f

git log dd48b7e2d06e..b3b2a4fc756f --date=short --first-parent --format='%ad %ae %s'
2020-02-08 bclayton@google.com Fix Android build: Add missing .cpp to Android.bp
2020-02-08 amaiorano@google.com Subzero: fix cosh/sinh deqp failures
2020-02-08 amaiorano@google.com ReactorUnitTests: fix clang-format messing up test suites
2020-02-08 bclayton@google.com Reactor: Copy System/Debug code to Reactor copy
2020-02-08 bclayton@google.com SpirvShaderDebugger: Ignore non-statements
2020-02-07 bclayton@google.com Debug: Control logging level using a compile time knob
2020-02-07 bclayton@google.com Fix chromium build.
2020-02-07 bclayton@google.com Debugging: Merge VkDebug into System/Debug
2020-02-07 bclayton@google.com VkDebug: Android - log messages to logcat.
2020-02-07 bclayton@google.com ReactorBenchmarks: Sweep coroutine perf.
2020-02-07 bclayton@google.com vscode: Add third_party/benchmark to include dirs

Created with:
gclient setdep -r third_party/SwiftShader@b3b2a4fc756f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I0fcc005ec068e5e4f1de2a08f59d137b00c81693
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046532Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

00b96fe7

Roll third_party/glslang/src 95c414ffee64..ae59435606fc (1 commits) · 572d63a7

authored Feb 10, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/95c414ffee64..ae59435606fc


Created with:
  gclient setdep -r third_party/glslang/src@ae59435606fc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Iff9284070cc4d7446cc238f5bec31a71fa3d7509
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046531Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

572d63a7

09 Feb, 2020 2 commits

Suppress Vulkan RobustResourceInit tests. · a8e6a463

authored Feb 09, 2020

These tests are flaky because of a bug in ANGLE's Vulkan robust
resource init. Mark them as failing until we can resolve the bug.

Bug: angleproject:4255
Bug: angleproject:4384
Change-Id: I8e18a8532850848fc7a25e137dce27dd0d19fa55
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046053Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

a8e6a463

Change g_Mutex from std::mutex to std::recursive_mutex · 0a6e118d

authored Jan 27, 2020

When running flatland on android-10.0.0_r21 (Pixel 3), libgui's ~EglImage calls
eglTerminate which grabs angle's EGL entry point mutex. The path continues
to libvulkan where eventually another egl call happens (eglDestroyImageKHR) and
it will attempt to take the mutex at the entry point again. So we try to get the
mutex multiple times from the same thread.

Change this mutex to a recursive_mutex to allow for this re-entry of EGL calls

Tests: android-10.0.0_r21/frameworks/native/cmds/flatland
Bug: angleproject:4354
Change-Id: If8a817df45e9f58d5f06884510350e17d7127fa9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2029218
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

0a6e118d

08 Feb, 2020 2 commits

Capture/Replay: Add 2DArray and 3D texture support for MEC · 0d224cce

authored Feb 05, 2020

This also includes support for compressed formats, which
required a small refactor to streamline the code, since all
of the entrypoints have slightly different parameter lists
for imageSize and data.

Bug: angleproject:3662
Test: Working through Manhattan frames 5-10, TRex still works
Change-Id: I007ad9366934fff773f367ecb6387bc8b0d13aa0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2039530
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

0d224cce

Make Debug marker functions return angle::Result. · 9681190d

authored Feb 05, 2020

Allows error handling in these functions. Necessary for the Vulkan
back-end.

Bug: angleproject:4209
Change-Id: I2092e58e719c6ee562807e1c7e8ad26988342855
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2040196Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

9681190d

07 Feb, 2020 4 commits

Vulkan: Clamp vertex buffer offsets. · c3854ebc

authored Feb 07, 2020

Vulkan mandates that vertex buffer offsets are within the size of the
buffer even if robust buffer access is enabled. Do a check in
VertexArrayVk::syncDirtyAttrib to guard against this.

Bug: angleproject:3350
Change-Id: Ia01deb9b7335dd8f632f2cf9b32d2908ba55645c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2044491
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

c3854ebc

Vulkan: Add missing wrapper functions for XFB. · ca035803

authored Feb 06, 2020

Found when working on the command graph refactor. Also replace the
offsets array with nullptr which should have the same effect.

Bug: angleproject:4029
Change-Id: I72e31c5403c645d72619e14aafef612e454183f1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2043270
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

ca035803

Roll third_party/spirv-tools/src 1f03ac10270a..fe10239f92f4 (1 commits) · 51fd2958

authored Feb 07, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1f03ac10270a..fe10239f92f4


Created with:
  gclient setdep -r third_party/spirv-tools/src@fe10239f92f4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Icdd0cfc181c77ee14bfa4054ea849301078b184f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2043351Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

51fd2958

Roll third_party/glslang/src 656650f461c8..95c414ffee64 (2 commits) · 55de83af

authored Feb 07, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/656650f461c8..95c414ffee64


Created with:
  gclient setdep -r third_party/glslang/src@95c414ffee64

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Id3d1ccb162c60fa5c157982b11641ddab9f2558d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2043352Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

55de83af