Commits · f8f18f05162221eb6ddd70ccb722b25838f5b807 · Chen Yisong / angle

04 Oct, 2014 1 commit

Make blit extension check for internal format mismatch. · f8f18f05

authored Oct 02, 2014

The extension spec dictates a format mismatch generates invalid
operation. Since we can't have the same internal format map to
different actual/native formats, this check is more strict and
we can replace the previous one.

BUG=angle:769

Change-Id: Ic1b5c335ba38a4f2feaffa1478a65e7fcf7f75ea
Reviewed-on: https://chromium-review.googlesource.com/221065Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

f8f18f05

03 Oct, 2014 13 commits

Revert "Enable TexSubImage workaround on D3D11." · dcd8f13d

authored Oct 03, 2014

Probably causing WebGL CTS failures:

http://build.chromium.org/p/chromium.gpu.fyi/builders/Win8%20Release%20%28NVIDIA%29/builds/6148

This reverts commit 2d337ce0.

Change-Id: Ic032640f44adf337c4b3eedd4d7f3551d565a5cb
Reviewed-on: https://chromium-review.googlesource.com/221397Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

dcd8f13d

Enable TexSubImage workaround on D3D11. · 2d337ce0

authored Oct 03, 2014

This workaround uses UpdateResource instead of staging buffers for
texture data updates. It improves performance for highly dynamic
textures, especially in some benchmarks, eg the turbulenz particle
demo.

BUG=angle:729
BUG=365078

Change-Id: Idd82c27845a772199caef3695111c96735e8843e
Reviewed-on: https://chromium-review.googlesource.com/219864Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

2d337ce0

Use COM object dynamic cast for RT resource queries. · 468b26bb

authored Oct 03, 2014

BUG=angle:729

Change-Id: I55af209211329a7a71728e3c6d55d87154cfb45e
Reviewed-on: https://chromium-review.googlesource.com/221269Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

468b26bb

Use gl::Rectangle as a param to Image::copy. · 82bf0c5a

authored Oct 03, 2014

BUG=angle:729

Change-Id: I13194760df35cb18db6ac43d567e6b393e838d56
Reviewed-on: https://chromium-review.googlesource.com/221268Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

82bf0c5a

Accept a second form of WARP Test renderer string. · 00e5452a

authored Oct 02, 2014

On our Renderer test, we would be overly restrictive in the forms
of Renderer string we would accept for WARP. On this machine, it
returns a different string than the one we had in the test. Expand
the test to accept both.

BUG=angle:769

Change-Id: If27644d32d6d7d0eff77ff9cca81faee3b2be4e1
Reviewed-on: https://chromium-review.googlesource.com/221066Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

00e5452a

Restrict the tests that use ClearBuffer to ES3. · 94203b36

authored Oct 02, 2014

We had changed the configurations to run them in ES2 mode, while
ClearBuffer is an ES3-only method.

BUG=angle:769

Change-Id: I63d92af4702a133aa8bbf52444dfef59a4f602b0
Reviewed-on: https://chromium-review.googlesource.com/221064Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

94203b36

Updated authorship and contributors for Borbitsoft/Tibor den Ouden · 448ac908

authored Oct 02, 2014

Removed Borbitsoft from the AUTHORS file, added Tibor den Ouden.
Removed Borbitsoft from CONTRIBUTORS file, company section.
Moved Tibor den Ouden in CONTRIBUTORS file from company section to individual section

Change-Id: I3ab47d637d0879fde8f9dc0f714e2cb44562c897
Reviewed-on: https://chromium-review.googlesource.com/221054Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

448ac908

Update Program, ProgramBinary and HLSLCompiler to use Error objects. · b543afff

authored Sep 30, 2014

BUG=angle:520

Change-Id: Ibbe8c95780fecfb68f4558e99e3a761107da6aee
Reviewed-on: https://chromium-review.googlesource.com/220790Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

b543afff

Add option to support EXT_draw_buffers with NV_draw_buffers · e61209af

authored Sep 26, 2014

After this patch, it is possible to set a flag to change
EXT_draw_buffers extension directives to NV_draw_buffers in ESSL.
This enables users of ANGLE to emulate EXT_draw_buffers by using
NV_draw_buffers in combination with GLES3.0.

Change-Id: I5dacdbd6cd0d0362424ea3791557342c42efd4bd
Reviewed-on: https://chromium-review.googlesource.com/219941Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e61209af

Add TextureStorage::setData. · 955f5c05

authored Oct 02, 2014

Usually we copy data from the Image classes into the Storage. This
method, which will only apply to D3D11, is useful for our SubData
performance workaround.

BUG=angle:729

Change-Id: I50ca8158ee9e0638f59f617b9e6170b508eaeb44
Reviewed-on: https://chromium-review.googlesource.com/219837Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

955f5c05

Use the virtual commitRegion in TextureD3D::subData. · e6b6da03

authored Oct 02, 2014

This allows us remove the duplicated code in the various typed
methods that checks for an error before committing.

BUG=angle:729

Change-Id: Icd0ad2be55ac423baec3855e05c53f4b624b6764
Reviewed-on: https://chromium-review.googlesource.com/220275Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

e6b6da03

Introduce new method commitRegion to TextureD3D. · 7cb2b9d7

authored Oct 02, 2014

Replacing commitRect with commitRegion, which takes generic
parameter types, will allow us to call it directly from the
base class TextureD3D. This will be useful in subsequent
patches that introduce the SubData performance workaround.

BUG=angle:729

Change-Id: I37bf12f847b43f7c961b403321de19f547258b01
Reviewed-on: https://chromium-review.googlesource.com/220274Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

7cb2b9d7

Fix building angleutils.cpp on Linux · 86ffde57

authored Oct 03, 2014

vsnprintf is defined in stdio.h according to the standard. It was not in
the include chain of angleutils.cpp, which broke the build on Linux on
some configurations. Seems like other toolchains include the function in
some non-standard way.

BUG=angle:761

Change-Id: Idcd75776e8a9b83dad182d1b4bac0beac006c6ac
Reviewed-on: https://chromium-review.googlesource.com/221053Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

86ffde57

02 Oct, 2014 15 commits

Fix typos in caps generation method names. · d8111baf

authored Sep 26, 2014

Change-Id: I7efa752b2276cb92b4ca12ffaf7aa37c514525f0
Reviewed-on: https://chromium-review.googlesource.com/219807Tested-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

d8111baf

Store XFB buffers in a vector in State. · 8299bb0f

authored Sep 26, 2014

BUG=angle:685

Change-Id: I4bff717f716ba21633c59244560fd56f41f587ed
Reviewed-on: https://chromium-review.googlesource.com/219806Tested-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

8299bb0f

Use a caps-dependent sized vector to store Uniform Buffers · f3acaf9e

authored Sep 23, 2014

BUG=angle:685

Change-Id: I3f2e9fcccf27aebbb4ec5485286eec9828851887
Reviewed-on: https://chromium-review.googlesource.com/219805Tested-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

f3acaf9e

Change mVertexAttribCurrentValues from fixed-size array to STL container. · 23e0500d

authored Sep 22, 2014

BUG=angle:685

Change-Id: I42fc6c919f42cd6ab1c11531742f9a2c5ad0cd3d
Reviewed-on: https://chromium-review.googlesource.com/219353Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

23e0500d

Vertex management functions can take a State reference instead of pointers to attrib data. · 1a965480

authored Sep 22, 2014

BUG=angle:685

Change-Id: I0bfc26c53eb1358a023ac5d4ec20be06f9c90f4a
Reviewed-on: https://chromium-review.googlesource.com/219352Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

1a965480

Remove context pointer from State · 2df6a601

authored Sep 26, 2014

BUG=angle:685

State needs only to track a few variables from Context's caps,
so store those instead of a pointer to Context.

Change-Id: I36d448dcaccf9780d6df2cfc82ef975b2ba0346f
Reviewed-on: https://chromium-review.googlesource.com/219804Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

2df6a601

Disable broken D3D9 GLSL Varying tests. · bee59e03

authored Oct 02, 2014

Not sure at the moment if we can only disable tests in D3D9/etc,
but these tests are broken for D3D9 and hence we can disable them
to return angle_tests to passing.

BUG=angle:769

Change-Id: I3c13f985fde99c3d885f825de60af841c8f3f0f1
Reviewed-on: https://chromium-review.googlesource.com/221067Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

bee59e03

Don't run the DrawBuffers tests in D3D9. · 49f9dd45

authored Oct 02, 2014

We only support MRT on the D3D11 Renderer for now, so we can skip
running these tests entirely on the D3D9 back-end.

BUG=angle:769

Change-Id: I442936fe987ae1749d5ee7626f6a4737e824ac6f
Reviewed-on: https://chromium-review.googlesource.com/221063Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

49f9dd45

Fix D3D9 varyings limits. · aabecf8e

authored Oct 02, 2014

We were off by one varying, since D3D9 treats PSIZE specially.

BUG=angle:769

Change-Id: Id5242d12c3ca42da3f3f528ff4a21445dba89701
Reviewed-on: https://chromium-review.googlesource.com/221062Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

aabecf8e

Fix a bug in MaxTextureSizeTest.RenderToTexture. · 5ac124b1

authored Oct 02, 2014

This bug only presented itself in our D3D9 Renderer. In D3D11 we
would stretch the texture to fit -- this is behaviour correct in
ES3 but not in the ANGLE spec draft.

BUG=angle:769

Change-Id: Iddb8551c9645aa6f0841e2dc9d96fbd196bc6788
Reviewed-on: https://chromium-review.googlesource.com/221061Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

5ac124b1

Accept RenderTargets as parameters to Image::copy. · 5a0c45e1

authored Oct 02, 2014

This gives us the flexibility to use copy internally for Textures
as well as FBO attachments. This will be useful for the TexSubImage
performance workaround.

BUG=angle:729

Change-Id: I4df8ef3a5a928d44ef84100cd96a5d35f12b47fa
Reviewed-on: https://chromium-review.googlesource.com/219863Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

5a0c45e1

Roll gyp dependency to 1987 · 9a2e6ac9

authored Oct 01, 2014

Change-Id: Id063785b1d0c2a4badc73d6ec828060b7893e58c
Reviewed-on: https://chromium-review.googlesource.com/220843Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

9a2e6ac9

Fixed mingw compilation. · a5521de2

authored Oct 01, 2014

Change-Id: I8ae33c752feb19e291e4a3b128d21a0ced883c90
Reviewed-on: https://chromium-review.googlesource.com/220761Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

a5521de2

Freed temporary info log buffer and removed explicit destruction of char[] · ac7556f6

authored Sep 25, 2014

BUG=angle:758

Removed explicit destruction of char[] by using std::vector<char> object.

Added Borbitsoft to AUTHORS and Tibor den Ouden to CONTRIBUTORS

Change-Id: I9c4017eb81ce3fab8b7fb4a5b4ad52a758d14a2d
Reviewed-on: https://chromium-review.googlesource.com/219940Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

ac7556f6

Add check for size before setting buffer data. · ff39bd87

authored Oct 01, 2014

If data is non-null and size is zero, the memory buffer may have a NULL
pointer.

BUG=angle:765

Change-Id: I4cb8f54ec85fea886e37ee2d4469d26e651a916b
Reviewed-on: https://chromium-review.googlesource.com/220801Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

ff39bd87

01 Oct, 2014 1 commit

Replace usages of std::vector::data in most cases. · b4fd0c96

authored Oct 01, 2014

In some parts of ANGLE code, we were using std::vector::data to get
a pointer to the first element. Sadly, this is c++11 only, which
isn't currently supported on Chromium. This was causing a breakage
on Android. We should probably refrain from using data except on
D3D-only code, which we know will be Visual Studio.

BUG=angle:767

Change-Id: Ibc10577368435a13f62d74d77c95076482cd8f82
Reviewed-on: https://chromium-review.googlesource.com/220920Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

b4fd0c96

30 Sep, 2014 10 commits

Configure Google Tests to run against multiple renderers/GLES versions · 18b931d5

authored Sep 29, 2014

BUG=angle:611

Change-Id: I7d43612171c439045038db9ae82fd8716c0b31c6
Reviewed-on: https://chromium-review.googlesource.com/220400Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Austin Kinross <aukinros@microsoft.com>

18b931d5

More TextureD3D cleanups. · 3269bcb4

authored Sep 30, 2014

The getLayers method was redundant, and the getBaseLevelImage method
we can replace with a shared TextureD3D method rather than a
specialized method for each type.

BUG=angle:729

Change-Id: I80c94a765dbc369fb0bb60ec8273e9e3ba6ffeed
Reviewed-on: https://chromium-review.googlesource.com/219862Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

3269bcb4

Clean up ensureRenderTarget(). · 135570a4

authored Sep 30, 2014

We can use the same code for this method, with the only difference
being in when we determine a texture image holds no pixels.

BUG=angle:729

Change-Id: I3356f5deb900c24b1a5c739ce8de99e9ce1371c0
Reviewed-on: https://chromium-review.googlesource.com/219861Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

135570a4

Fix d3d9 copyToStorage dirty flag. · 716915d7

authored Sep 30, 2014

This flag wasn't being set in the 2D version of this method. The bug
would only cause a performance penalty on Windows XP machines.

BUG=angle:729

Change-Id: I516206740becc90438d613ae9abb3ac550733aed
Reviewed-on: https://chromium-review.googlesource.com/219860Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

716915d7

Remove copyToRenderTarget methods. · 98553e37

authored Sep 30, 2014

These Renderer methods can be replaced with virtual TextureStorage
methods, now that we do not have TextureStorageInterface to
complicate matters. This reduces the number of stubs in Renderer
as well as allowing cleaner code re-use.

BUG=angle:729

Change-Id: I6d2004d4f1abdb1041420144cee1c173e5ab199e
Reviewed-on: https://chromium-review.googlesource.com/219839Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

98553e37

Moved the responsibility for releasing the dest surface out of copyToSurface. · 3a612876

authored Sep 29, 2014

BUG=angle:520

Change-Id: I4c6c39462b43eeb0a202f731c4a54007ef16445c
Reviewed-on: https://chromium-review.googlesource.com/219866Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

3a612876

Refactor Texture::compressed*Image methods to use gl::Error objects. · b5348331

authored Sep 02, 2014

BUG=angle:520

Change-Id: I8fd7ebf3edb3edef06e77b79776c363672931a61
Reviewed-on: https://chromium-review.googlesource.com/216646Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

b5348331

Merge the various TextureCube::setImage* methods. · 8376ceae

authored Sep 02, 2014

BUG=angle:520

Change-Id: I4e8191dd827744ef380348a31dce7181d99fbf30
Reviewed-on: https://chromium-review.googlesource.com/216645Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

8376ceae

Refactor Texture::setImage and subImage to use gl::Error objects. · 1ba6b8db

authored Aug 28, 2014

BUG=angle:520

Change-Id: Ib43ace0fbdab59086ae4314cce139636d9045e65
Reviewed-on: https://chromium-review.googlesource.com/216644Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

1ba6b8db

Fix the ANGLE_ENABLE_TRACE build. · b60fe31f

authored Sep 26, 2014

We needed to include angleutils.cpp in libtranslator for this to
compile. Also allow the event helpers to record API calls even
if ANGLE_ENABLE_PERF is off.

BUG=angle:513

Change-Id: I2646d5ebeae536a4a7f1cd7ecaf0ce019ce5ff76
Reviewed-on: https://chromium-review.googlesource.com/219756Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

b60fe31f