- 23 Jan, 2020 6 commits
-
-
Antonio Maiorano authored
Subzero emits incorrect code for FRem operations on vectors. Replace with an emulated version that calls fmodf on each component for now. Bug: b/148139679 Change-Id: Ib541370b71b99649f8c73f982fd12cb3cde25e7f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40450 Presubmit-Ready: Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
The parent change replaced all UNIMPLEMENTED() with UNSUPPORTED(), since we are now Vulkan 1.1 conformant and the majority of these UNIMPLEMENTED() uses was for functionality that is not mandatory to still implement and is instead part of a currently unsupported feature. This change conservatively restores uses of UNIMPLEMENTED() for things that we might hit with correctly behaving apps. Bugs will be filed for each of these and tests will be added where necessary to provide coverage of these code paths. Bug: b/131243109 Change-Id: Iaf547983c8495ad8d6d0c783a4c656273d8c0195 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40409 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Nicolas Capens authored
Most cases of UNIMPLEMENTED() are actually for functionality that we do not support, and correctly advertise as such. It's expected to be an application bug if these asserts are hit, and not an indication of something we must still implement to be a compliant Vulkan implementation. This change will be immediately followed up by one which restores UNIMPLEMENTED() where it was used correctly. This two-change approach makes it much easier to see what still needs to get done. Bug: b/131243109 Change-Id: Id09b5de5bc73fabfdc3199dcd3091cb72283be65 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40408 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
SwiftShader Regression Bot authored
Change-Id: I1ac2376f37c4562fa1e7bdfc86663ac9d09cbf27 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40428 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolas.capens@gmail.com> Reviewed-by:
-
Nicolas Capens authored
Bug: b/142965928 Change-Id: I0c2e7054d51a1dd3d1e0915384b5cfbdaffda178 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40349 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
Nicolas Capens authored
Previously the rasterizer was just using sample location 0. The Vulkan 1.1.130 spec states that "When VK_LINE_RASTERIZATION_MODE_BRESENHAM_EXT lines are being rasterized, sample locations may all be treated as being at the pixel center". And also "Do we need to support Bresenham-style and smooth lines with more than one rasterization sample? RESOLVED: Yes. For simplicity, Bresenham line rasterization carries forward a few restrictions from OpenGL, such as not supporting per-sample shading, alpha to coverage, or alpha to one." Bug: b/142965928 Change-Id: I586ffbaa92d506595d6fecfa2dbd64f10bdee0c8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40188 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
- 22 Jan, 2020 6 commits
-
-
Alexis Hetu authored
As with 888 and 1010102, 565 and 5551 need to be rounded before being written. Bug: b/146633956 Change-Id: Ifea2e8f187a276a1f49effedc377612dbe338057 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40368 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Reviewed-by:
-
Ben Clayton authored
Only use the condition in the `endif()` if: • The opening `if()` is more than 20 lines away. • The `endif()` doesn't belong to an `elif()`. Also remove redundant sequences of `endif(SWIFTSHADER_BUILD_TESTS)` `if(SWIFTSHADER_BUILD_TESTS)` Bug: None. Style bikeshedding Change-Id: I967948a2afdedbd503add5addffc666c698eb885 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40468 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Only wait when the `VK_WAIT_FOR_DEBUGGER` env var is set. Long term I want to move away from relying on environment variables, but this is currently consistent with the `VK_DEBUGGER_PORT` env var which also enables the debugger. Bug: b/148135662 Change-Id: I990d907d7570569e9d6716cf5d13e9846f4a5c02 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40429Reviewed-by:
-
Ben Clayton authored
Outer projects may already build this target, in which case we don't want to build it again. Bug: b/148010928 Change-Id: I19eea95eb81f13495268f5109d5554ef16033598 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40330Reviewed-by:
-
Ben Clayton authored
This allows outer projects to force-set these build options without exposing them in CMakeCache.txt Bug: b/148010928 Change-Id: Ib7d3965c04cf9822566ed569af9832db30f133b1 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40329 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Nicolas Capens authored
The spec states that "Applications must not pass any other values than VK_TRUE or VK_FALSE into a Vulkan implementation where a VkBool32 is expected." However, in case applications do use other values, the least surprising behavior is for non-0 values to be interpreted as true. Bug: b/134584057 Change-Id: I861691442683d534b4e34bd55deb18643adb3a99 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40448 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
- 21 Jan, 2020 1 commit
-
-
Alexis Hetu authored
Vertex input buffers only support VK_FORMAT_A2B10G10R10_UNORM_PACK32. This cl adds all the signed and integer variants of that format. This cl also removes StreamType and replaces it with VkFormat. Tests: dEQP-VK.*r10* Bug: b/142661203 Change-Id: I996705395cbb493c599e1a460a6368a7e00d5a55 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40348Tested-by:
-
- 18 Jan, 2020 2 commits
-
-
Nicolas Capens authored
The pipeline code doesn't need to know whether we're drawing Bresenham lines or anything else. It just needs to know whether or not to enable multisample rasterization for a multisample render target. Also rename multiSample to multiSampleCount. Bug: b/142965928 Change-Id: I34395e90d502c49cd13e0087d4b323d222cb2064 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40169 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Nicolas Capens authored
Just a refactoring to improve syntax and avoid non-const references. Also don't assume SIMD types are 4-wide. Also add [[fallthrough]] cases found in the process. Bug: b/143351714 Bug: b/142661203 Change-Id: I12a0178338ce4c711bcbf62825d230580f3e92f0 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40288 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
- 17 Jan, 2020 3 commits
-
-
Nicolas Capens authored
This is widely supported by other Vulkan drivers, and there's no reason these formats should be different from other ones when it comes to linear filtering. Bug: b/147586576 Change-Id: I43c8e4a65ab001c85f6c3621487a634f302d21a1 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40250Reviewed-by:
-
Nicolas Capens authored
To be consistent with https://swiftshader-review.googlesource.com/39050 Bug: b/145746360 Change-Id: I153999887e833da5c0e44277ccc71f529a412299 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40289Tested-by:
-
Ben Clayton authored
This is a first, rough, implementation of the OpenCL.Debug.100 extension instruction set. This is incomplete, and likely buggy. It does however implement enough to perform single line stepping through hand-crafted HLSL, with basic variable inspection. Many tests and fixes to come... Bug: b/145351270 Change-Id: Ia570f5b22a8b3ce39df0438ca3c6700d1a00d014 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40268Reviewed-by:
-
- 16 Jan, 2020 1 commit
-
-
Nicolas Capens authored
Remove it root and stem to ensure there can't be any usage of it, since it cannot be efficiently supported by ANGLE with SwiftShader Vulkan without major changes. Bug: b/147536183 Bug: b/147762087 Change-Id: Ib413e7c7f8d13ee22a5201e34163f592db572d86 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40112 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Lingfeng Yang <lfy@google.com> Reviewed-by:
-
- 15 Jan, 2020 10 commits
-
-
Jonah Ryan-Davis authored
Warning for a switch statement with 'default' but no 'case labels. This warning is triggered in the ANGLE CQ and blocking a sws roll. Bug: angleproject:4299 Change-Id: Id8d98c124e19b6a6834beb9a643b182e2d5876e7 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40248Tested-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
-
Ben Clayton authored
Optimization passes are likely to damage debug information, and reorder instructions. We will likely never want to optimize shaders inside the driver when debugging. SPIR-V tools currently has a number of issues consuming shaders that use the OpenCL.Debug.100 extension instructions which need to be fixed before these instructions can be passed to it. For now, just disable shader pre-processing when we are debugging. Bug: b/145351270 Change-Id: I71827c2bb7cf34ecfd7e55b0ca8b3189e460b150 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40130 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Nicolas Capens authored
On a 4-core Linux VM it has the following effect: LESS_DEBUG_INFO=0 real 20m13.051s user 63m45.648s sys 6m51.636s 745.8 MB libvk_swiftshader.so 13 GB build dir LESS_DEBUG_INFO=1 real 15m2.821s user 51m8.659s sys 5m17.466s 197.8 MB libvk_swiftshader.so 3.1 GB build dir Also use /DEBUG:FASTLINK on Visual Studio. It disables producing a single .pdb which can be relocated. Specifying LESS_DEBUG_INFO=1 has no effect on Windows currently, but is done for consistency and in case we start using Clang on Windows. Also color errors in presubmit consistently. Bug: b/147735529 Change-Id: Ieb5c84c192178653f74043daf3d8ee599d3ecf6b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40228 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Nicolas Capens authored
Instead of deducing the binary operation type from the identity value, which used a type alias, just specify it explicitly. This enables passing the initialization value used as the identity, instead of necessarily an identity value vector itself, as well as omitting the type alias. In turn this allowed omitting the scope brackets, resulting in a significant code compaction without compromising readability. Bug: b/142002682 Change-Id: I23d6d984bbfdf47af72108adbc942992007fc3c0 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40168 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Reviewed-by:
-
Nicolas Capens authored
This matches the std::numeric_limits<> method name. Negative infinity can be obtained using -infinity() just like in C++. Also replace the use of C99 INFINITY with the C++ constant. Bug: b/140302841 Change-Id: Ifd5e5d1fa4fa2d9ccce6d334af22903ea7597a69 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40148 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Ben Clayton authored
This change adds the logic to recognise the OpenCL.DebugInfo.100 extension and handle its instructions, but does not do anything with them (yet). The actual handling of these instructions comes in a later change. Bug: b/145351270 Change-Id: I8d68d583e1588d62e6c68fcc4365161fddf83509 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40131Tested-by:
-
Ben Clayton authored
The generic template constructor now matches the `vec<T, 4>` specialization in terms of `constexpr`. This is only achievable with the relaxed rules on `constexpr` in C++14. Bug: b/147359661 Change-Id: I1c63ddd1fbdf3c491f8fcdba96047be0665f122f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40209Reviewed-by:
-
Ben Clayton authored
The `PRINT_EACH_PROCESSED_INSTRUCTION` preprocessor flag can control printing of each instruction before they are processed. This is exceptionally helpful when debugging the debugger (or anything else to do with SpirvShader). Bug: b/145351270 Change-Id: Iddfbedbfc86487d71f6980b2f3fb74f7f13e972f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40093Reviewed-by:
-
Ben Clayton authored
The `extensions` map of ID -> extension has been renamed to `extensionsByID`. The `extensionsImported` is a new set containing the list of extension names that have been imported. This set can be efficiently queried to determine whether a particular extension is in use. Bug: b/145351270 Change-Id: I74bbfb2e5b95862c5381037f259262a9d45b6624 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40092Tested-by:
-
Ben Clayton authored
37f30185 added CMake rules to copy the `OpenCLDebugInfo100.h` header out of a polluted build intermediate directory and into a separate include directory. Add this include directory to the .vscode include paths so vscode can also find it. All of this smell should go away once https://github.com/KhronosGroup/SPIRV-Headers/issues/137 is addressed. Bug: b/145351270 Change-Id: I1a20e6f6b507e10c90fed38dd8a94d4b3ff590f7 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40129Reviewed-by:
-
- 14 Jan, 2020 3 commits
-
-
Ben Clayton authored
Instead of casting to int for a map key. Bug: b/147359661 Change-Id: Id777f7285f9349e7ab855c4a5a26d6a2aa4c02ba Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39953 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Ben Clayton authored
Bug: b/147359661 Change-Id: If36058304196625465c2b632d789617e0947352a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39952Reviewed-by:
-
Chris Forbes authored
Bug: b/141698760 Change-Id: Icb293abc63a46c41a5165cdaa2061c23926b2568 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39988 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
- 13 Jan, 2020 8 commits
-
-
Ben Clayton authored
Variadic arguments weren't using the ## prefix, and causing build failures on certain compilers. Also always `printf()` the "Waiting for debugger connection..." message. If we're debugging, then writing to `stdout` isn't an offence. Bug: b/145351270 Change-Id: I2f86b118043ef2b2b6d291834c9f134a4db5c18d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40091Reviewed-by:
-
Ben Clayton authored
SPIRV-Tools generates extension header files into the the project's intermediate build directory. SpirvShader needs to include `OpenCLDebugInfo100.h`, so copy this out to a "clean room" include directory and add this directory to the vk_swiftshader INCLUDE_DIRECTORIES. All of this smell should go away once https://github.com/KhronosGroup/SPIRV-Headers/issues/137 is addressed. Bug: b/145351270 Change-Id: Ib9205e04d32e2d8e0a6516449ec9114a3ff6dd94 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40090Reviewed-by:
-
Ben Clayton authored
Define ENABLE_VK_DEBUGGER to 1 so that VS code doesn't gray-out the debugger logic. This does not affect the build in any way. Bug: b/145351270 Change-Id: I52e1dfa7c2d83f2db4258d6e9e5f3a57c601452d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40089 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Ben Clayton authored
Includes the fix for invalid SPIR-V merge blocks. Removed the temporary patch added in e75a1838. Change-Id: Ibab6c3606077a4b7207884d24bbf1232207d1800 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40128Reviewed-by:
-
Nicolas Capens authored
That's what it's called by the Vulkan spec. Fixes: b/29203875 Change-Id: Id5049147692b0c845b1bb7afeb8ff5fa94c25773 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40114 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Nicolas Capens authored
This extension is believed to be unused. Bug: b/147536183 Change-Id: Ifaa1e560414e93f2d1382d7d83c335dda9370eee Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40110Tested-by:
-
Nicolas Capens authored
This extension is believed to no longer be required. Note GL_EXT_texture_format_BGRA8888 offers similar (but not identical) functionality. Bug: b/147536183 Change-Id: Id58c62f5ab2fddb3f99e43a9ab74a5929d29983a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40108 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Nicolas Capens authored
In rare cases the requirement to have a Buganizer or Monorail bug ID in the commit message can be unreasonable. For example when the build is broken and the fix is trivial so the creation of a tracker bug would needlessly take valuable time. Another example would be fixing a spelling mistake in a comment and we don't want to spam the tracker thread with a commit notification. For such cases, accept bug info lines containing no digits. Bug: b/141892461 Change-Id: Iaf44eb3dfc08d3e138fe8ba24501fa9c046d36de Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40029 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Reviewed-by:
-
