- 18 Apr, 2017 2 commits
-
-
Ivan Krasin authored
Linking libEGL.so of the SwiftShader's flavor requires the linker to be too smart (there's a heavy reliance on garbage collecting unused symbols, for which there is no guarantees in the general case). In ThinLTO case, garbage collection is still not as sofisticated, as in other cases, so it fails to link the target complaining about undefined symbols. The workaround is to prevent Clang from splitting the bitcode files in the question into two, and making the GC problem a bit easier. Eventually, ThinLTO might get a better GC, but it might be a good idea to not rely on this feature in the source code. At least, no other targets in Chromium do. BUG=chromium:686980 Change-Id: Ib44f65c4825cc3f6cd24695738a71ca4661f0bfb Reviewed-on: https://swiftshader-review.googlesource.com/9308Tested-by:
Ivan Krasin <krasin@chromium.org> Reviewed-by:
Nicolas Capens <capn@google.com>
-
Nicolas Capens authored
Bug chromium:712624 Change-Id: I8e7813aac44c9fef1a2311be550da8cea5a65d16 Reviewed-on: https://swiftshader-review.googlesource.com/9330Reviewed-by:
Nicolas Capens <capn@google.com> Tested-by:
Nicolas Capens <capn@google.com>
-
- 13 Apr, 2017 3 commits
-
-
Nicolas Capens authored
Bug b/31913614 Bug b/32087196 Change-Id: I45c06c7cb907ae1f1efc57c6302044334159c828 Reviewed-on: https://swiftshader-review.googlesource.com/7734Tested-by:
Nicolas Capens <capn@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
-
Nicolas Capens authored
The EGL_ANDROID_framebuffer_target extension description is vague about which configs are supposed to have the EGL_FRAMEBUFFER_TARGET_ANDROID attribute set. The HWComposer isn't supposed to do format conversions, nor should we have to blit or convert on eglSwapBuffers, so the flag is only set when the config's format matches the framebuffer format. Bug b/21804123 Change-Id: Ie348750fbf1b2f096cdf36358d5c90b6f42e30c1 Reviewed-on: https://swiftshader-review.googlesource.com/8933Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com> Tested-by:
Nicolas Capens <capn@google.com>
-
Nicolas Capens authored
Change-Id: I97f30a38f2f78ae5c4e2be8899dae3c8ff8bc748 Reviewed-on: https://swiftshader-review.googlesource.com/8968Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com> Tested-by:
Nicolas Capens <capn@google.com>
-
- 12 Apr, 2017 1 commit
-
-
Nicolas Capens authored
- Implemented GL_EXT_color_buffer_float. - Removed duplicate glRenderbufferStorageMultisample implementation. - Refactored internalformat validation. - Removed GL_R11F_G11F_B10F as renderable format. OpenGL ES 3.0 only supports this as a texture format. Change-Id: I83ce8225c1b310006f5ce983349ea8cb8b2f7c29 Reviewed-on: https://swiftshader-review.googlesource.com/9048Tested-by:
Nicolas Capens <capn@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
- 11 Apr, 2017 2 commits
-
-
Nicolas Capens authored
Textures with just one texel don't require filtering. This also avoids precision issues for pedantic tests which expect exact values. Bug swiftshader:39 Change-Id: I52c5697e277523e2b8cb2c879ba0a7b2296ee7c5 Reviewed-on: https://swiftshader-review.googlesource.com/9068Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com> Tested-by:
Nicolas Capens <capn@google.com>
-
Alexis Hetu authored
For OpenGL ES 3.0, the varyings limit must be increased in order to meet the new lower limit. This doesn't solve how the varyings count is still verified at compile time instead of link time, but it allows us to remove an UNIMPLEMENTED() call. Bug b/37069434 Change-Id: Ib6641352b625d56c7c3cab119fadcdc19f794a5b Reviewed-on: https://swiftshader-review.googlesource.com/9188Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
-
- 10 Apr, 2017 1 commit
-
-
Nicolas Capens authored
These tests rely on the SwiftShader libraries to be loaded from a swiftshader/ subdirectory. The PowerVR samples are a better smoke test for the standalone build, so we can just remove the Chromium unit tests from the Visual Studio solution. Bug swiftshader:42 Change-Id: Ia7d73a62aac4a202750e630666143c920fec65b7 Reviewed-on: https://swiftshader-review.googlesource.com/9268Tested-by:
Nicolas Capens <capn@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
-
- 06 Apr, 2017 2 commits
-
-
Nicolas Capens authored
Change-Id: Idc8f54ac36e59640b93af83293dc2339a25336d6 Reviewed-on: https://swiftshader-review.googlesource.com/9208Reviewed-by:
Nicolas Capens <capn@google.com> Tested-by:
Nicolas Capens <capn@google.com>
-
Nicolas Capens authored
This test verifies that the swiftshader EGL libraries exists, can be loaded, has its entry functions accessible, and we get the expected vendor/version strings. Change-Id: Ifc29286cfaa83fa4c2412c073d383f2c1b58766f Reviewed-on: https://swiftshader-review.googlesource.com/9168Tested-by:
Nicolas Capens <capn@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
-
- 04 Apr, 2017 1 commit
-
-
Nicolas Capens authored
Change-Id: Ie546d41b0205c7bd963a56af209652fd41fbe3ca Reviewed-on: https://swiftshader-review.googlesource.com/9128Tested-by:
Nicolas Capens <capn@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
-
- 03 Apr, 2017 1 commit
-
-
Nicolas Capens authored
Change-Id: Ib13af2fb929df98e0bb0e5af33a935942d854706 Reviewed-on: https://swiftshader-review.googlesource.com/9008Reviewed-by:
Nicolas Capens <capn@google.com> Tested-by:
Nicolas Capens <capn@google.com> (cherry picked from commit 2aeaa6f445b1878a1ee3986c3b08ffa50323b366) Reviewed-on: https://swiftshader-review.googlesource.com/9108Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
- 31 Mar, 2017 1 commit
-
-
Nicolas Capens authored
By default we build SwiftShader with the LLVM backend, so the build shouldn't fail because of missing the Subzero submodule's code. Run git submodule update --init To pull the submodule if you do want to build with Subzero. Change-Id: Ib752edf891a6dd18fff8ce0dfae79ff5a1b7e011 Reviewed-on: https://swiftshader-review.googlesource.com/9088Tested-by:
Nicolas Capens <capn@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
-
- 29 Mar, 2017 4 commits
-
-
Tom Anderson authored
This CL removes some warning spam on a gcc build. Bug chromium:697528 R=capn@google.com Change-Id: I6909d30e3fcafc8ab7e3a98efe8d180a686781d8 Reviewed-on: https://swiftshader-review.googlesource.com/9031Reviewed-by:
Nicolas Capens <capn@google.com> Tested-by:
Tom Anderson <thomasanderson@google.com>
-
Nicolas Capens authored
The EXT_read_format_bgra extension specifies that GL_BGRA_EXT can only be returned for GL_UNSIGNED_BYTE, UNSIGNED_SHORT_4_4_4_4_REV_EXT, and UNSIGNED_SHORT_1_5_5_5_REV_EXT types. Bug swiftshader:38 Change-Id: I54d7b6bbb0954fce87ee7622207fe32a308a43d9 Reviewed-on: https://swiftshader-review.googlesource.com/9030Tested-by:
Nicolas Capens <capn@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
-
Nicolas Capens authored
Bug swiftshader:38 Change-Id: Ice466d96e4d71d546e5770551cc4188f8364edd0 Reviewed-on: https://swiftshader-review.googlesource.com/9029Tested-by:
Nicolas Capens <capn@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
-
Nicolas Capens authored
Bug swiftshader:38 Change-Id: I74c642b3c7346541d042acde78aa2e0213beb5f6 Reviewed-on: https://swiftshader-review.googlesource.com/9028Tested-by:
Nicolas Capens <capn@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
-
- 20 Mar, 2017 2 commits
-
-
Tom Anderson authored
This CL fixes building the 'all' target in a Chromium checkout with the following args.gn: is_debug = false is_clang = false use_sysroot = false proprietary_codecs = true ffmpeg_branding = "Chrome" is_component_build = true enable_nacl = false use_goma = true Bug chromium:697528 Change-Id: Ie725988e8a1cb9ee672eb1e8e20d718ac91004fa Change-Id: Ie725988e8a1cb9ee672eb1e8e20d718ac91004fa Reviewed-on: https://swiftshader-review.googlesource.com/8888Reviewed-by:
Nicolas Capens <capn@google.com> Tested-by:
Tom Anderson <thomasanderson@google.com>
-
Nicolas Capens authored
String literals are const in C++11, and should only be assigned to const pointers. Bug swiftshader:33 Change-Id: Iefe0a1c06d58dffb69d7fbe199a2f0aa8bf3bcb1 Reviewed-on: https://swiftshader-review.googlesource.com/8990Tested-by:
Nicolas Capens <capn@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
- 16 Mar, 2017 3 commits
-
-
Nicolas Capens authored
When building with VC++ 2017 RC and its default header files the intrin.h header file is less aggressively included by Windows headers. This causes build breaks on Chrome x64 builds with VC++ 2017 RC when X86MCTargetDesc.cpp uses __cpuid without first including its header. https://github.com/google/swiftshader/pull/2 Change-Id: I664d7b509e0517b7621d41312ccdd0d3de60de84 Reviewed-on: https://swiftshader-review.googlesource.com/8951Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Nicolas Capens <capn@google.com>
-
Alexis Hetu authored
WaitForDebugger function was undefined. Change-Id: I578e99638bddc40c56817cfc66ed5787f1cdc6e7 Reviewed-on: https://swiftshader-review.googlesource.com/8953Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Alexis Hetu authored
The debugger wait dialog hinders tests on debug builds on chromium bots, so this change sets the debugger wait dialog to only be allowed only on Visual Studio builds within the SwiftShader solution. Change-Id: I0b126f9b0d0451d0fa8941fcb3f9097100488f45 Reviewed-on: https://swiftshader-review.googlesource.com/8952Reviewed-by:
Nicolas Capens <capn@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
- 15 Mar, 2017 1 commit
-
-
Greg Hartman authored
Bug b/36232368 Change-Id: I0a62629db6737134771861710ee0b18826807008 Reviewed-on: https://swiftshader-review.googlesource.com/8949Reviewed-by:
Nicolas Capens <capn@google.com> Tested-by:
Greg Hartman <ghartman@google.com>
-
- 14 Mar, 2017 1 commit
-
-
Alexis Hetu authored
Rather than specifying defines using explicit commands in "cflags" sections, all defines were moved to generic "defines" sections. Change-Id: Ica6ee2a2447aae4f8fc6decc3a4f6b40af7ce9fd Reviewed-on: https://swiftshader-review.googlesource.com/8948Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
- 13 Mar, 2017 2 commits
-
-
Nicolas Capens authored
Rendering on the main thread can cause segmentation faults on Windows due to uncommitted stack memory, since Subzero does not currently call __chkstk. In practice this would have mainly been an issue on VMs with a single virtual CPU. Bug swiftshader:25 Change-Id: Ic3be7e5a41ef09b7e056d3c3df2983c225101fe4 Reviewed-on: https://swiftshader-review.googlesource.com/8934Tested-by:
Nicolas Capens <capn@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
-
Nicolas Capens authored
The __chkstk function can be at a greater than 4 GiB offset from our generated function. Fix derived from https://reviews.llvm.org/D7267 Change-Id: Ife87dcd42541676828c4a0ca77dcded6649ce278 Reviewed-on: https://swiftshader-review.googlesource.com/8932Reviewed-by:
Nicolas Capens <capn@google.com> Tested-by:
Nicolas Capens <capn@google.com>
-
- 10 Mar, 2017 3 commits
-
-
Nicolas Capens authored
https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html#Clobbers specifies that the clobber list should not overlap with the input or output. Change-Id: I77fc2bfc6209ed325355193758f00fc171c8aebf Reviewed-on: https://swiftshader-review.googlesource.com/8930Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com> Tested-by:
Nicolas Capens <capn@google.com>
-
Nicolas Capens authored
Subzero doesn't actually use any ABI breaking LLVM functionality, so we compile a minimized version of LLVMSupport which does not include the symbol used to detect a mismatch in the ABI-breaking check at link- time. Hence we need to disable this check. Change-Id: I04c37deb359b81c21954ad92a6665d44fe2312a5 Reviewed-on: https://swiftshader-review.googlesource.com/8929Tested-by:
Nicolas Capens <capn@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
-
Nicolas Capens authored
GCC warns against bitfields not fitting the entire range of an enum with a fixed underlying type of unsigned int, which gets promoted to an error with -Werror and cannot be suppressed. However, GCC already defaults to using unsigned int as the underlying type of an unscoped enum without a fixed underlying type. So we can just omit it. Bug chromium:697528 Change-Id: I8db8fef09e3397d4ec5ebe9f7c3c5e4ae9c0edff Reviewed-on: https://swiftshader-review.googlesource.com/8928Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com> Tested-by:
Nicolas Capens <capn@google.com>
-
- 28 Feb, 2017 1 commit
-
-
Csaba Osztrogonác authored
to be able to override chromium_git. Change-Id: I11419a81fb492affcfa92ba69661cc90ad88ae98 Reviewed-on: https://swiftshader-review.googlesource.com/8868Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
- 19 Feb, 2017 1 commit
-
-
Alexis Hetu authored
Added the missing part of the FenceSync object implementation based on the assumption that all fence operations are always signaled before calling any sync related wait functions. Passes all related dEQP tests. Change-Id: I2fd2ac160dfd1250f55240fc3f696f00579d12d4 Reviewed-on: https://swiftshader-review.googlesource.com/8855Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
-
- 18 Feb, 2017 3 commits
-
-
Nicolas Capens authored
Dequeuing and queuing the graphics buffer takes care of ownership, and a previous patch ensured the buffer is unlocked before we queue it so we don't need to hold a reference for longer. Bug b/34981145 Bug b/35443034 Change-Id: I6cbaeff08f5d930dde8bdd1522052ac33a6ae9ac Reviewed-on: https://swiftshader-review.googlesource.com/8849Reviewed-by:
Greg Hartman <ghartman@google.com> Reviewed-by:
Nicolas Capens <capn@google.com> Tested-by:
Greg Hartman <ghartman@google.com>
-
Nicolas Capens authored
The buffer changes ownership after queuing it, so unlock it first. The decRef() gets removed in a subsequent patch. Bug b/34981145 Change-Id: I4710699af46a7cbde12e97bc444ad35747509b07 Reviewed-on: https://swiftshader-review.googlesource.com/8848Reviewed-by:
Greg Hartman <ghartman@google.com> Reviewed-by:
Nicolas Capens <capn@google.com> Tested-by:
Greg Hartman <ghartman@google.com>
-
Nicolas Capens authored
cancelBuffer() returns a graphics buffer to the buffer queue but doesn't pass it on to the consumer side. There's currently no reason for us to call it when the EGL surface gets destroyed or resized, since we only briefly dequeue the buffer to blit the already rendered result and immediately queue it again. Even if the queuing fails, we shouldn't try to cancel the buffer because that's essentially the same as a queueing but without valid content. It would fail with the same error, or worse, transfer ownership twice and mess up the reference counting. Bug b/34981145 Change-Id: Ia37a711db5ebd61bcde14cf4bc45097d4e2d33e8 Reviewed-on: https://swiftshader-review.googlesource.com/8814Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Greg Hartman <ghartman@google.com> Reviewed-by:
Nicolas Capens <capn@google.com> Tested-by:
Greg Hartman <ghartman@google.com>
-
- 17 Feb, 2017 1 commit
-
-
Alexis Hetu authored
Many new OpenGL ES 3 specific entries in Context::getIntegerv were not hidden when an OpenGL ES 2 context is created. The switch statement was separated in 2 statements in order to fix this. Change-Id: Ib218b72e854f5857958cfa14ecdfef5ae03ee92b Reviewed-on: https://swiftshader-review.googlesource.com/8851Tested-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Nicolas Capens <capn@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
-
- 15 Feb, 2017 3 commits
-
-
Nicolas Capens authored
Change-Id: I20b385c316f24b703da1d3071e393b4cde450173 Reviewed-on: https://swiftshader-review.googlesource.com/8811Tested-by:
Nicolas Capens <capn@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
-
Alexis Hetu authored
Silence a few warnings within the LLVM code used by Subzero which ended up being treated as errors when compiling Chromium for x86. Change-Id: If4d3c13ce0b01185d59a2cd064b2bad537639b94 Reviewed-on: https://swiftshader-review.googlesource.com/8813Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
-
Nicolas Capens authored
Change-Id: I21ec9c20a594fd322d17f2bcd1c58b298d4c0ce9 Reviewed-on: https://swiftshader-review.googlesource.com/8812Tested-by:
Nicolas Capens <capn@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
-
- 14 Feb, 2017 1 commit
-
-
Alexis Hetu authored
Once Subzero is pulled by Chromium (see https://codereview.chromium.org/2695813002/), we'll enable Subzero compilation on Windows. Change-Id: I3464dbd98224b3ac602aef3c4a27596366d275b3 Reviewed-on: https://swiftshader-review.googlesource.com/8772Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <capn@google.com>
-