- 01 Apr, 2015 3 commits
-
-
Jamie Madill authored
*re-land with fix for Chromium compile* This saves us from needing to replicate the same code in two places. BUG=angleproject:956 Change-Id: I68dffee715df03bd25685e3ed5c0506ffc41c3b9 Reviewed-on: https://chromium-review.googlesource.com/263258Tested-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org>
-
Jamie Madill authored
This class provides a simpler scheme for blocking default copy and assignment operators. It also reduces the amount of code needed since it's inherited to child classes. This also fixes the conflict between our macro and the same-named macro in Chromium code. BUG=angleproject:956 Change-Id: If0dc72aa3f63fbc7b8fa34907418821c64c39e2f Reviewed-on: https://chromium-review.googlesource.com/263257Tested-by:
-
Olli Etuaho authored
Implement drawRangeElements simply by calling drawElements internally. The start and end parameters passed to the function will be checked against results from index validation and an error is generated if indices fall outside the claimed range. Most dEQP-GLES3.functional.draw.draw_range_elements.* tests pass after this change. The remaining failures seem to be related to instanced attributes. BUG=angleproject:957 TEST=dEQP-GLES3.functional.draw.* Change-Id: Id3923eb8114461b441e593357bc49babfd6b5c15 Reviewed-on: https://chromium-review.googlesource.com/262420Reviewed-by:
Olli Etuaho <oetuaho@nvidia.com>
-
- 31 Mar, 2015 14 commits
-
-
Geoff Lang authored
Failures on Win 7/8 Debug NVIDIA bots. This reverts commit 1cb0a213. Change-Id: Ifb6b538e1b784a78c562a4d43d907bd0cdd59abf Reviewed-on: https://chromium-review.googlesource.com/263310Reviewed-by:
-
Geoff Lang authored
Change-Id: Iee9d9837c6021ad0c9d4f5749402c5d183e90f2a Reviewed-on: https://chromium-review.googlesource.com/263269Reviewed-by:
-
Geoff Lang authored
Change-Id: Ia561fc7bb0262ab6974517d9796e4828db5b511c Reviewed-on: https://chromium-review.googlesource.com/263251Reviewed-by:
-
Geoff Lang authored
Removing this allows many angle end2end tests to run without hitting any UNIMPLEMENTEDs. BUG=angleproject:882 Change-Id: Idb55fae7b6fc7b23bc85d0bf376499f28669d771 Reviewed-on: https://chromium-review.googlesource.com/263250Reviewed-by:
-
Jamie Madill authored
Causing a build conflig with Chromium's DISALLOW_COPY_AND_ASSIGN. http://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20Builder/builds/24738 This reverts commit 3ad467df. Change-Id: I0cf13e3bc3af90303a123813052cced0ba086515 Reviewed-on: https://chromium-review.googlesource.com/263159Reviewed-by:
-
Geoff Lang authored
BUG=angleproject:955 Change-Id: I8223349622531c8fff7c7cd45bdf4754d7619ae2 Reviewed-on: https://chromium-review.googlesource.com/263062Tested-by:
-
Olli Etuaho authored
The fact that passing shaders to the platform compiler is deferred until linking is performed allowed this bug to pass undetected in earlier manual testing. TEST=WebGL conformance tests BUG=angleproject:941 Change-Id: Ic12b5d0c5547057551df90086453e897a161d559 Reviewed-on: https://chromium-review.googlesource.com/263221Tested-by:
Nicolas Capens <capn@chromium.org>
-
Geoff Lang authored
The sampler state may have changed even if the texture is already bound. BUG=angleproject:884 Change-Id: I591f493099397bb07608096cf30ff46ed5090224 Reviewed-on: https://chromium-review.googlesource.com/263147Reviewed-by:
-
Jamie Madill authored
This saves us from needing to replicate the same code in two places. BUG=angleproject:956 Change-Id: Ibc80997eec184d0d5aa9c6c076c9d4507fbf8caa Reviewed-on: https://chromium-review.googlesource.com/262776Reviewed-by:
-
Jamie Madill authored
The basic test we can use for perf testing internal classes with mocks. The render tests are more specific to doing draw calls. BUG=angleproject:956 Change-Id: Iade393facc30c8d7288b1b94a159ce3afe993021 Reviewed-on: https://chromium-review.googlesource.com/262775Reviewed-by:
-
Jamie Madill authored
This D3D-only class has one method, used to generate the D3D IndexBuffer/VertexBuffer. This can help us mock up IndexDataManager. At a later point we can refactor the VertexFormat queries from Renderer into a Caps struct that mirrors our Texure Caps. BUG=angleproject:956 Change-Id: Id8b1220a763873ee871ce92365bbee03633789c7 Reviewed-on: https://chromium-review.googlesource.com/262774Reviewed-by:
-
Geoff Lang authored
BUG=angleproject:795 Change-Id: I76b44e837eb6919f9d3c1eb56c2d3af84bc5ab09 Reviewed-on: https://chromium-review.googlesource.com/260943Reviewed-by:
Kenneth Russell <kbr@chromium.org> Tested-by:
-
Olli Etuaho authored
This value is now redundant - it is always the same as regular offset. TEST=angle_end2end_tests BUG=angleproject:956 Change-Id: If4b6c8bcbebf24fbf84723fe081fd058916cc504 Reviewed-on: https://chromium-review.googlesource.com/262423Reviewed-by:
-
Olli Etuaho authored
Recomputing the stream offset is relatively cheap now after recent changes. Remove caching it to make the code less complex. TEST=angle_end2end_tests BUG=angleproject:956 Change-Id: Icb9cc4e4ffd685a78b7f8a45958992a471ebb0f5 Reviewed-on: https://chromium-review.googlesource.com/262422Reviewed-by:
-
- 30 Mar, 2015 10 commits
-
-
Jamie Madill authored
This is now located in src/ and Chromium no longer refers to it. BUG=None Change-Id: I64fd302629ca28aa367d8714bfbac2657774fc3b Reviewed-on: https://chromium-review.googlesource.com/262920Tested-by:
-
Maks Naumov authored
Change-Id: Ie10398e148dc0b88e5d7a5330307dc49553c6665 Reviewed-on: https://chromium-review.googlesource.com/263092Tested-by:
-
Geoff Lang authored
The overhead of the function call ended up being a hot spot for draw calls since the attributes are iterated over many times in VertexDataManager. BUG=angleproject:959 Change-Id: I9bbfcbd115661ad629db9ed93d683cd8d0dc9a78 Reviewed-on: https://chromium-review.googlesource.com/263102Tested-by:
-
Geoff Lang authored
Caused a warning on 32-bit builds. This reverts commit 20d78d24. Change-Id: I4d61024fb29978e7f1bacdd693fc6f1bc00bd0cc Reviewed-on: https://chromium-review.googlesource.com/262918Reviewed-by:
-
Gregoire Payen de La Garanderie authored
Also fixes the uniform count upper limit in glGetActiveUniformsiv. BUG=angleproject:507 Change-Id: Icfc90ed64cf94b1bab2d4cc93a8fb5e11b28d666 Reviewed-on: https://chromium-review.googlesource.com/261874Reviewed-by:
-
Olli Etuaho authored
Intermediate should only have logic for creating node objects, validation of parameter types belongs in ParseContext. BUG=angleproject:952 TEST=angle_unittests, WebGL conformance tests Change-Id: Ie90697641fabb2a837ccc4571a93616d63ea64e6 Reviewed-on: https://chromium-review.googlesource.com/262414Tested-by:
-
Geoff Lang authored
BUG=angleproject:959 Change-Id: Ie08e68ae27372a97bd118e61478201b0d3dad955 Reviewed-on: https://chromium-review.googlesource.com/262337Reviewed-by:
-
Geoff Lang authored
The overhead of the function call ended up being a hot spot for draw calls since the attributes are iterated over many times in VertexDataManager. BUG=angleproject:959 Change-Id: I6c11d4a5a22c314c69b3403dfdeb2d950b1c7639 Reviewed-on: https://chromium-review.googlesource.com/262336Reviewed-by:
-
Geoff Lang authored
The function call overhead of the constructors and assignement operators ended up being a hotspot even though the functions didn't do any significant work. BUG=angleproject:959 Change-Id: I96769879dabdbba7a222f98d87c5be0a829cb7dd Reviewed-on: https://chromium-review.googlesource.com/262335Reviewed-by:
-
Olli Etuaho authored
Use bitwise operations instead of division, which is expensive on multiple CPU architectures. BUG=angleproject:956 TEST=angle_end2end_tests Change-Id: I57ab540d447c03dae5a96bafb4975fc37e310261 Reviewed-on: https://chromium-review.googlesource.com/262181Tested-by:
-
- 29 Mar, 2015 1 commit
-
-
Olli Etuaho authored
Float-int conversion functions are defined to always return highp values. BUG=angleproject:865 TEST=angle_unittests Change-Id: Idf243b483f7b5edfcb54de2755af11e17c3756d3 Reviewed-on: https://chromium-review.googlesource.com/262413Tested-by:
-
- 27 Mar, 2015 5 commits
-
-
Geoff Lang authored
BUG=angleproject:886 Change-Id: I7480943d678b2cdf6e997c3f8316acdef32f5f0d Reviewed-on: https://chromium-review.googlesource.com/260889Reviewed-by:
-
Geoff Lang authored
BUG=angleproject:886 Change-Id: I74375351339464b450c2f058adbeed7a1ba18cdd Reviewed-on: https://chromium-review.googlesource.com/262125Reviewed-by:
-
Geoff Lang authored
BUG=angleproject:885 Change-Id: Ifb5818f185236c671cd7f20ed352edb887b49675 Reviewed-on: https://chromium-review.googlesource.com/258420Reviewed-by:
-
Austin Kinross authored
Change-Id: I59020f8152d47091533d69d20fe5ff56e5f96bc1 Reviewed-on: https://chromium-review.googlesource.com/262551Reviewed-by:
Austin Kinross <aukinros@microsoft.com>
-
Olli Etuaho authored
This should be faster, and also matches the C++ style rules better: static variables should not have complex class types. BUG=angleproject:956 TEST=angle_end2end_tests, WebGL conformance tests Change-Id: I628db95febab309e241be216e2998305525da76e Reviewed-on: https://chromium-review.googlesource.com/262421Tested-by:
-
- 26 Mar, 2015 6 commits
-
-
Geoff Lang authored
Causes failures in video related WebGL tests. Either there is a bug in the implementation or how chrome is using it. This reverts commit b13daa8f. Change-Id: Ic0d74840c664bf4de18d85cc3ff7f7153936d9b0 Reviewed-on: https://chromium-review.googlesource.com/262715Reviewed-by:
-
Jamie Madill authored
Causing a high-volume crashe in Chrome. This reverts commit 434953e2. BUG=470695 Change-Id: I2062c706ab6ca6b4c3117685df67c33572518da5 Reviewed-on: https://chromium-review.googlesource.com/262704Reviewed-by:
-
Jacek Caban authored
Change-Id: I027cedc383efbd215e55a7ddf4e41eb1c368a1ae Reviewed-on: https://chromium-review.googlesource.com/262590Reviewed-by:
Jacek Caban <cjacek@gmail.com>
-
Austin Kinross authored
Change-Id: I0e39a196796813203c841c46aa2a6b89957f6051 Reviewed-on: https://chromium-review.googlesource.com/261355Reviewed-by:
-
Olli Etuaho authored
Remove extraneous semicolons and fix indentation in a couple of places. TEST=angle_unittests Change-Id: Iaa51eb50990c0435f41dfd346ec161216cd8d372 Reviewed-on: https://chromium-review.googlesource.com/261823Tested-by:
-
Olli Etuaho authored
ESSL 1.00 spec section 5.9 says that equality operators don't operate on structs containing sampler types. Section 5.7 also suggests this. ESSL 3.00 doesn't have a similar restriction. ESSL 1.00 spec section 4.1.7 says that structs containing samplers can't be used as l-values. This is interpreted to apply also in the case of ESSL 3.00, which similarly disallows samplers as l-values, but doesn't explicitly mention structs. BUG=angleproject:954 TEST=angle_unittests, WebGL conformance tests Change-Id: I73f74962a192e8d9449990ffa5f3d8c851491601 Reviewed-on: https://chromium-review.googlesource.com/261822Tested-by:
-
- 25 Mar, 2015 1 commit
-
-
Olli Etuaho authored
This requires sorting all equality functions together so that struct equality functions can have dependencies on array equality functions, but support for array equality functions that have dependencies on struct equality functions is also maintained. There's no automated test coverage for this specifically. The change was tested by manually inspecting shader output and ensuring that there were no test regressions in tests listed below. TEST=dEQP-GLES3.functional.shaders.* BUG=angleproject:954 Change-Id: If7199ab2446804afae50f103bb625101172882b9 Reviewed-on: https://chromium-review.googlesource.com/261550Reviewed-by:
-
