Commits · de1e00e1e80eb9d5fd875415ae052b5dc8dcc601 · Chen Yisong / angle

10 Oct, 2014 4 commits

Implement support of unary operator "+" in translator. · de1e00e1

authored Oct 09, 2014

BUG=angle:779
TEST=conformance/glsl/misc/struct-unary-operators.html

Change-Id: Ia827e07dcfc8ad3bbbc078e54336815be9027945
Reviewed-on: https://chromium-review.googlesource.com/222720Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Zhenyao Mo <zmo@chromium.org>

de1e00e1

Improve the TextureStorage11 SRV cache. · 9ad2ab33

authored Sep 09, 2014

 * Use a std::map instead of std::vector for logarithmic search time.
 * Reduce the number of structs and make them private instead of
   protected since they arn't used outside of the base class.
 * Fix the SRV cache member name.

BUG=angle:520

Change-Id: I5158c1d46523f46158c51cd68044f7c915a3de03
Reviewed-on: https://chromium-review.googlesource.com/217335Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

9ad2ab33

Refactor Texture::storage methods to use gl::Error objects. · 1f8532bd

authored Sep 05, 2014

BUG=angle:520

Change-Id: I33bc8479815a587749bddc722ac9fe5a85f554cb
Reviewed-on: https://chromium-review.googlesource.com/216648Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

1f8532bd

Refactor Texture::copy*Image methods to use gl::Error objects. · ef7b016a

authored Sep 04, 2014

BUG=angle:520

Change-Id: I8b6bf5d50ee0d1f796eff52919ee65823fdee6cb
Reviewed-on: https://chromium-review.googlesource.com/216647Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

ef7b016a

09 Oct, 2014 5 commits

Make OSWindow a non-static member of ANGLETest. · 4119ed3d

authored Oct 01, 2014

BUG=angle:611

Change-Id: I455e1dd0ad5582191621e316c4808a2d753e9aaa
Reviewed-on: https://chromium-review.googlesource.com/219867Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

4119ed3d

Add workaround for Unicode compile error. · 91f2911f

authored Oct 09, 2014

Chromium builds define UNICODE, while we don't, which confuses
the built-in IDC_ARROW macro.

With this fix, and http://crbug.com/415983, we can build
angle_perf_tests in Chromium.

BUG=angle:744

Change-Id: I268a7c11a5b5355cb2485bf10faf750972cf4e30
Reviewed-on: https://chromium-review.googlesource.com/220363Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

91f2911f

Remove perf tests dependency on gtest. · 2ff18fb6

authored Oct 09, 2014

BUG=angle:744

Change-Id: I9272e0009238680db1a87e6cb1c1c48b2ed48dd6
Reviewed-on: https://chromium-review.googlesource.com/220362Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

2ff18fb6

Use Chromium perf bot output style for perf test. · fc63152a

authored Oct 09, 2014

The Chromium style output will allow the perf bots to collect data
from our performance tests.

BUG=angle:744

Change-Id: I2ffdace688004edf2918ead2a3e2aa2a6c4daf95
Reviewed-on: https://chromium-review.googlesource.com/220361Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

fc63152a

Import the testing/perf module from Chromium. · 98f87eb2

authored Oct 09, 2014

We can use these perf routines to make our performance test output
compatible with the Chromium perf bots.

BUG=angle:744

Change-Id: I75a44786d4521fc0c7d8226f10575fcfda0fa221
Reviewed-on: https://chromium-review.googlesource.com/220360Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

98f87eb2

08 Oct, 2014 6 commits

Use GL_APIENTRY and EGLAPIENTRY instead of __stdcall directly. · 67ea190d

authored Oct 06, 2014

BUG=angleproject:773

Change-Id: Iab098f787b966bf3999c22687af113cc9909593b
Reviewed-on: https://chromium-review.googlesource.com/221796Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Kenneth Russell <kbr@chromium.org>

67ea190d

Refactor libGLESv2.gypi to allow libANGLE to be built on all platforms. · 1ce845d7

authored Oct 06, 2014

Required pulling angle_enable_d3d{9,11} into angle.gypi and definition
of angle_libangle_win_sources. Pull in those sources in BUILD.gn.

Tested with local GYP build on Windows. Did not test GN build yet.

BUG=angleproject:773

Change-Id: Ia3703fe4fa2bc8a1682c1fa1667ca36268b36cc7
Reviewed-on: https://chromium-review.googlesource.com/221785Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Kenneth Russell <kbr@chromium.org>

1ce845d7

Updated Renderer::sync to return Error objects. · 2629856f

authored Oct 01, 2014

BUG=angle:520

Change-Id: I8f1f095977bab3848b9215cda1127a71982858b8
Reviewed-on: https://chromium-review.googlesource.com/220800Reviewed-by: Nicolas Capens <capn@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

2629856f

Perform short-circuit unfolding on separate declarations. · fa41aa08

authored Oct 06, 2014

BUG=415694

Change-Id: I812abb21d2ab4af0b63631a23026d5860df61672
Reviewed-on: https://chromium-review.googlesource.com/221945Tested-by: Nicolas Capens <capn@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

fa41aa08

Split combined declarations into separate statements. · d974db43

authored Oct 07, 2014

BUG=415694

Change-Id: I7afb08a8a5ed10bbc6f7d23638daca6982f7c88b
Reviewed-on: https://chromium-review.googlesource.com/221455Tested-by: Nicolas Capens <capn@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

d974db43

Updated the FenceSync and FenceNV objects to use Error objects. · 882033e7

authored Sep 30, 2014

BUG=angle:520

Change-Id: I1e49b35905d8916baadb129c8aa58a11bd721500
Reviewed-on: https://chromium-review.googlesource.com/220781Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

882033e7

07 Oct, 2014 5 commits

Add type comparison, type retrieval, original name retrieval to ShaderVariable. · ed13636a

authored Oct 03, 2014

This is needed to effectively use the new APIs to get shader variable info.

BUG=angle::770
TEST=ShaderVariableTest

Change-Id: Ia591eb567868ebe898f4a7449c64167ad212f59b
Reviewed-on: https://chromium-review.googlesource.com/221388Tested-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

ed13636a

Add needed static_casts to GLenum for compilation on Linux. · e0a2d1c5

authored Oct 06, 2014

BUG=angleproject:773

Change-Id: I8b01a1f187456eb8997fc7a620b5ecdffb872c19
Reviewed-on: https://chromium-review.googlesource.com/221810Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Kenneth Russell <kbr@chromium.org>

e0a2d1c5

Enable TexSubImage workaround on D3D11. · 9aca059f

authored Oct 06, 2014

This workaround uses UpdateResource instead of staging buffers for
texture data updates. It improves performance for highly dynamic
textures, especially in some benchmarks, eg the turbulenz particle
demo.

Re-land, with fix to the issue with glGenerateMipmaps.

BUG=angle:729
BUG=365078

Change-Id: I4c9398e0645176c296bf95e35eab97a44eae4319
Reviewed-on: https://chromium-review.googlesource.com/221493Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

9aca059f

Use ImageIndex in copyToStorage. · 6b51c1a0

authored Oct 06, 2014

Also change the image association methods in TexStorage to use
ImageIndex, for consistency and compatibility.

BUG=angle:729

Change-Id: I05afa803735c9b93ae7d623fee5e6899c9ccec28
Reviewed-on: https://chromium-review.googlesource.com/221722Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

6b51c1a0

Use mTopLevel in getSubresourceIndex. · c8d13843

authored Oct 06, 2014

We need to include this in every call, so might as well handle it
automatically.

BUG=angle:729

Change-Id: I5c230408a9eb80c8cfcc3f0d3a4ea531fa173aed
Reviewed-on: https://chromium-review.googlesource.com/221760Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

c8d13843

06 Oct, 2014 2 commits

Fix image index iterator unit test. · 1ea53509

authored Oct 06, 2014

This test was checking out-of-bounds. The bug only showed up in
Linux.

BUG=angle:741

Change-Id: I4cb45fc00dbb0bf9713f735a20fb6fd04bc95140
Reviewed-on: https://chromium-review.googlesource.com/221057Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

1ea53509

Use ImageIndex as a parameter to TextureD3D::setImage. · ba6bc95e

authored Oct 06, 2014

This will allow us to call the TexureStorage::setData easily.

BUG=angle:729

Change-Id: I16ada583894c8c427c78de5050f7f462c96d1fd1
Reviewed-on: https://chromium-review.googlesource.com/221492Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

ba6bc95e

04 Oct, 2014 1 commit

Make blit extension check for internal format mismatch. · f8f18f05

authored Oct 02, 2014

The extension spec dictates a format mismatch generates invalid
operation. Since we can't have the same internal format map to
different actual/native formats, this check is more strict and
we can replace the previous one.

BUG=angle:769

Change-Id: Ic1b5c335ba38a4f2feaffa1478a65e7fcf7f75ea
Reviewed-on: https://chromium-review.googlesource.com/221065Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

f8f18f05

03 Oct, 2014 13 commits

Revert "Enable TexSubImage workaround on D3D11." · dcd8f13d

authored Oct 03, 2014

Probably causing WebGL CTS failures:

http://build.chromium.org/p/chromium.gpu.fyi/builders/Win8%20Release%20%28NVIDIA%29/builds/6148

This reverts commit 2d337ce0.

Change-Id: Ic032640f44adf337c4b3eedd4d7f3551d565a5cb
Reviewed-on: https://chromium-review.googlesource.com/221397Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

dcd8f13d

Enable TexSubImage workaround on D3D11. · 2d337ce0

authored Oct 03, 2014

This workaround uses UpdateResource instead of staging buffers for
texture data updates. It improves performance for highly dynamic
textures, especially in some benchmarks, eg the turbulenz particle
demo.

BUG=angle:729
BUG=365078

Change-Id: Idd82c27845a772199caef3695111c96735e8843e
Reviewed-on: https://chromium-review.googlesource.com/219864Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

2d337ce0

Use COM object dynamic cast for RT resource queries. · 468b26bb

authored Oct 03, 2014

BUG=angle:729

Change-Id: I55af209211329a7a71728e3c6d55d87154cfb45e
Reviewed-on: https://chromium-review.googlesource.com/221269Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

468b26bb

Use gl::Rectangle as a param to Image::copy. · 82bf0c5a

authored Oct 03, 2014

BUG=angle:729

Change-Id: I13194760df35cb18db6ac43d567e6b393e838d56
Reviewed-on: https://chromium-review.googlesource.com/221268Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

82bf0c5a

Accept a second form of WARP Test renderer string. · 00e5452a

authored Oct 02, 2014

On our Renderer test, we would be overly restrictive in the forms
of Renderer string we would accept for WARP. On this machine, it
returns a different string than the one we had in the test. Expand
the test to accept both.

BUG=angle:769

Change-Id: If27644d32d6d7d0eff77ff9cca81faee3b2be4e1
Reviewed-on: https://chromium-review.googlesource.com/221066Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

00e5452a

Restrict the tests that use ClearBuffer to ES3. · 94203b36

authored Oct 02, 2014

We had changed the configurations to run them in ES2 mode, while
ClearBuffer is an ES3-only method.

BUG=angle:769

Change-Id: I63d92af4702a133aa8bbf52444dfef59a4f602b0
Reviewed-on: https://chromium-review.googlesource.com/221064Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

94203b36

Updated authorship and contributors for Borbitsoft/Tibor den Ouden · 448ac908

authored Oct 02, 2014

Removed Borbitsoft from the AUTHORS file, added Tibor den Ouden.
Removed Borbitsoft from CONTRIBUTORS file, company section.
Moved Tibor den Ouden in CONTRIBUTORS file from company section to individual section

Change-Id: I3ab47d637d0879fde8f9dc0f714e2cb44562c897
Reviewed-on: https://chromium-review.googlesource.com/221054Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

448ac908

Update Program, ProgramBinary and HLSLCompiler to use Error objects. · b543afff

authored Sep 30, 2014

BUG=angle:520

Change-Id: Ibbe8c95780fecfb68f4558e99e3a761107da6aee
Reviewed-on: https://chromium-review.googlesource.com/220790Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

b543afff

Add option to support EXT_draw_buffers with NV_draw_buffers · e61209af

authored Sep 26, 2014

After this patch, it is possible to set a flag to change
EXT_draw_buffers extension directives to NV_draw_buffers in ESSL.
This enables users of ANGLE to emulate EXT_draw_buffers by using
NV_draw_buffers in combination with GLES3.0.

Change-Id: I5dacdbd6cd0d0362424ea3791557342c42efd4bd
Reviewed-on: https://chromium-review.googlesource.com/219941Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e61209af

Add TextureStorage::setData. · 955f5c05

authored Oct 02, 2014

Usually we copy data from the Image classes into the Storage. This
method, which will only apply to D3D11, is useful for our SubData
performance workaround.

BUG=angle:729

Change-Id: I50ca8158ee9e0638f59f617b9e6170b508eaeb44
Reviewed-on: https://chromium-review.googlesource.com/219837Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

955f5c05

Use the virtual commitRegion in TextureD3D::subData. · e6b6da03

authored Oct 02, 2014

This allows us remove the duplicated code in the various typed
methods that checks for an error before committing.

BUG=angle:729

Change-Id: Icd0ad2be55ac423baec3855e05c53f4b624b6764
Reviewed-on: https://chromium-review.googlesource.com/220275Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

e6b6da03

Introduce new method commitRegion to TextureD3D. · 7cb2b9d7

authored Oct 02, 2014

Replacing commitRect with commitRegion, which takes generic
parameter types, will allow us to call it directly from the
base class TextureD3D. This will be useful in subsequent
patches that introduce the SubData performance workaround.

BUG=angle:729

Change-Id: I37bf12f847b43f7c961b403321de19f547258b01
Reviewed-on: https://chromium-review.googlesource.com/220274Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

7cb2b9d7

Fix building angleutils.cpp on Linux · 86ffde57

authored Oct 03, 2014

vsnprintf is defined in stdio.h according to the standard. It was not in
the include chain of angleutils.cpp, which broke the build on Linux on
some configurations. Seems like other toolchains include the function in
some non-standard way.

BUG=angle:761

Change-Id: Idcd75776e8a9b83dad182d1b4bac0beac006c6ac
Reviewed-on: https://chromium-review.googlesource.com/221053Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

86ffde57

02 Oct, 2014 4 commits

Fix typos in caps generation method names. · d8111baf

authored Sep 26, 2014

Change-Id: I7efa752b2276cb92b4ca12ffaf7aa37c514525f0
Reviewed-on: https://chromium-review.googlesource.com/219807Tested-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

d8111baf

Store XFB buffers in a vector in State. · 8299bb0f

authored Sep 26, 2014

BUG=angle:685

Change-Id: I4bff717f716ba21633c59244560fd56f41f587ed
Reviewed-on: https://chromium-review.googlesource.com/219806Tested-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

8299bb0f

Use a caps-dependent sized vector to store Uniform Buffers · f3acaf9e

authored Sep 23, 2014

BUG=angle:685

Change-Id: I3f2e9fcccf27aebbb4ec5485286eec9828851887
Reviewed-on: https://chromium-review.googlesource.com/219805Tested-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

f3acaf9e

Change mVertexAttribCurrentValues from fixed-size array to STL container. · 23e0500d

authored Sep 22, 2014

BUG=angle:685

Change-Id: I42fc6c919f42cd6ab1c11531742f9a2c5ad0cd3d
Reviewed-on: https://chromium-review.googlesource.com/219353Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

23e0500d