Skip to content

S
swiftshader
Switch branch/tag
  1. 17 Dec, 2015 1 commit
    • Subzero. Introduces a new LoweringContext::insert() method. · 1d937a8e
      John Porto authored 
      Emitting an instruction in Subzero requires a fair amount of
boilerplated code:

Context.insert(<InstType>::create(Func, <Args>...));

The ordeal is worse if one needs access to the recently create
instructionL

auto *Instr = <InstType>::create(Func, <Args>...);
Context.insert(Instr);
Instr->...

This CL introduces a new LoweringContext::insert() method:

template <<InstType>, <Args>...>
<InstType> *LoweringContext::insert(<Args>...) {
  auto *New = Inst::create(Node.Cfg, <Args>...);
  insert(New);
  return New;
}

This is essentially a syntatic sugar that allows instructions to be
emitted by using

Context.insert<InstType>(<Args>...);

The compiler should be able to inline the calls (and get rid of the
return value) when appropriate.

make bloat reviews a small increase in translator code size

BUG=
R=sehr@chromium.org, stichnot@chromium.org

Review URL: https://codereview.chromium.org/1527143003 .
  3. 16 Dec, 2015 5 commits
  5. 15 Dec, 2015 2 commits
  7. 14 Dec, 2015 1 commit
  9. 12 Dec, 2015 1 commit
  11. 11 Dec, 2015 5 commits
  13. 10 Dec, 2015 2 commits
  15. 09 Dec, 2015 3 commits
  17. 08 Dec, 2015 4 commits
  19. 07 Dec, 2015 3 commits
  21. 05 Dec, 2015 1 commit
  23. 04 Dec, 2015 6 commits
  25. 03 Dec, 2015 2 commits
    • Subzero. ARM32. Folding rematerializable offsets in address operands. · 866b6b19
      John Porto authored 
      BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076
R=stichnot@chromium.org

Review URL: https://codereview.chromium.org/1477873002 .
    • fix doxygen brief in subzero header files · 92a6e5b0
      Jim Stichnoth authored 
      There is a consistent mistake in most of the file level subzero doxygen
comments which stems from a problem with brief.

Basically, there are two types of documentation in Doxygen, inline and
structural documentation. File level documentation is always structural
because inline documentation must either come before or after the entity
and for a file that would be impossible.

When you have structure documentation, the brief and detailed is
handled differently and you have to explicity put the \brief qualifier in.

We were only doing this for a few files so when you looked the doxygen
for the source directory, the description was blank for almost all of them.
If you build docs with this patch and look at the "files" and src
directory, you will see all the brief descriptions now.

In addition I deleted the text "This file ..." from the
beginning of all the file desriptions because it's redundant when you look at the doxygen output and adds
no information but takes up space in the descripton.
BUG=
R=stichnot@chromium.org

Review URL: https://codereview.chromium.org/1488913002 .
  27. 02 Dec, 2015 2 commits
  29. 01 Dec, 2015 2 commits